Skip to content

Revert "[serverless] No-op AWS Lambda integration on missing API Key"#5941

Merged
duncanista merged 1 commit into
masterfrom
jordan.gonzalez/revert/8e63384717cc1a2608815c661c13c65ed94ba965
Aug 23, 2024
Merged

Revert "[serverless] No-op AWS Lambda integration on missing API Key"#5941
duncanista merged 1 commit into
masterfrom
jordan.gonzalez/revert/8e63384717cc1a2608815c661c13c65ed94ba965

Conversation

@duncanista

@duncanista duncanista commented Aug 23, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary of changes

This reverts commit 8e63384.

Reason for change

It doesn't account for DD_API_KEY_SECRET_ARN or DD_KMS_API_KEY which is considered a regression.

Implementation details

n/a

Test coverage

Confirmed that it stops working for Lambdas with that configuration

Other details

@duncanista
duncanista requested review from a team as code owners August 23, 2024 15:51
@duncanista duncanista mentioned this pull request Aug 23, 2024
Closed
@datadog-ddstaging

datadog-ddstaging Bot commented Aug 23, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: jordan.gonzalez/revert/8e63384717cc1a2608815c661c13c65ed94ba965
Commit report: 6d7bddc
Test service: dd-trace-dotnet

✅ 0 Failed, 301275 Passed, 1616 Skipped, 11h 52m 6.39s Total Time

@andrewlock

andrewlock commented Aug 23, 2024

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@duncanista
duncanista merged commit 1005d98 into master Aug 23, 2024
@duncanista
duncanista deleted the jordan.gonzalez/revert/8e63384717cc1a2608815c661c13c65ed94ba965 branch August 23, 2024 18:45
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes
@bouwkast bouwkast bouwkast approved these changes
@andrewlock andrewlock andrewlock approved these changes
+1 more reviewer
@DylanLovesCoffee DylanLovesCoffee DylanLovesCoffee approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:serverless

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

5 participants

@duncanista @andrewlock @lucaspimentel @bouwkast @DylanLovesCoffee