-
Notifications
You must be signed in to change notification settings - Fork 159
Add SSI denylist and tests #5928
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
e7ef450
Add requirements.json and testing files
andrewlock a12e22a
Document that we should update requirements.json if we update the bai…
andrewlock c81d1c5
TEMP use branch of libdatadog
andrewlock 6640607
Add requirements.json to package
andrewlock 8f96552
Update requirements to latest spec
andrewlock 03fd74a
Revert "TEMP use branch of libdatadog"
andrewlock b7600d7
TEMP checkout the updated-denylist branch
andrewlock 20cec93
Revert "TEMP checkout the updated-denylist branch"
andrewlock 67bda22
Apply suggestions from code review
andrewlock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,187 @@ | ||
| { | ||
| "$schema": "https://raw.githubusercontent.com/DataDog/auto_inject/refs/heads/main/preload_go/cmd/library_requirements_tester/testdata/requirements_schema.json", | ||
| "version": 1, | ||
| "native_deps": { | ||
| "glibc": [{ | ||
| "arch": "x64", | ||
| "supported": true, | ||
| "description": "From centOS 7", | ||
| "min": "2.17" | ||
| }, | ||
| { | ||
| "arch": "arm64", | ||
| "supported": true, | ||
| "description": "From debian buster (10), which is 2.28, but we verify we don't exceed 2.23", | ||
| "min": "2.23" | ||
| }], | ||
| "musl": [{ | ||
| "arch": "x64", | ||
| "supported": true, | ||
| "description": "From alpine 3.14" | ||
| },{ | ||
| "arch": "arm64", | ||
| "supported": true, | ||
| "description": "From alpine 3.18" | ||
| }] | ||
| }, | ||
| "deny": [ | ||
| { | ||
| "id": "dotnet_core_uninstall", | ||
| "description": "Ignore dotnet-core-uninstall which is self-contained app", | ||
| "os": null, | ||
| "cmds": [ | ||
| "**/dotnet-core-uninstall" | ||
| ], | ||
| "args": [], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "vsdbg", | ||
| "description": "Ignore vsdbg Visual Studio debug bridge", | ||
| "os": null, | ||
| "cmds": [ | ||
| "**/vsdbg" | ||
| ], | ||
| "args": [], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dd_trace", | ||
| "description": "Ignore our own dd-trace runner", | ||
| "os": null, | ||
| "cmds": [ | ||
| "**/dd-trace" | ||
| ], | ||
| "args": [], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dd_dotnet", | ||
| "description": "Ignore our own dd-dotnet runner", | ||
| "os": null, | ||
| "cmds": [ | ||
| "**/dd-dotnet" | ||
| ], | ||
| "args": [], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_build", | ||
| "description": "Ignore dotnet build", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [{ "args": ["build"], "position": 1}], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_build_server", | ||
| "description": "Ignore dotnet build-server", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [{ "args": ["build-server"], "position": 1}], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_clean", | ||
| "description": "Ignore dotnet clean", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [{ "args": ["clean"], "position": 1}], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_msbuild", | ||
| "description": "Ignore dotnet msbuild", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [{ "args": ["msbuild"], "position": 1}], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_new", | ||
| "description": "Ignore dotnet new", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [{ "args": ["new"], "position": 1}], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_nuget", | ||
| "description": "Ignore dotnet nuget", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [{ "args": ["nuget"], "position": 1}], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_pack", | ||
| "description": "Ignore dotnet pack", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [{ "args": ["pack"], "position": 1}], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_publish", | ||
| "description": "Ignore dotnet publish", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [{ "args": ["publish"], "position": 1}], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_restore", | ||
| "description": "Ignore dotnet restore", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [{ "args": ["restore"], "position": 1}], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_tool", | ||
| "description": "Ignore dotnet tool", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [{ "args": ["tool"], "position": 1}], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_workload", | ||
| "description": "Ignore dotnet workload", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [{ "args": ["workload"], "position": 1}], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_exec_csc", | ||
| "description": "Ignore dotnet exec **/csc.dll", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [ | ||
| { "args": ["exec"], "position": 1}, | ||
| { "args": ["*csc.dll"], "position": null} | ||
| ], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "dotnet_exec_vbcscompiler", | ||
| "description": "Ignore dotnet exec **/VBCSCompiler.dll", | ||
| "os": null, | ||
| "cmds": [ "**/dotnet"], | ||
| "args": [ | ||
| { "args": ["exec"], "position": 1}, | ||
| { "args": ["*VBCSCompiler.dll"], "position": null} | ||
| ], | ||
| "envars": null | ||
| }, | ||
| { | ||
| "id": "already_instrumented", | ||
| "description": "Ignore if the process is already has automatic instrumentation", | ||
| "os": null, | ||
| "cmds": [ ], | ||
| "args": [], | ||
| "envars": { "CORECLR_PROFILER_PATH*": null, "CORECLR_ENABLE_PROFILING": "1" } | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| [ | ||
| {"name": "min glibc x64", "filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "x64", "libc": "glibc:2.17"}}, | ||
| {"name": "ok glibc x64", "filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "x64", "libc": "glibc:2.23"}}, | ||
| {"name": "high glibc x64", "filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "x64", "libc": "glibc:3.0"}}, | ||
| {"name": "musl x64", "filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "x64", "libc": "musl:1.2.2"}}, | ||
| {"name": "min glibc arm64", "filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "arm64", "libc": "glibc:2.23"}}, | ||
| {"name": "ok glibc arm64", "filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "arm64", "libc": "glibc:2.27"}}, | ||
| {"name": "musl arm64", "filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "x64", "libc": "musl:1.2.2"}}, | ||
| {"name": "windows", "filepath": "/some/path", "args": [], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet run", "filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "run", "myproj.csproj"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet test", "filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "test", "myproj.csproj"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet exec path", "filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "exec", "/some/path"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet exec flag", "filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "exec", "-flag", "/some/path"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "not-dotnet build", "filepath": "/pathto/not-dotnet", "args": ["/pathto/not-dotnet", "build"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet buildme", "filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "buildme"], "envars": [], "host": {"os": "windows", "arch": "x64"}} | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| [ | ||
| {"name": "unsupported 2.x glibc x64","filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "x64", "libc": "glibc:2.16"}}, | ||
| {"name": "unsupported 1.x glibc x64","filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "x64", "libc": "glibc:1.22"}}, | ||
| {"name": "unsupported 2.x.x glibc x64","filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "x64", "libc": "glibc:2.16.9"}}, | ||
| {"name": "unsupported 2.x glibc arm64","filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "arm64", "libc": "glibc:2.22"}}, | ||
| {"name": "unsupported 2.x.x glibc x64","filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "arm64", "libc": "glibc:2.22.9"}}, | ||
| {"name": "glibx x86","filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "x86", "libc": "glibc:2.23"}}, | ||
| {"name": "musl x86","filepath": "/some/path", "args": [], "envars": [], "host": {"os": "linux", "arch": "x86", "libc": "musl:1.2.2"}}, | ||
| {"name": "dotnet-core-uninstall","filepath": "/some/path/to/dotnet-core-uninstall", "args": ["/some/path/to/dotnet-core-uninstall"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet-core-uninstall with flags","filepath": "/some/path/to/dotnet-core-uninstall", "args": ["/some/path/to/dotnet-core-uninstall", "-a", "--force"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet msbuild","filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "msbuild", "myproj.csproj"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet nuget","filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "nuget", "restore", "myproj.csproj"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet restore","filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "restore", "myproj.csproj"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet build","filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "build"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet tool","filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "tool", "install", "dd-trace"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet exec csc.dl","filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "exec","/usr/share/dotnet/sdk/6.0.400/Roslyn/bincore/csc.dll", "/noconfig", "@/tmp/tmp8895f601306443a6a54388ecc6dcfc44.rsp"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet exec flags csc.dl","filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "exec", "-framework", "net7.0", "/usr/share/dotnet/sdk/6.0.400/Roslyn/bincore/csc.dll", "/noconfig", "@/tmp/tmp8895f601306443a6a54388ecc6dcfc44.rsp"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dotnet exec VBCSCompiler.dll","filepath": "/pathto/dotnet", "args": ["/pathto/dotnet", "exec", "-framework", "net7.0", "/usr/share/dotnet/sdk/6.0.400/Roslyn/bincore/VBCSCompiler.dll", "/noconfig", "@/tmp/tmp8895f601306443a6a54388ecc6dcfc44.rsp"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dd-dotnet run myapp","filepath": "/pathto/dd-dotnet", "args": ["/pathto/dd-dotnet", "run", "myapp"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dd-trace run -- myapp","filepath": "/pathto/dd-trace", "args": ["/pathto/dd-trace", "run", "--", "myapp"], "envars": [], "host": {"os": "windows", "arch": "x64"}}, | ||
| {"name": "dd-trace ci -- myapp","filepath": "/pathto/dd-trace", "args": ["/pathto/dd-trace", "ci", "--", "myapp"], "envars": [], "host": {"os": "windows", "arch": "x64"}} | ||
| ] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.