Skip to content

Remove obsolete lib-injection build artifacts#5927

Merged
andrewlock merged 1 commit into
masterfrom
andrew/ci/remove-obsolete-artifacts
Aug 23, 2024
Merged

Remove obsolete lib-injection build artifacts#5927
andrewlock merged 1 commit into
masterfrom
andrew/ci/remove-obsolete-artifacts

Conversation

@andrewlock

@andrewlock andrewlock commented Aug 22, 2024

Copy link
Copy Markdown
Member

Summary of changes

Removes obsolete files

Reason for change

We don't use them any more - it's all handled by the one-pipeline

Implementation details

delete

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Aug 22, 2024
@andrewlock
andrewlock requested a review from a team as a code owner August 22, 2024 10:40
@datadog-ddstaging

datadog-ddstaging Bot commented Aug 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/ci/remove-obsolete-artifacts
Commit report: 85fe393
Test service: dd-trace-dotnet

✅ 0 Failed, 299872 Passed, 1595 Skipped, 12h 21m 17.56s Total Time

@andrewlock

andrewlock commented Aug 22, 2024

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@andrewlock

andrewlock commented Aug 22, 2024

Copy link
Copy Markdown
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #5927 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.127
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.79μs 40.5ns 199ns 0.0153 0.00764 0 5.42 KB
master StartStopWithChild netcoreapp3.1 9.78μs 53.2ns 315ns 0.0203 0.0101 0 5.61 KB
master StartStopWithChild net472 16μs 57.7ns 223ns 1.01 0.292 0.0948 6.07 KB
#5927 StartStopWithChild net6.0 7.65μs 42ns 238ns 0.0156 0.00779 0 5.43 KB
#5927 StartStopWithChild netcoreapp3.1 9.85μs 49.2ns 265ns 0.0245 0.00978 0 5.62 KB
#5927 StartStopWithChild net472 15.9μs 23.2ns 86.9ns 1.03 0.317 0.103 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 462μs 231ns 866ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 228ns 882ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 836μs 390ns 1.51μs 0.417 0 0 3.3 KB
#5927 WriteAndFlushEnrichedTraces net6.0 456μs 210ns 784ns 0 0 0 2.7 KB
#5927 WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 264ns 989ns 0 0 0 2.7 KB
#5927 WriteAndFlushEnrichedTraces net472 850μs 364ns 1.41μs 0.431 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 193μs 1.07μs 6.68μs 0.182 0 0 18.45 KB
master SendRequest netcoreapp3.1 213μs 1.18μs 9.12μs 0.22 0 0 20.61 KB
master SendRequest net472 0.00227ns 0.000957ns 0.00371ns 0 0 0 0 b
#5927 SendRequest net6.0 190μs 1.05μs 6.27μs 0.187 0 0 18.45 KB
#5927 SendRequest netcoreapp3.1 217μs 1.23μs 8.62μs 0.209 0 0 20.61 KB
#5927 SendRequest net472 0.00053ns 0.000316ns 0.00118ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 566μs 3μs 15μs 0.548 0 0 41.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 676μs 2.01μs 7.52μs 0.334 0 0 41.91 KB
master WriteAndFlushEnrichedTraces net472 860μs 1.87μs 6.73μs 8.45 2.53 0.422 53.28 KB
#5927 WriteAndFlushEnrichedTraces net6.0 571μs 2.6μs 9.37μs 0.561 0 0 41.68 KB
#5927 WriteAndFlushEnrichedTraces netcoreapp3.1 683μs 3.49μs 17.4μs 0.332 0 0 41.78 KB
#5927 WriteAndFlushEnrichedTraces net472 897μs 3.07μs 11.9μs 8.19 2.59 0.431 53.28 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.3μs 2.11ns 8.17ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.71μs 1.78ns 6.66ns 0.0136 0 0 1.02 KB
master ExecuteNonQuery net472 1.96μs 2.16ns 8.07ns 0.157 0 0 987 B
#5927 ExecuteNonQuery net6.0 1.34μs 1.32ns 5.1ns 0.014 0 0 1.02 KB
#5927 ExecuteNonQuery netcoreapp3.1 1.64μs 1.12ns 4.18ns 0.0132 0 0 1.02 KB
#5927 ExecuteNonQuery net472 2.02μs 1.65ns 6.4ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.17μs 2.3ns 8.92ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.61μs 1.77ns 6.86ns 0.0136 0 0 976 B
master CallElasticsearch net472 2.35μs 2.23ns 8.63ns 0.157 0.00118 0 995 B
master CallElasticsearchAsync net6.0 1.29μs 0.852ns 3.19ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 2.31ns 8.95ns 0.0142 0 0 1.02 KB
master CallElasticsearchAsync net472 2.64μs 2.21ns 8.55ns 0.167 0 0 1.05 KB
#5927 CallElasticsearch net6.0 1.17μs 0.516ns 2ns 0.0135 0 0 976 B
#5927 CallElasticsearch netcoreapp3.1 1.53μs 1.05ns 3.78ns 0.0132 0 0 976 B
#5927 CallElasticsearch net472 2.48μs 1.45ns 5.61ns 0.158 0 0 995 B
#5927 CallElasticsearchAsync net6.0 1.27μs 0.455ns 1.7ns 0.0133 0 0 952 B
#5927 CallElasticsearchAsync netcoreapp3.1 1.58μs 0.555ns 2.15ns 0.0134 0 0 1.02 KB
#5927 CallElasticsearchAsync net472 2.6μs 2.86ns 11.1ns 0.167 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 0.938ns 3.63ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.66μs 0.939ns 3.52ns 0.0124 0 0 952 B
master ExecuteAsync net472 1.78μs 1.08ns 4.17ns 0.145 0 0 915 B
#5927 ExecuteAsync net6.0 1.35μs 2.1ns 8.12ns 0.0135 0 0 952 B
#5927 ExecuteAsync netcoreapp3.1 1.59μs 0.929ns 3.48ns 0.0126 0 0 952 B
#5927 ExecuteAsync net472 1.73μs 0.885ns 3.31ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.06μs 1.25ns 4.66ns 0.0304 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.12μs 1.7ns 6.6ns 0.0352 0 0 2.76 KB
master SendAsync net472 7.77μs 2.51ns 9.72ns 0.496 0 0 3.15 KB
#5927 SendAsync net6.0 4.15μs 1.62ns 6.27ns 0.0309 0 0 2.22 KB
#5927 SendAsync netcoreapp3.1 5.17μs 2.07ns 7.74ns 0.0362 0 0 2.76 KB
#5927 SendAsync net472 7.78μs 1.76ns 6.82ns 0.5 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.47μs 0.489ns 1.76ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.16μs 1.33ns 4.96ns 0.0217 0 0 1.64 KB
master EnrichedLog net472 2.73μs 2.01ns 7.8ns 0.249 0 0 1.57 KB
#5927 EnrichedLog net6.0 1.6μs 0.72ns 2.69ns 0.0232 0 0 1.64 KB
#5927 EnrichedLog netcoreapp3.1 2.07μs 1.33ns 4.99ns 0.0219 0 0 1.64 KB
#5927 EnrichedLog net472 2.57μs 2.19ns 8.48ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 149ns 579ns 0.0584 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 147ns 569ns 0 0 0 4.28 KB
master EnrichedLog net472 146μs 173ns 671ns 0.655 0.218 0 4.46 KB
#5927 EnrichedLog net6.0 115μs 165ns 618ns 0.0573 0 0 4.28 KB
#5927 EnrichedLog netcoreapp3.1 121μs 200ns 774ns 0.06 0 0 4.28 KB
#5927 EnrichedLog net472 149μs 264ns 1.02μs 0.673 0.224 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.15μs 0.813ns 3.15ns 0.0298 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.19μs 1.68ns 6.5ns 0.0294 0 0 2.2 KB
master EnrichedLog net472 4.92μs 1.19ns 4.46ns 0.32 0 0 2.02 KB
#5927 EnrichedLog net6.0 2.9μs 0.553ns 2.14ns 0.0305 0 0 2.2 KB
#5927 EnrichedLog netcoreapp3.1 4.06μs 2.44ns 9.46ns 0.0283 0 0 2.2 KB
#5927 EnrichedLog net472 4.93μs 9.29ns 36ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 1.63ns 6.31ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.77μs 1.31ns 5.09ns 0.0151 0 0 1.14 KB
master SendReceive net472 2.2μs 1.73ns 6.7ns 0.183 0.0011 0 1.16 KB
#5927 SendReceive net6.0 1.29μs 0.546ns 2.12ns 0.0158 0 0 1.14 KB
#5927 SendReceive netcoreapp3.1 1.77μs 1.05ns 4.08ns 0.0153 0 0 1.14 KB
#5927 SendReceive net472 2.16μs 1.11ns 4.15ns 0.183 0.00108 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.05μs 4.77ns 18.5ns 0.0226 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.8μs 2.66ns 10.3ns 0.021 0 0 1.65 KB
master EnrichedLog net472 4.3μs 1.13ns 4.23ns 0.323 0 0 2.04 KB
#5927 EnrichedLog net6.0 2.79μs 0.974ns 3.51ns 0.0223 0 0 1.6 KB
#5927 EnrichedLog netcoreapp3.1 3.92μs 0.993ns 3.58ns 0.0216 0 0 1.65 KB
#5927 EnrichedLog net472 4.4μs 2.15ns 8.06ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5927

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.133 547.81 620.91

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 397ns 0.278ns 1.08ns 0.00803 0 0 576 B
master StartFinishSpan netcoreapp3.1 548ns 0.352ns 1.36ns 0.00768 0 0 576 B
master StartFinishSpan net472 636ns 0.837ns 3.24ns 0.0918 0 0 578 B
master StartFinishScope net6.0 474ns 0.437ns 1.64ns 0.0098 0 0 696 B
master StartFinishScope netcoreapp3.1 686ns 0.209ns 0.753ns 0.00929 0 0 696 B
master StartFinishScope net472 823ns 0.83ns 3.21ns 0.104 0 0 658 B
#5927 StartFinishSpan net6.0 400ns 0.697ns 2.7ns 0.00812 0 0 576 B
#5927 StartFinishSpan netcoreapp3.1 621ns 0.417ns 1.56ns 0.00779 0 0 576 B
#5927 StartFinishSpan net472 672ns 1.12ns 4.33ns 0.0916 0 0 578 B
#5927 StartFinishScope net6.0 495ns 0.301ns 1.13ns 0.00988 0 0 696 B
#5927 StartFinishScope netcoreapp3.1 694ns 0.557ns 2.16ns 0.00936 0 0 696 B
#5927 StartFinishScope net472 823ns 0.6ns 2.32ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5927

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.121 583.82 654.44

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 584ns 0.441ns 1.71ns 0.00971 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 828ns 0.565ns 2.11ns 0.00916 0 0 696 B
master RunOnMethodBegin net472 1.13μs 1.22ns 4.72ns 0.104 0 0 658 B
#5927 RunOnMethodBegin net6.0 654ns 0.546ns 2.11ns 0.00959 0 0 696 B
#5927 RunOnMethodBegin netcoreapp3.1 882ns 0.594ns 2.3ns 0.00961 0 0 696 B
#5927 RunOnMethodBegin net472 1.07μs 0.502ns 1.95ns 0.104 0 0 658 B

@andrewlock
andrewlock merged commit 50c1ffe into master Aug 23, 2024
@andrewlock
andrewlock deleted the andrew/ci/remove-obsolete-artifacts branch August 23, 2024 11:07
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kevingosse kevingosse kevingosse approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock @kevingosse