Skip to content

Try fix single step download builds#5923

Merged
andrewlock merged 1 commit into
masterfrom
andrew/ci/fix-gitlab
Aug 23, 2024
Merged

Try fix single step download builds#5923
andrewlock merged 1 commit into
masterfrom
andrew/ci/fix-gitlab

Conversation

@andrewlock

@andrewlock andrewlock commented Aug 21, 2024

Copy link
Copy Markdown
Member

Summary of changes

Looks for PR builds before branch builds

Reason for change

Branch builds are more likely to be "incomplete" as they're manually triggered, typically to improve CI cycle time to only run a sub set of stages. These are less likely to run the required ssi_artifacts stage than PR runs (which will always run the stage if the build is successful)

Implementation details

Changed the order of checks in .gitlab/download-single-step-artifacts.sh

Test coverage

I triggered a manual branch run - if everything worked, the checks in this PR should pass

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Aug 21, 2024
@andrewlock
andrewlock requested a review from a team as a code owner August 21, 2024 14:18
@andrewlock
andrewlock force-pushed the andrew/ci/fix-gitlab branch from 0a46dad to e62a47e Compare August 22, 2024 10:02
@datadog-ddstaging

datadog-ddstaging Bot commented Aug 22, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/ci/fix-gitlab
Commit report: e62a47e
Test service: dd-trace-dotnet

✅ 0 Failed, 306899 Passed, 1631 Skipped, 12h 23m 37.86s Total Time

@andrewlock

andrewlock commented Aug 22, 2024

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@andrewlock

andrewlock commented Aug 22, 2024

Copy link
Copy Markdown
Member Author

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5923) (11.910M)   : 0, 11909986
    master (12.086M)   : 0, 12086085
    benchmarks/2.9.0 (11.883M)   : 0, 11882814

    section Automatic
    This PR (5923) (8.036M)   : 0, 8036361
    master (8.123M)   : 0, 8122530
    benchmarks/2.9.0 (8.446M)   : 0, 8445613

    section Trace stats
    master (8.295M)   : 0, 8294640

    section Manual
    master (11.939M)   : 0, 11939038

    section Manual + Automatic
    This PR (5923) (7.467M)   : 0, 7467191
    master (7.539M)   : 0, 7538976

    section DD_TRACE_ENABLED=0
    master (11.120M)   : 0, 11119872
Loading 
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5923) (9.691M)   : 0, 9690939
    benchmarks/2.9.0 (9.760M)   : 0, 9759697

    section Automatic
    This PR (5923) (6.595M)   : 0, 6594987

    section Manual + Automatic
    This PR (5923) (5.986M)   : 0, 5985613
Loading 
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5923) (10.022M)   : 0, 10022068
    master (10.028M)   : 0, 10028134

    section Automatic
    This PR (5923) (6.877M)   : 0, 6876780
    master (6.614M)   : 0, 6613864

    section Trace stats
    master (7.434M)   : 0, 7433872

    section Manual
    master (10.045M)   : 0, 10044704

    section Manual + Automatic
    This PR (5923) (6.412M)   : 0, 6411743
    master (6.159M)   : 0, 6159019

    section DD_TRACE_ENABLED=0
    master (9.272M)   : 0, 9272090
Loading

@andrewlock

andrewlock commented Aug 22, 2024

Copy link
Copy Markdown
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #5923 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.135
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.79μs 40.5ns 199ns 0.0153 0.00764 0 5.42 KB
master StartStopWithChild netcoreapp3.1 9.78μs 53.2ns 315ns 0.0203 0.0101 0 5.61 KB
master StartStopWithChild net472 16μs 57.7ns 223ns 1.01 0.292 0.0948 6.07 KB
#5923 StartStopWithChild net6.0 8.04μs 45.7ns 326ns 0.0167 0.00836 0 5.42 KB
#5923 StartStopWithChild netcoreapp3.1 10.1μs 55.2ns 317ns 0.0193 0.00963 0 5.62 KB
#5923 StartStopWithChild net472 16.1μs 61.1ns 237ns 1 0.288 0.08 6.08 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 462μs 231ns 866ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 651μs 228ns 882ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 836μs 390ns 1.51μs 0.417 0 0 3.3 KB
#5923 WriteAndFlushEnrichedTraces net6.0 473μs 296ns 1.15μs 0 0 0 2.7 KB
#5923 WriteAndFlushEnrichedTraces netcoreapp3.1 636μs 277ns 1.03μs 0 0 0 2.7 KB
#5923 WriteAndFlushEnrichedTraces net472 846μs 1.95μs 6.77μs 0.417 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 193μs 1.07μs 6.68μs 0.182 0 0 18.45 KB
master SendRequest netcoreapp3.1 213μs 1.18μs 9.12μs 0.22 0 0 20.61 KB
master SendRequest net472 0.00227ns 0.000957ns 0.00371ns 0 0 0 0 b
#5923 SendRequest net6.0 186μs 900ns 4.32μs 0.183 0 0 18.45 KB
#5923 SendRequest netcoreapp3.1 214μs 1.22μs 8.65μs 0.208 0 0 20.61 KB
#5923 SendRequest net472 0.00138ns 0.000737ns 0.00276ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5923

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.91 KB 41.58 KB -328 B -0.78%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 566μs 3μs 15μs 0.548 0 0 41.71 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 676μs 2.01μs 7.52μs 0.334 0 0 41.91 KB
master WriteAndFlushEnrichedTraces net472 860μs 1.87μs 6.73μs 8.45 2.53 0.422 53.28 KB
#5923 WriteAndFlushEnrichedTraces net6.0 583μs 2.78μs 16.4μs 0.581 0 0 41.71 KB
#5923 WriteAndFlushEnrichedTraces netcoreapp3.1 693μs 3.76μs 21.3μs 0.345 0 0 41.58 KB
#5923 WriteAndFlushEnrichedTraces net472 863μs 2.97μs 11.5μs 8.74 2.62 0.437 53.31 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.3μs 2.11ns 8.17ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.71μs 1.78ns 6.66ns 0.0136 0 0 1.02 KB
master ExecuteNonQuery net472 1.96μs 2.16ns 8.07ns 0.157 0 0 987 B
#5923 ExecuteNonQuery net6.0 1.29μs 1.52ns 5.87ns 0.0142 0 0 1.02 KB
#5923 ExecuteNonQuery netcoreapp3.1 1.72μs 1.11ns 4ns 0.0138 0 0 1.02 KB
#5923 ExecuteNonQuery net472 1.96μs 1.05ns 3.79ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.17μs 2.3ns 8.92ns 0.0134 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.61μs 1.77ns 6.86ns 0.0136 0 0 976 B
master CallElasticsearch net472 2.35μs 2.23ns 8.63ns 0.157 0.00118 0 995 B
master CallElasticsearchAsync net6.0 1.29μs 0.852ns 3.19ns 0.0135 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.66μs 2.31ns 8.95ns 0.0142 0 0 1.02 KB
master CallElasticsearchAsync net472 2.64μs 2.21ns 8.55ns 0.167 0 0 1.05 KB
#5923 CallElasticsearch net6.0 1.23μs 1.09ns 4.21ns 0.0135 0 0 976 B
#5923 CallElasticsearch netcoreapp3.1 1.53μs 0.638ns 2.47ns 0.0136 0 0 976 B
#5923 CallElasticsearch net472 2.42μs 2.58ns 9.99ns 0.157 0 0 995 B
#5923 CallElasticsearchAsync net6.0 1.34μs 0.554ns 2.07ns 0.0134 0 0 952 B
#5923 CallElasticsearchAsync netcoreapp3.1 1.55μs 0.709ns 2.65ns 0.0139 0 0 1.02 KB
#5923 CallElasticsearchAsync net472 2.57μs 1.67ns 6.46ns 0.167 0.00128 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.24μs 0.938ns 3.63ns 0.0131 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.66μs 0.939ns 3.52ns 0.0124 0 0 952 B
master ExecuteAsync net472 1.78μs 1.08ns 4.17ns 0.145 0 0 915 B
#5923 ExecuteAsync net6.0 1.25μs 1.03ns 3.85ns 0.0131 0 0 952 B
#5923 ExecuteAsync netcoreapp3.1 1.7μs 1.94ns 7.53ns 0.0128 0 0 952 B
#5923 ExecuteAsync net472 1.82μs 1.85ns 6.92ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.06μs 1.25ns 4.66ns 0.0304 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.12μs 1.7ns 6.6ns 0.0352 0 0 2.76 KB
master SendAsync net472 7.77μs 2.51ns 9.72ns 0.496 0 0 3.15 KB
#5923 SendAsync net6.0 4.06μs 6.09ns 23.6ns 0.0303 0 0 2.22 KB
#5923 SendAsync netcoreapp3.1 5.08μs 1.77ns 6.61ns 0.0357 0 0 2.76 KB
#5923 SendAsync net472 7.91μs 2.07ns 8.01ns 0.497 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.47μs 0.489ns 1.76ns 0.0228 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.16μs 1.33ns 4.96ns 0.0217 0 0 1.64 KB
master EnrichedLog net472 2.73μs 2.01ns 7.8ns 0.249 0 0 1.57 KB
#5923 EnrichedLog net6.0 1.57μs 0.827ns 3.09ns 0.0228 0 0 1.64 KB
#5923 EnrichedLog netcoreapp3.1 2.32μs 1.18ns 4.59ns 0.022 0 0 1.64 KB
#5923 EnrichedLog net472 2.61μs 1.92ns 7.44ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 149ns 579ns 0.0584 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 119μs 147ns 569ns 0 0 0 4.28 KB
master EnrichedLog net472 146μs 173ns 671ns 0.655 0.218 0 4.46 KB
#5923 EnrichedLog net6.0 114μs 178ns 690ns 0.0568 0 0 4.28 KB
#5923 EnrichedLog netcoreapp3.1 119μs 211ns 790ns 0.0598 0 0 4.28 KB
#5923 EnrichedLog net472 146μs 156ns 606ns 0.654 0.218 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.15μs 0.813ns 3.15ns 0.0298 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.19μs 1.68ns 6.5ns 0.0294 0 0 2.2 KB
master EnrichedLog net472 4.92μs 1.19ns 4.46ns 0.32 0 0 2.02 KB
#5923 EnrichedLog net6.0 3.04μs 0.877ns 3.28ns 0.0305 0 0 2.2 KB
#5923 EnrichedLog netcoreapp3.1 4.19μs 1.37ns 5.32ns 0.0292 0 0 2.2 KB
#5923 EnrichedLog net472 4.9μs 0.692ns 2.68ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 1.63ns 6.31ns 0.0158 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.77μs 1.31ns 5.09ns 0.0151 0 0 1.14 KB
master SendReceive net472 2.2μs 1.73ns 6.7ns 0.183 0.0011 0 1.16 KB
#5923 SendReceive net6.0 1.32μs 0.931ns 3.36ns 0.0159 0 0 1.14 KB
#5923 SendReceive netcoreapp3.1 1.71μs 1.31ns 5.07ns 0.0154 0 0 1.14 KB
#5923 SendReceive net472 2.19μs 3.07ns 11.9ns 0.183 0.00109 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.05μs 4.77ns 18.5ns 0.0226 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.8μs 2.66ns 10.3ns 0.021 0 0 1.65 KB
master EnrichedLog net472 4.3μs 1.13ns 4.23ns 0.323 0 0 2.04 KB
#5923 EnrichedLog net6.0 2.88μs 1.04ns 3.89ns 0.0216 0 0 1.6 KB
#5923 EnrichedLog netcoreapp3.1 4.06μs 1.97ns 7.62ns 0.0223 0 0 1.65 KB
#5923 EnrichedLog net472 4.35μs 1.99ns 7.71ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 397ns 0.278ns 1.08ns 0.00803 0 0 576 B
master StartFinishSpan netcoreapp3.1 548ns 0.352ns 1.36ns 0.00768 0 0 576 B
master StartFinishSpan net472 636ns 0.837ns 3.24ns 0.0918 0 0 578 B
master StartFinishScope net6.0 474ns 0.437ns 1.64ns 0.0098 0 0 696 B
master StartFinishScope netcoreapp3.1 686ns 0.209ns 0.753ns 0.00929 0 0 696 B
master StartFinishScope net472 823ns 0.83ns 3.21ns 0.104 0 0 658 B
#5923 StartFinishSpan net6.0 395ns 0.147ns 0.55ns 0.00814 0 0 576 B
#5923 StartFinishSpan netcoreapp3.1 597ns 0.231ns 0.895ns 0.00751 0 0 576 B
#5923 StartFinishSpan net472 648ns 2.52ns 9.42ns 0.0917 0 0 578 B
#5923 StartFinishScope net6.0 491ns 0.915ns 3.42ns 0.00973 0 0 696 B
#5923 StartFinishScope netcoreapp3.1 759ns 2.13ns 8.23ns 0.00965 0 0 696 B
#5923 StartFinishScope net472 904ns 0.616ns 2.3ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5923

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑netcoreapp3.1 1.153 828.45 955.40
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.117 583.82 652.12

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 584ns 0.441ns 1.71ns 0.00971 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 828ns 0.565ns 2.11ns 0.00916 0 0 696 B
master RunOnMethodBegin net472 1.13μs 1.22ns 4.72ns 0.104 0 0 658 B
#5923 RunOnMethodBegin net6.0 653ns 0.534ns 2.07ns 0.00987 0 0 696 B
#5923 RunOnMethodBegin netcoreapp3.1 955ns 0.62ns 2.4ns 0.0092 0 0 696 B
#5923 RunOnMethodBegin net472 1.1μs 0.73ns 2.83ns 0.104 0 0 658 B

@andrewlock
andrewlock merged commit f652e5b into master Aug 23, 2024
@andrewlock
andrewlock deleted the andrew/ci/fix-gitlab branch August 23, 2024 11:08
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@kevingosse kevingosse kevingosse approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock @kevingosse