Skip to content

Stop testing .NET Core 2.1 on PRs#5922

Merged
andrewlock merged 2 commits into
masterfrom
andrew/ci/stop-testing-netcoreapp2
Aug 21, 2024
Merged

Stop testing .NET Core 2.1 on PRs#5922
andrewlock merged 2 commits into
masterfrom
andrew/ci/stop-testing-netcoreapp2

Conversation

@andrewlock

@andrewlock andrewlock commented Aug 21, 2024

Copy link
Copy Markdown
Member

Summary of changes

  • .NET Core 2.1 is EOL so stop testing it on PRs
  • Refactor the ARM64 tests to use the same strategy-generation as other integration tests

Reason for change

.NET Core 2.1 is EOL, so stop testing it by default. We may also remove it from the full/master runs too, but we can't quite agree the best option for that. Everyone agrees on this step though.

Also switch the arm64 integration tests to use the same generation strategy as all the other integration tests because it was inconsistent, and will make some other things I'm working on easier.

Implementation details

  • Include IsArm64 as a decision point in the TestFrameworks property
  • Tweak the existing arm64 integration tests yaml to be the in line with the x64 integration tests

Test coverage

This is the test, but we have less coverage in PRs now

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Aug 21, 2024
@andrewlock
andrewlock requested a review from a team as a code owner August 21, 2024 08:40
dromanol
dromanol approved these changes Aug 21, 2024
View reviewed changes

@dromanol dromanol left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot

@datadog-ddstaging

datadog-ddstaging Bot commented Aug 21, 2024 •
edited
Loading

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/ci/stop-testing-netcoreapp2
Commit report: 9d877c9
Test service: dd-trace-dotnet

✅ 0 Failed, 301908 Passed, 1609 Skipped, 12h 40m 34.21s Total Time

@andrewlock

andrewlock commented Aug 21, 2024 •
edited
Loading

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@andrewlock
andrewlock force-pushed the andrew/ci/stop-testing-netcoreapp2 branch from 3b3fef7 to 2379315 Compare August 21, 2024 10:05
@andrewlock
andrewlock force-pushed the andrew/ci/stop-testing-netcoreapp2 branch from 2379315 to 9d877c9 Compare August 21, 2024 10:11
@andrewlock
andrewlock merged commit 7a9d1bd into master Aug 21, 2024
@andrewlock
andrewlock deleted the andrew/ci/stop-testing-netcoreapp2 branch August 21, 2024 15:01
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dromanol dromanol dromanol approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock @dromanol