Fix signature size check in ModifyLocalSig#5921
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 356383 Passed, 2267 Skipped, 23h 16m 37.93s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). |
## Summary of changes Fix signature size check in `ModifyLocalSig`. ## Reason for change Detected by static analysis. ## Implementation details Because `originalSignatureSize` and `len` are unsigned, their subtraction is unsigned and thus can't be negative.
andrewlock
added
the
area:native-library
## Summary of changes Fix signature size check in `ModifyLocalSig`. ## Reason for change Detected by static analysis. ## Implementation details Because `originalSignatureSize` and `len` are unsigned, their subtraction is unsigned and thus can't be negative. ## Other details Backport of #5921 Co-authored-by: Kevin Gosse <[email protected]>
4 participants
Summary of changes
Fix signature size check in
ModifyLocalSig.Reason for change
Detected by static analysis.
Implementation details
Because
originalSignatureSizeandlenare unsigned, their subtraction is unsigned and thus can't be negative.