Enable ad-hoc memory dumps on Windows x86#5919
Conversation
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). |
Datadog ReportBranch report: ✅ 0 Failed, 348657 Passed, 1767 Skipped, 14h 42m 36.84s Total Time |
2 participants
Summary of changes
Enable ad-hoc memory dumps on Windows x86.
As part of #5046, I disabled procdump on Windows x86 because it caused issue when monitoring a process. However, by doing so I also disabled "on-demand" memory dumps which should work perfectly fine.
Reason for change
Needed to investigate mysterious timeouts in dd-dotnet tests.
Implementation details
Added a
_isCrashMonitoringAvailableflag to distinguish the two use-cases.