Skip to content

Remove prerelease flag from smoke tests#5912

Merged
andrewlock merged 1 commit into
masterfrom
andrew/ci/removev-prerelease
Aug 19, 2024
Merged

Remove prerelease flag from smoke tests#5912
andrewlock merged 1 commit into
masterfrom
andrew/ci/removev-prerelease

Conversation

@andrewlock

Copy link
Copy Markdown
Member

Summary of changes

Fix the nuget smoke tests on .NET Core 3.1

Reason for change

We had to add the prerelease flag to support testing prerelease version of the nuget, but it breaks on 3.1 which doesn't support it. Tried to find a neater way around this but got bored, and just want it to work 😅

Implementation details

Remove the flag

Test coverage

This is the test

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Aug 16, 2024
@andrewlock
andrewlock requested a review from a team as a code owner August 16, 2024 07:48
@andrewlock

Copy link
Copy Markdown
Member Author

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

@datadog-ddstaging

datadog-ddstaging Bot commented Aug 16, 2024

Copy link
Copy Markdown

Datadog Report

Branch report: andrew/ci/removev-prerelease
Commit report: a3cc5d6
Test service: dd-trace-dotnet

✅ 0 Failed, 343044 Passed, 1803 Skipped, 14h 59m 49.41s Total Time
❄️ 1 New Flaky

New Flaky Tests (1)

  • RunTest - Datadog.Trace.Security.IntegrationTests.Rcm.AspNetCore5AsmDataSecurityEnabledBlockingRequestIpOneClick - Last Failure

    Expand for error
     Results do not match.
     Differences:
     Received: Security.AspNetCore5AsmDataSecurityEnabled.__test=blocking-ips-oneclick_url=_.received.txt
     Verified: Security.AspNetCore5AsmDataSecurityEnabled.__test=blocking-ips-oneclick_url=_.verified.txt
     Received Content:
     [
       {
         TraceId: Id_1,
         SpanId: Id_2,
         Name: aspnet_core.request,
     ...
    

@andrewlock

Copy link
Copy Markdown
Member Author

Benchmarks Report for tracer 🐌

Benchmarks for #5912 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.139
  • 2 benchmarks are slower, with geometric mean 1.149
  • 1 benchmarks have fewer allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.87μs 42.6ns 319ns 0.0162 0.00808 0 5.42 KB
master StartStopWithChild netcoreapp3.1 9.85μs 54.6ns 349ns 0.0145 0.00966 0 5.62 KB
master StartStopWithChild net472 16μs 39.9ns 154ns 1.03 0.318 0.0955 6.07 KB
#5912 StartStopWithChild net6.0 7.89μs 43.2ns 255ns 0.0163 0.00815 0 5.43 KB
#5912 StartStopWithChild netcoreapp3.1 9.84μs 54.7ns 341ns 0.0292 0.0146 0 5.62 KB
#5912 StartStopWithChild net472 16μs 33.7ns 126ns 1.01 0.295 0.0877 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 472μs 288ns 1.12μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 632μs 224ns 838ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 855μs 505ns 1.89μs 0.428 0 0 3.3 KB
#5912 WriteAndFlushEnrichedTraces net6.0 471μs 201ns 778ns 0 0 0 2.7 KB
#5912 WriteAndFlushEnrichedTraces netcoreapp3.1 638μs 178ns 689ns 0 0 0 2.7 KB
#5912 WriteAndFlushEnrichedTraces net472 839μs 445ns 1.6μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 192μs 1.02μs 6.79μs 0.184 0 0 18.45 KB
master SendRequest netcoreapp3.1 209μs 1.18μs 7.91μs 0.207 0 0 20.61 KB
master SendRequest net472 0.000596ns 0.000353ns 0.00132ns 0 0 0 0 b
#5912 SendRequest net6.0 189μs 1.09μs 8.82μs 0.19 0 0 18.45 KB
#5912 SendRequest netcoreapp3.1 212μs 1.17μs 7.69μs 0.211 0 0 20.61 KB
#5912 SendRequest net472 0.000119ns 8.15E‑05ns 0.000315ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Fewer allocations 🎉

Fewer allocations 🎉 in #5912

Benchmark Base Allocated Diff Allocated Change Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1 41.98 KB 41.65 KB -326 B -0.78%

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 566μs 1.87μs 7.25μs 0.561 0 0 41.73 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 664μs 2.09μs 7.82μs 0.326 0 0 41.98 KB
master WriteAndFlushEnrichedTraces net472 855μs 4.18μs 17.7μs 8.63 2.47 0.411 53.28 KB
#5912 WriteAndFlushEnrichedTraces net6.0 556μs 2.04μs 7.64μs 0.553 0 0 41.69 KB
#5912 WriteAndFlushEnrichedTraces netcoreapp3.1 672μs 2.89μs 12.3μs 0.326 0 0 41.65 KB
#5912 WriteAndFlushEnrichedTraces net472 895μs 2.78μs 10.8μs 8.09 2.25 0.45 53.28 KB
Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5912

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net6.0 1.128 1,166.63 1,316.02

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.17μs 0.924ns 3.58ns 0.0143 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.66μs 0.756ns 2.73ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.05μs 1.8ns 6.96ns 0.157 0 0 987 B
#5912 ExecuteNonQuery net6.0 1.32μs 1.3ns 5.04ns 0.0142 0 0 1.02 KB
#5912 ExecuteNonQuery netcoreapp3.1 1.71μs 2.75ns 10.3ns 0.0136 0 0 1.02 KB
#5912 ExecuteNonQuery net472 2.04μs 2.12ns 8.23ns 0.156 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.18μs 0.457ns 1.77ns 0.0136 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.47μs 0.46ns 1.72ns 0.0133 0 0 976 B
master CallElasticsearch net472 2.51μs 1.61ns 6.23ns 0.158 0 0 995 B
master CallElasticsearchAsync net6.0 1.21μs 0.956ns 3.7ns 0.0133 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.59μs 0.972ns 3.64ns 0.0136 0 0 1.02 KB
master CallElasticsearchAsync net472 2.65μs 1.82ns 7.06ns 0.166 0 0 1.05 KB
#5912 CallElasticsearch net6.0 1.14μs 0.39ns 1.46ns 0.0133 0 0 976 B
#5912 CallElasticsearch netcoreapp3.1 1.61μs 0.544ns 1.88ns 0.013 0 0 976 B
#5912 CallElasticsearch net472 2.43μs 1.09ns 4.24ns 0.158 0 0 995 B
#5912 CallElasticsearchAsync net6.0 1.29μs 1.36ns 5.07ns 0.0135 0 0 952 B
#5912 CallElasticsearchAsync netcoreapp3.1 1.61μs 1.1ns 4.11ns 0.0137 0 0 1.02 KB
#5912 CallElasticsearchAsync net472 2.57μs 1.66ns 6.42ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5912

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net6.0 1.170 1,168.21 1,366.29

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.17μs 0.935ns 3.5ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.68μs 0.805ns 3.12ns 0.0125 0 0 952 B
master ExecuteAsync net472 1.81μs 1.03ns 3.85ns 0.145 0 0 915 B
#5912 ExecuteAsync net6.0 1.37μs 0.799ns 3.1ns 0.013 0 0 952 B
#5912 ExecuteAsync netcoreapp3.1 1.64μs 0.608ns 2.19ns 0.013 0 0 952 B
#5912 ExecuteAsync net472 1.76μs 2.01ns 7.25ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.08μs 1.74ns 6.5ns 0.0305 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.04μs 2.85ns 11.1ns 0.038 0 0 2.76 KB
master SendAsync net472 7.78μs 1.67ns 6.24ns 0.497 0 0 3.15 KB
#5912 SendAsync net6.0 4.17μs 1.45ns 5.02ns 0.0313 0 0 2.22 KB
#5912 SendAsync netcoreapp3.1 5.09μs 1.67ns 6.26ns 0.0361 0 0 2.76 KB
#5912 SendAsync net472 7.74μs 1.65ns 6.18ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.5μs 0.663ns 2.48ns 0.0234 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.12μs 0.486ns 1.75ns 0.0221 0 0 1.64 KB
master EnrichedLog net472 2.71μs 4.48ns 17.4ns 0.249 0 0 1.57 KB
#5912 EnrichedLog net6.0 1.51μs 0.595ns 2.3ns 0.0228 0 0 1.64 KB
#5912 EnrichedLog netcoreapp3.1 2.21μs 1.56ns 6.05ns 0.022 0 0 1.64 KB
#5912 EnrichedLog net472 2.64μs 2.23ns 8.33ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 114μs 163ns 630ns 0.0575 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 146ns 566ns 0 0 0 4.28 KB
master EnrichedLog net472 149μs 159ns 615ns 0.673 0.224 0 4.46 KB
#5912 EnrichedLog net6.0 116μs 151ns 585ns 0 0 0 4.28 KB
#5912 EnrichedLog netcoreapp3.1 120μs 197ns 764ns 0 0 0 4.28 KB
#5912 EnrichedLog net472 148μs 211ns 817ns 0.666 0.222 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.19μs 0.898ns 3.48ns 0.0303 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.34μs 1.63ns 6.3ns 0.0298 0 0 2.2 KB
master EnrichedLog net472 4.83μs 1.27ns 4.75ns 0.319 0 0 2.02 KB
#5912 EnrichedLog net6.0 3.12μs 1.95ns 7.56ns 0.0311 0 0 2.2 KB
#5912 EnrichedLog netcoreapp3.1 4.18μs 1.02ns 3.81ns 0.0291 0 0 2.2 KB
#5912 EnrichedLog net472 4.91μs 1.66ns 6.23ns 0.321 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.33μs 0.654ns 2.53ns 0.016 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.78μs 1.33ns 5.13ns 0.0152 0 0 1.14 KB
master SendReceive net472 2.24μs 2.28ns 8.82ns 0.183 0.00112 0 1.16 KB
#5912 SendReceive net6.0 1.29μs 1.1ns 4.24ns 0.016 0 0 1.14 KB
#5912 SendReceive netcoreapp3.1 1.8μs 3.88ns 15ns 0.0159 0 0 1.14 KB
#5912 SendReceive net472 2.15μs 1.23ns 4.75ns 0.183 0.00107 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.79μs 0.556ns 2.08ns 0.0222 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.88μs 1.29ns 5ns 0.0214 0 0 1.65 KB
master EnrichedLog net472 4.43μs 1.19ns 4.46ns 0.323 0 0 2.04 KB
#5912 EnrichedLog net6.0 2.83μs 0.854ns 3.31ns 0.0215 0 0 1.6 KB
#5912 EnrichedLog netcoreapp3.1 3.79μs 1.57ns 5.66ns 0.0228 0 0 1.65 KB
#5912 EnrichedLog net472 4.38μs 1.93ns 7.21ns 0.322 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #5912

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net6.0 1.139 547.60 480.92

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 401ns 0.224ns 0.868ns 0.00809 0 0 576 B
master StartFinishSpan netcoreapp3.1 567ns 0.387ns 1.5ns 0.0079 0 0 576 B
master StartFinishSpan net472 598ns 0.647ns 2.5ns 0.0916 0 0 578 B
master StartFinishScope net6.0 547ns 0.227ns 0.878ns 0.00964 0 0 696 B
master StartFinishScope netcoreapp3.1 747ns 0.654ns 2.53ns 0.0093 0 0 696 B
master StartFinishScope net472 889ns 0.598ns 2.32ns 0.104 0 0 658 B
#5912 StartFinishSpan net6.0 394ns 0.33ns 1.24ns 0.00813 0 0 576 B
#5912 StartFinishSpan netcoreapp3.1 620ns 0.355ns 1.37ns 0.00774 0 0 576 B
#5912 StartFinishSpan net472 650ns 0.853ns 3.3ns 0.0916 0 0 578 B
#5912 StartFinishScope net6.0 480ns 0.361ns 1.4ns 0.00984 0 0 696 B
#5912 StartFinishScope netcoreapp3.1 687ns 2.31ns 8.93ns 0.00951 0 0 696 B
#5912 StartFinishScope net472 866ns 1.03ns 3.99ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 652ns 0.672ns 2.6ns 0.00986 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 929ns 0.986ns 3.82ns 0.00924 0 0 696 B
master RunOnMethodBegin net472 1.06μs 0.959ns 3.71ns 0.104 0 0 658 B
#5912 RunOnMethodBegin net6.0 645ns 0.598ns 2.31ns 0.00972 0 0 696 B
#5912 RunOnMethodBegin netcoreapp3.1 989ns 0.91ns 3.53ns 0.00887 0 0 696 B
#5912 RunOnMethodBegin net472 1.05μs 0.89ns 3.45ns 0.104 0 0 658 B

@bouwkast bouwkast left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@andrewlock
andrewlock merged commit 1f7415a into master Aug 19, 2024
@andrewlock
andrewlock deleted the andrew/ci/removev-prerelease branch August 19, 2024 05:18
@github-actions github-actions Bot added this to the vNext-v3 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants