Pin StyleCop.Analzyers to latest pre-release#5908
Conversation
The floating version appears to be destroying dependabot.
This reverts commit 45a66ab. This didn't work
StyleCop.Analzyers to latest pre-release
|
This attempt #5906 failed, so reverting it and trying to pin the version And if this doesn't work I'll just spin up a dummy repo to test out the |
Datadog ReportBranch report: ✅ 0 Failed, 347878 Passed, 2061 Skipped, 15h 55m 33.02s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). |
|
I made a test app and repo with this version and then another outdated NuGet and dependabot failed with the same error. Pinning the version of |
Benchmarks Report for tracer 🐌Benchmarks for #5908 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5908) (11.344M) : 0, 11344109
master (11.626M) : 0, 11625669
benchmarks/2.9.0 (11.606M) : 0, 11605731
section Automatic
This PR (5908) (7.696M) : 0, 7695691
master (7.741M) : 0, 7740587
benchmarks/2.9.0 (8.043M) : 0, 8042658
section Trace stats
master (8.083M) : 0, 8082727
section Manual
master (11.551M) : 0, 11551010
section Manual + Automatic
This PR (5908) (7.033M) : 0, 7032744
master (7.207M) : 0, 7206578
section DD_TRACE_ENABLED=0
master (10.731M) : 0, 10731443
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5908) (6.513M) : 0, 6513438
section Automatic
This PR (5908) (6.589M) : 0, 6589203
section Manual + Automatic
This PR (5908) (6.121M) : 0, 6121133
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5908) (10.174M) : 0, 10174221
benchmarks/2.9.0 (10.148M) : 0, 10147897
section Automatic
This PR (5908) (6.851M) : 0, 6850852
benchmarks/2.9.0 (7.517M) : 0, 7517128
section Manual + Automatic
This PR (5908) (6.437M) : 0, 6436570
|
Summary of changes
:sorry:
Pins
StyleCop.Analyzersto the latest prerelease instead of a floating version.Reverts ignoring
StyleCop.Analyzersin Dependabot because that did nothing.Reason for change
Dependabot still struggling with
error : '[1.2.0-beta.*]' is not a valid version stringImplementation details
Updated both locations of
StyleCop.Analzyerto the latest pre-releaseDependabot will attempt to update this package again
Test coverage
Other details
If this doesn't fix it I'll find a better way to update/test this without having to PR and merge to run dependabot.