Fix gitlab build#5907
Merged
Merged
Conversation
andrewlock
added
the
area:builds
lucaspimentel
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
I broke the build on master. It's happened one too many times, so changed this to always do the build (i.e. in builds too). Seeing as that's what we're doing for one pipeline now anyway, doesn't make much sense to not do it for the main build too IMO.
Implementation details
onlyYes, we could probably do something tidier, no I couldn't be bothered right now 😅
Test coverage
This is the test - if it builds, we should be good 🤞
Other details
Docker on Windows in GitLab is so slow 😅