Ignore StyleCop.Analyzers in dependabot#5906
Merged
Merged
Conversation
This is an attempt to fix dependabot silently failing.
github-actions
Bot
added
the
area:builds
andrewlock
approved these changes
Aug 15, 2024
andrewlock
left a comment
andrewlock
left a comment
Member
There was a problem hiding this comment.
Tbh, I thought StyleCop.Analyzers was deprecated in favour of other analyzers anyway 🤔 We should look into that at some point 😄
lucaspimentel
approved these changes
Aug 15, 2024
Collaborator
Author
I think it provides additional analyzers compared to the official ones, if it still poses an issue I can take a peek at what the current status is and whether it can be removed in place of the other ones. |
bouwkast
added a commit
that referenced
this pull request
Aug 15, 2024
This reverts commit 45a66ab. This didn't work
andrewlock
added
dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Adds
StyleCope.Analyzersto the ignored dependencies within Dependabot.Reason for change
I've been looking into why it seemed that Dependabot wasn't creating PRs and found several issues in the logs:
This was repeated throughout all of the Dependabot logs and doesn't appear to cause the run to loudly fail, but appears to cause it to silently fail. This version comes from here: https://github.com/DataDog/dd-trace-dotnet/blob/master/tracer/Directory.Build.props#L20
I attempted to replicate this issue and have had no luck. But I think it is fine to just try to ignore this package as it is a floating version anyway and will automatically update (and only applies to the editor).
Implementation details
Added the package to the ignore list.
Test coverage
Other details
I don't think there is a way to manually run this file until it is merged.
There is another issue that may or may not be related with
InlineIL.Fodyand theSourceGeneratorsproject, but want to fix this one first as it is in all of them.