Fix bug in verification stage of release#5894
Merged
Merged
Conversation
andrewlock
added
the
area:builds
kevingosse
approved these changes
Aug 14, 2024
andrewlock
added a commit
that referenced
this pull request
Aug 15, 2024
## Summary of changes Fix bug in pre-release validation stage ## Reason for change There was a bug where we were using the wrong image during the musl validation ## Implementation details It was looking for `dd-lib-dotnet` instead of `dd-lib-dotnet-init` ## Test coverage We'll see if it works next time ## Other details Needs backporting to v2 (only runs there, but makes sense to fix on master too)
andrewlock
added a commit
that referenced
this pull request
Aug 16, 2024
## Summary of changes Fix bug in pre-release validation stage ## Reason for change There was a bug where we were using the wrong image during the musl validation ## Implementation details It was looking for `dd-lib-dotnet` instead of `dd-lib-dotnet-init` ## Test coverage We'll see if it works next time ## Other details Backport of #5894
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix bug in pre-release validation stage
Reason for change
There was a bug where we were using the wrong image during the musl validation
Implementation details
It was looking for
dd-lib-dotnetinstead ofdd-lib-dotnet-initTest coverage
We'll see if it works next time
Other details
Needs backporting to v2 (only runs there, but makes sense to fix on master too)