Skip to content

[ASM] Delete unused snapshots#5758

Merged
NachoEchevarria merged 2 commits into
masterfrom
nacho/RemovenotNeededASMSnapshots
Sep 23, 2024
Merged

[ASM] Delete unused snapshots#5758
NachoEchevarria merged 2 commits into
masterfrom
nacho/RemovenotNeededASMSnapshots

Conversation

@NachoEchevarria

@NachoEchevarria NachoEchevarria commented Jul 1, 2024

Copy link
Copy Markdown
Collaborator

Summary of changes

Some ASM snapshots don't seem to be used, so they have been removed.

Reason for change

We should not store useless snapshots.

Implementation details

Test coverage

Other details

@github-actions github-actions Bot added the area:tests unit tests, integration tests label Jul 1, 2024
@datadog-ddstaging

datadog-ddstaging Bot commented Jul 1, 2024

Copy link
Copy Markdown

Datadog Report

Branch report: nacho/RemovenotNeededASMSnapshots
Commit report: 25820c9
Test service: dd-trace-dotnet

✅ 0 Failed, 363904 Passed, 2067 Skipped, 15h 26m 41.01s Total Time

@andrewlock

andrewlock commented Jul 2, 2024

Copy link
Copy Markdown
Member

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5758) - mean (69ms)  : 67, 71
     .   : milestone, 69,
    master - mean (69ms)  : 67, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (5758) - mean (1,098ms)  : 1076, 1120
     .   : milestone, 1098,
    master - mean (1,100ms)  : 1075, 1126
     .   : milestone, 1100,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5758) - mean (108ms)  : 105, 111
     .   : milestone, 108,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (5758) - mean (766ms)  : 753, 779
     .   : milestone, 766,
    master - mean (764ms)  : 750, 779
     .   : milestone, 764,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5758) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (91ms)  : 89, 94
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (5758) - mean (726ms)  : 708, 745
     .   : milestone, 726,
    master - mean (726ms)  : 709, 743
     .   : milestone, 726,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5758) - mean (191ms)  : 186, 195
     .   : milestone, 191,
    master - mean (190ms)  : 186, 193
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (5758) - mean (1,193ms)  : 1172, 1215
     .   : milestone, 1193,
    master - mean (1,192ms)  : 1166, 1219
     .   : milestone, 1192,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5758) - mean (276ms)  : 272, 280
     .   : milestone, 276,
    master - mean (276ms)  : 272, 280
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (5758) - mean (938ms)  : 924, 953
     .   : milestone, 938,
    master - mean (939ms)  : 922, 956
     .   : milestone, 939,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (5758) - mean (264ms)  : 260, 268
     .   : milestone, 264,
    master - mean (264ms)  : 261, 268
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (5758) - mean (924ms)  : 904, 944
     .   : milestone, 924,
    master - mean (924ms)  : 906, 942
     .   : milestone, 924,

Loading

@andrewlock

andrewlock commented Jul 2, 2024

Copy link
Copy Markdown
Member

Throughput/Crank Report ⚡

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5758) (11.353M)   : 0, 11352690
    master (11.210M)   : 0, 11210475
    benchmarks/2.9.0 (11.081M)   : 0, 11080577

    section Automatic
    This PR (5758) (7.356M)   : 0, 7355962
    master (7.346M)   : 0, 7346370
    benchmarks/2.9.0 (7.732M)   : 0, 7732233

    section Trace stats
    master (7.666M)   : 0, 7665960

    section Manual
    master (11.108M)   : 0, 11108127

    section Manual + Automatic
    This PR (5758) (6.846M)   : 0, 6845650
    master (6.832M)   : 0, 6832442

    section DD_TRACE_ENABLED=0
    master (10.312M)   : 0, 10312118

Loading
gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5758) (9.404M)   : 0, 9404277
    master (9.473M)   : 0, 9473014
    benchmarks/2.9.0 (9.798M)   : 0, 9798067

    section Automatic
    This PR (5758) (6.472M)   : 0, 6471680
    master (6.515M)   : 0, 6514854

    section Trace stats
    master (6.894M)   : 0, 6893597

    section Manual
    master (9.402M)   : 0, 9401973

    section Manual + Automatic
    This PR (5758) (6.136M)   : 0, 6135620
    master (6.108M)   : 0, 6107697

    section DD_TRACE_ENABLED=0
    master (8.907M)   : 0, 8907338

Loading
gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (5758) (10.116M)   : 0, 10115685
    master (10.142M)   : 0, 10142276
    benchmarks/2.9.0 (10.067M)   : 0, 10067315

    section Automatic
    This PR (5758) (6.559M)   : 0, 6558700
    master (6.501M)   : 0, 6501024
    benchmarks/2.9.0 (7.552M)   : 0, 7552193

    section Trace stats
    master (7.332M)   : 0, 7331680

    section Manual
    master (10.035M)   : 0, 10035225

    section Manual + Automatic
    This PR (5758) (6.210M)   : 0, 6209731
    master (6.012M)   : 0, 6011729

    section DD_TRACE_ENABLED=0
    master (9.404M)   : 0, 9404396

Loading

@andrewlock

andrewlock commented Jul 2, 2024

Copy link
Copy Markdown
Member

Benchmarks Report for tracer 🐌

Benchmarks for #5758 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.150
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.74μs 44.4ns 326ns 0.0154 0.00768 0 5.43 KB
master StartStopWithChild netcoreapp3.1 9.82μs 55.3ns 375ns 0.0146 0.00488 0 5.62 KB
master StartStopWithChild net472 16.2μs 43ns 167ns 1.02 0.298 0.0967 6.06 KB
#5758 StartStopWithChild net6.0 7.78μs 44.5ns 321ns 0.0117 0.0039 0 5.43 KB
#5758 StartStopWithChild netcoreapp3.1 9.95μs 56.4ns 382ns 0.0147 0.00489 0 5.62 KB
#5758 StartStopWithChild net472 16.1μs 51.7ns 200ns 1.02 0.304 0.104 6.07 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 456μs 369ns 1.33μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 639μs 370ns 1.38μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 834μs 1.05μs 3.92μs 0.419 0 0 3.3 KB
#5758 WriteAndFlushEnrichedTraces net6.0 461μs 268ns 1.04μs 0 0 0 2.7 KB
#5758 WriteAndFlushEnrichedTraces netcoreapp3.1 637μs 225ns 840ns 0 0 0 2.7 KB
#5758 WriteAndFlushEnrichedTraces net472 829μs 512ns 1.98μs 0.411 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 208μs 1.2μs 9.26μs 0.244 0 0 18.45 KB
master SendRequest netcoreapp3.1 226μs 958ns 3.83μs 0.227 0 0 20.61 KB
master SendRequest net472 0.00362ns 0.00123ns 0.00475ns 0 0 0 0 b
#5758 SendRequest net6.0 210μs 1.19μs 8.36μs 0.199 0 0 18.45 KB
#5758 SendRequest netcoreapp3.1 225μs 1.22μs 7.33μs 0.222 0 0 20.61 KB
#5758 SendRequest net472 0.000818ns 0.000432ns 0.00162ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 563μs 2.36μs 10.6μs 0.551 0 0 41.63 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 679μs 3.53μs 18μs 0.342 0 0 41.64 KB
master WriteAndFlushEnrichedTraces net472 868μs 1.42μs 5.14μs 8.3 2.62 0.437 53.33 KB
#5758 WriteAndFlushEnrichedTraces net6.0 581μs 2.99μs 14.9μs 0.587 0 0 41.7 KB
#5758 WriteAndFlushEnrichedTraces netcoreapp3.1 704μs 3.5μs 14.4μs 0.329 0 0 41.71 KB
#5758 WriteAndFlushEnrichedTraces net472 867μs 3.7μs 14.3μs 8.08 2.55 0.425 53.33 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.31μs 0.905ns 3.5ns 0.014 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.81μs 0.969ns 3.75ns 0.0135 0 0 1.02 KB
master ExecuteNonQuery net472 2.12μs 3.76ns 14.6ns 0.157 0 0 987 B
#5758 ExecuteNonQuery net6.0 1.25μs 0.871ns 3.37ns 0.0144 0 0 1.02 KB
#5758 ExecuteNonQuery netcoreapp3.1 1.74μs 1.22ns 4.4ns 0.0133 0 0 1.02 KB
#5758 ExecuteNonQuery net472 2.03μs 1.49ns 5.76ns 0.157 0 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.12μs 0.635ns 2.38ns 0.0137 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.54μs 0.728ns 2.52ns 0.0131 0 0 976 B
master CallElasticsearch net472 2.45μs 1.4ns 5.41ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.28μs 0.385ns 1.49ns 0.0134 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.58μs 0.376ns 1.41ns 0.0139 0 0 1.02 KB
master CallElasticsearchAsync net472 2.55μs 1.14ns 4.1ns 0.167 0 0 1.05 KB
#5758 CallElasticsearch net6.0 1.15μs 0.528ns 2.05ns 0.0134 0 0 976 B
#5758 CallElasticsearch netcoreapp3.1 1.51μs 0.897ns 3.36ns 0.0129 0 0 976 B
#5758 CallElasticsearch net472 2.5μs 1.13ns 4.07ns 0.157 0 0 995 B
#5758 CallElasticsearchAsync net6.0 1.36μs 1.08ns 4.18ns 0.013 0 0 952 B
#5758 CallElasticsearchAsync netcoreapp3.1 1.62μs 0.41ns 1.54ns 0.0137 0 0 1.02 KB
#5758 CallElasticsearchAsync net472 2.56μs 1.75ns 6.77ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.22μs 0.922ns 3.57ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.61μs 1.01ns 3.93ns 0.0129 0 0 952 B
master ExecuteAsync net472 1.71μs 0.706ns 2.73ns 0.145 0 0 915 B
#5758 ExecuteAsync net6.0 1.33μs 0.758ns 2.93ns 0.0133 0 0 952 B
#5758 ExecuteAsync netcoreapp3.1 1.66μs 1.07ns 4ns 0.0124 0 0 952 B
#5758 ExecuteAsync net472 1.83μs 1.4ns 5.42ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.23μs 5.36ns 20.1ns 0.0296 0 0 2.22 KB
master SendAsync netcoreapp3.1 5.07μs 2.74ns 10.6ns 0.0354 0 0 2.76 KB
master SendAsync net472 7.72μs 5.9ns 22.8ns 0.498 0 0 3.15 KB
#5758 SendAsync net6.0 4.1μs 1.74ns 6.74ns 0.0308 0 0 2.22 KB
#5758 SendAsync netcoreapp3.1 5.07μs 1.25ns 4.67ns 0.0382 0 0 2.76 KB
#5758 SendAsync net472 7.75μs 3.28ns 12.7ns 0.499 0 0 3.15 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.52μs 0.518ns 1.87ns 0.0226 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.22μs 1.11ns 3.98ns 0.0221 0 0 1.64 KB
master EnrichedLog net472 2.65μs 0.736ns 2.85ns 0.249 0 0 1.57 KB
#5758 EnrichedLog net6.0 1.56μs 0.779ns 2.91ns 0.0227 0 0 1.64 KB
#5758 EnrichedLog netcoreapp3.1 2.14μs 2.72ns 10.2ns 0.0224 0 0 1.64 KB
#5758 EnrichedLog net472 2.5μs 0.894ns 3.34ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 112μs 78.4ns 304ns 0.0569 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 118μs 186ns 694ns 0.0593 0 0 4.28 KB
master EnrichedLog net472 144μs 46.6ns 168ns 0.652 0.217 0 4.46 KB
#5758 EnrichedLog net6.0 114μs 152ns 568ns 0.0572 0 0 4.28 KB
#5758 EnrichedLog netcoreapp3.1 118μs 145ns 561ns 0.0589 0 0 4.28 KB
#5758 EnrichedLog net472 146μs 148ns 574ns 0.654 0.218 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.05μs 2.13ns 8.23ns 0.0305 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.22μs 4.09ns 15.8ns 0.0296 0 0 2.2 KB
master EnrichedLog net472 4.82μs 7.04ns 27.3ns 0.321 0 0 2.02 KB
#5758 EnrichedLog net6.0 3.12μs 2.49ns 9.64ns 0.0314 0 0 2.2 KB
#5758 EnrichedLog netcoreapp3.1 4.29μs 1.27ns 4.92ns 0.0302 0 0 2.2 KB
#5758 EnrichedLog net472 4.73μs 1.13ns 4.24ns 0.319 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.37μs 0.975ns 3.65ns 0.0164 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.79μs 0.724ns 2.8ns 0.0152 0 0 1.14 KB
master SendReceive net472 2μs 1.13ns 4.21ns 0.183 0.00101 0 1.16 KB
#5758 SendReceive net6.0 1.38μs 1.48ns 5.74ns 0.016 0 0 1.14 KB
#5758 SendReceive netcoreapp3.1 1.67μs 0.744ns 2.88ns 0.015 0 0 1.14 KB
#5758 SendReceive net472 2.02μs 1.18ns 4.56ns 0.183 0.00101 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.68μs 0.748ns 2.9ns 0.0226 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.87μs 2.08ns 8.07ns 0.0211 0 0 1.65 KB
master EnrichedLog net472 4.38μs 2.37ns 9.17ns 0.323 0 0 2.04 KB
#5758 EnrichedLog net6.0 2.7μs 0.894ns 3.46ns 0.0228 0 0 1.6 KB
#5758 EnrichedLog netcoreapp3.1 3.98μs 1.51ns 5.84ns 0.022 0 0 1.65 KB
#5758 EnrichedLog net472 4.47μs 1.98ns 7.68ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #5758

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 1.155 811.45 936.83
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.145 538.26 616.07

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 412ns 0.259ns 0.97ns 0.00808 0 0 576 B
master StartFinishSpan netcoreapp3.1 538ns 0.551ns 2.13ns 0.00789 0 0 576 B
master StartFinishSpan net472 680ns 0.874ns 3.27ns 0.0917 0 0 578 B
master StartFinishScope net6.0 503ns 0.327ns 1.27ns 0.00988 0 0 696 B
master StartFinishScope netcoreapp3.1 720ns 0.86ns 3.33ns 0.00945 0 0 696 B
master StartFinishScope net472 811ns 0.655ns 2.54ns 0.105 0 0 658 B
#5758 StartFinishSpan net6.0 395ns 0.269ns 1.04ns 0.00799 0 0 576 B
#5758 StartFinishSpan netcoreapp3.1 616ns 0.545ns 2.11ns 0.00801 0 0 576 B
#5758 StartFinishSpan net472 681ns 0.978ns 3.79ns 0.0918 0 0 578 B
#5758 StartFinishScope net6.0 494ns 0.29ns 1.12ns 0.00966 0 0 696 B
#5758 StartFinishScope netcoreapp3.1 680ns 0.439ns 1.7ns 0.00945 0 0 696 B
#5758 StartFinishScope net472 938ns 0.838ns 3.25ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 620ns 0.433ns 1.68ns 0.00963 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 949ns 0.908ns 3.51ns 0.00947 0 0 696 B
master RunOnMethodBegin net472 1.13μs 1.11ns 4.29ns 0.104 0 0 658 B
#5758 RunOnMethodBegin net6.0 637ns 0.411ns 1.59ns 0.00957 0 0 696 B
#5758 RunOnMethodBegin netcoreapp3.1 889ns 0.817ns 3.16ns 0.00963 0 0 696 B
#5758 RunOnMethodBegin net472 1.1μs 0.962ns 3.73ns 0.105 0 0 658 B

@NachoEchevarria
NachoEchevarria force-pushed the nacho/RemovenotNeededASMSnapshots branch from 9111dde to 76c6125 Compare August 5, 2024 10:54
@NachoEchevarria NachoEchevarria changed the title Remove not needed [ASM] Delete unused snapshots Sep 23, 2024
@NachoEchevarria
NachoEchevarria marked this pull request as ready for review September 23, 2024 12:26
@NachoEchevarria
NachoEchevarria requested a review from a team as a code owner September 23, 2024 12:26

@robertpi robertpi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

@NachoEchevarria

Copy link
Copy Markdown
Collaborator Author

Thanks for the reviews!

@NachoEchevarria
NachoEchevarria merged commit 214d552 into master Sep 23, 2024
@NachoEchevarria
NachoEchevarria deleted the nacho/RemovenotNeededASMSnapshots branch September 23, 2024 14:11
@github-actions github-actions Bot added this to the vNext-v3 milestone Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:asm area:tests unit tests, integration tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants