[ASM] Delete unused snapshots#5758
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 363904 Passed, 2067 Skipped, 15h 26m 41.01s Total Time |
Execution-Time Benchmarks Report ⏱️Execution-time results for samples comparing the following branches/commits: Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:
Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard. Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph). gantt
title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5758) - mean (69ms) : 67, 71
. : milestone, 69,
master - mean (69ms) : 67, 72
. : milestone, 69,
section CallTarget+Inlining+NGEN
This PR (5758) - mean (1,098ms) : 1076, 1120
. : milestone, 1098,
master - mean (1,100ms) : 1075, 1126
. : milestone, 1100,
gantt
title Execution time (ms) FakeDbCommand (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5758) - mean (108ms) : 105, 111
. : milestone, 108,
master - mean (108ms) : 106, 110
. : milestone, 108,
section CallTarget+Inlining+NGEN
This PR (5758) - mean (766ms) : 753, 779
. : milestone, 766,
master - mean (764ms) : 750, 779
. : milestone, 764,
gantt
title Execution time (ms) FakeDbCommand (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5758) - mean (92ms) : 90, 94
. : milestone, 92,
master - mean (91ms) : 89, 94
. : milestone, 91,
section CallTarget+Inlining+NGEN
This PR (5758) - mean (726ms) : 708, 745
. : milestone, 726,
master - mean (726ms) : 709, 743
. : milestone, 726,
gantt
title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5758) - mean (191ms) : 186, 195
. : milestone, 191,
master - mean (190ms) : 186, 193
. : milestone, 190,
section CallTarget+Inlining+NGEN
This PR (5758) - mean (1,193ms) : 1172, 1215
. : milestone, 1193,
master - mean (1,192ms) : 1166, 1219
. : milestone, 1192,
gantt
title Execution time (ms) HttpMessageHandler (.NET Core 3.1)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5758) - mean (276ms) : 272, 280
. : milestone, 276,
master - mean (276ms) : 272, 280
. : milestone, 276,
section CallTarget+Inlining+NGEN
This PR (5758) - mean (938ms) : 924, 953
. : milestone, 938,
master - mean (939ms) : 922, 956
. : milestone, 939,
gantt
title Execution time (ms) HttpMessageHandler (.NET 6)
dateFormat X
axisFormat %s
todayMarker off
section Baseline
This PR (5758) - mean (264ms) : 260, 268
. : milestone, 264,
master - mean (264ms) : 261, 268
. : milestone, 264,
section CallTarget+Inlining+NGEN
This PR (5758) - mean (924ms) : 904, 944
. : milestone, 924,
master - mean (924ms) : 906, 942
. : milestone, 924,
|
Throughput/Crank Report ⚡Throughput results for AspNetCoreSimpleController comparing the following branches/commits: Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red. Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards! gantt
title Throughput Linux x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5758) (11.353M) : 0, 11352690
master (11.210M) : 0, 11210475
benchmarks/2.9.0 (11.081M) : 0, 11080577
section Automatic
This PR (5758) (7.356M) : 0, 7355962
master (7.346M) : 0, 7346370
benchmarks/2.9.0 (7.732M) : 0, 7732233
section Trace stats
master (7.666M) : 0, 7665960
section Manual
master (11.108M) : 0, 11108127
section Manual + Automatic
This PR (5758) (6.846M) : 0, 6845650
master (6.832M) : 0, 6832442
section DD_TRACE_ENABLED=0
master (10.312M) : 0, 10312118
gantt
title Throughput Linux arm64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5758) (9.404M) : 0, 9404277
master (9.473M) : 0, 9473014
benchmarks/2.9.0 (9.798M) : 0, 9798067
section Automatic
This PR (5758) (6.472M) : 0, 6471680
master (6.515M) : 0, 6514854
section Trace stats
master (6.894M) : 0, 6893597
section Manual
master (9.402M) : 0, 9401973
section Manual + Automatic
This PR (5758) (6.136M) : 0, 6135620
master (6.108M) : 0, 6107697
section DD_TRACE_ENABLED=0
master (8.907M) : 0, 8907338
gantt
title Throughput Windows x64 (Total requests)
dateFormat X
axisFormat %s
section Baseline
This PR (5758) (10.116M) : 0, 10115685
master (10.142M) : 0, 10142276
benchmarks/2.9.0 (10.067M) : 0, 10067315
section Automatic
This PR (5758) (6.559M) : 0, 6558700
master (6.501M) : 0, 6501024
benchmarks/2.9.0 (7.552M) : 0, 7552193
section Trace stats
master (7.332M) : 0, 7331680
section Manual
master (10.035M) : 0, 10035225
section Manual + Automatic
This PR (5758) (6.210M) : 0, 6209731
master (6.012M) : 0, 6011729
section DD_TRACE_ENABLED=0
master (9.404M) : 0, 9404396
|
Benchmarks Report for tracer 🐌Benchmarks for #5758 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Slower
|
| Benchmark | diff/base | Base Median (ns) | Diff Median (ns) | Modality |
|---|---|---|---|---|
| Benchmarks.Trace.SpanBenchmark.StartFinishScope‑net472 | 1.155 | 811.45 | 936.83 | |
| Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 | 1.145 | 538.26 | 616.07 |
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | StartFinishSpan |
net6.0 | 412ns | 0.259ns | 0.97ns | 0.00808 | 0 | 0 | 576 B |
| master | StartFinishSpan |
netcoreapp3.1 | 538ns | 0.551ns | 2.13ns | 0.00789 | 0 | 0 | 576 B |
| master | StartFinishSpan |
net472 | 680ns | 0.874ns | 3.27ns | 0.0917 | 0 | 0 | 578 B |
| master | StartFinishScope |
net6.0 | 503ns | 0.327ns | 1.27ns | 0.00988 | 0 | 0 | 696 B |
| master | StartFinishScope |
netcoreapp3.1 | 720ns | 0.86ns | 3.33ns | 0.00945 | 0 | 0 | 696 B |
| master | StartFinishScope |
net472 | 811ns | 0.655ns | 2.54ns | 0.105 | 0 | 0 | 658 B |
| #5758 | StartFinishSpan |
net6.0 | 395ns | 0.269ns | 1.04ns | 0.00799 | 0 | 0 | 576 B |
| #5758 | StartFinishSpan |
netcoreapp3.1 | 616ns | 0.545ns | 2.11ns | 0.00801 | 0 | 0 | 576 B |
| #5758 | StartFinishSpan |
net472 | 681ns | 0.978ns | 3.79ns | 0.0918 | 0 | 0 | 578 B |
| #5758 | StartFinishScope |
net6.0 | 494ns | 0.29ns | 1.12ns | 0.00966 | 0 | 0 | 696 B |
| #5758 | StartFinishScope |
netcoreapp3.1 | 680ns | 0.439ns | 1.7ns | 0.00945 | 0 | 0 | 696 B |
| #5758 | StartFinishScope |
net472 | 938ns | 0.838ns | 3.25ns | 0.104 | 0 | 0 | 658 B |
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️
Raw results
| Branch | Method | Toolchain | Mean | StdError | StdDev | Gen 0 | Gen 1 | Gen 2 | Allocated |
|---|---|---|---|---|---|---|---|---|---|
| master | RunOnMethodBegin |
net6.0 | 620ns | 0.433ns | 1.68ns | 0.00963 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
netcoreapp3.1 | 949ns | 0.908ns | 3.51ns | 0.00947 | 0 | 0 | 696 B |
| master | RunOnMethodBegin |
net472 | 1.13μs | 1.11ns | 4.29ns | 0.104 | 0 | 0 | 658 B |
| #5758 | RunOnMethodBegin |
net6.0 | 637ns | 0.411ns | 1.59ns | 0.00957 | 0 | 0 | 696 B |
| #5758 | RunOnMethodBegin |
netcoreapp3.1 | 889ns | 0.817ns | 3.16ns | 0.00963 | 0 | 0 | 696 B |
| #5758 | RunOnMethodBegin |
net472 | 1.1μs | 0.962ns | 3.73ns | 0.105 | 0 | 0 | 658 B |
9111dde to
76c6125
Compare
|
Thanks for the reviews! |
Summary of changes
Some ASM snapshots don't seem to be used, so they have been removed.
Reason for change
We should not store useless snapshots.
Implementation details
Test coverage
Other details