Minor fixes for hotfix workflows#5702
Merged
Merged
Conversation
andrewlock
added
the
area:builds
zacharycmontoya
approved these changes
Jun 17, 2024
lucaspimentel
approved these changes
Jun 17, 2024
andrewlock
added a commit
that referenced
this pull request
Jun 19, 2024
* Don't output version in same run as changing the version * Don't run create version bump PR for hotfix releases
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Fixes a couple of bugs:
Implementation details
The latter bug was because we weren't recompiling the nuke project between updating the version an emitting it. Fixed by splitting them to separate invocations.
Test coverage
Meh