[v3] add `language` tag all spans by lucaspimentel · Pull Request #4839 · DataDog/dd-trace-dotnet

lucaspimentel · 2023-11-08T21:12:41Z

Summary of changes

Add language:dotnet tag all spans.

Reason for change

Spans without a language tag end up with language:.NET later in the pipeline. We want all spans to have a single value for this tag.

Implementation details

Remove the check for span.kind is not (client or producer) when adding the language tag to spans.

Test coverage

update any unit or integration tests
update test snapshots

Other details

datadog-ddstaging · 2023-11-08T21:37:20Z

Datadog Report

Branch report: lpimentel/add-language-tag-to-all-spans
Commit report: cc7bb04

✅ dd-trace-dotnet: 0 Failed, 0 New Flaky, 183 Passed, 0 Skipped, 5m 30.31s Wall Time

andrewlock · 2023-11-08T21:45:30Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4839) - mean (71ms)  : 62, 81
     .   : milestone, 71,
    master - mean (72ms)  : 61, 83
     .   : milestone, 72,

    section CallTarget+Inlining+NGEN
    This PR (4839) - mean (956ms)  : 932, 979
     .   : milestone, 956,
    master - mean (944ms)  : 918, 971
     .   : milestone, 944,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4839) - mean (106ms)  : 102, 110
     .   : milestone, 106,
    master - mean (105ms)  : 100, 110
     .   : milestone, 105,

    section CallTarget+Inlining+NGEN
    This PR (4839) - mean (699ms)  : 678, 721
     .   : milestone, 699,
    master - mean (692ms)  : 670, 714
     .   : milestone, 692,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4839) - mean (90ms)  : 86, 95
     .   : milestone, 90,
    master - mean (89ms)  : 84, 93
     .   : milestone, 89,

    section CallTarget+Inlining+NGEN
    This PR (4839) - mean (656ms)  : 636, 676
     .   : milestone, 656,
    master - mean (645ms)  : 624, 665
     .   : milestone, 645,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4839) - mean (189ms)  : 186, 192
     .   : milestone, 189,
    master - mean (189ms)  : 186, 192
     .   : milestone, 189,

    section CallTarget+Inlining+NGEN
    This PR (4839) - mean (1,066ms)  : 1043, 1089
     .   : milestone, 1066,
    master - mean (1,068ms)  : 1042, 1094
     .   : milestone, 1068,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4839) - mean (273ms)  : 269, 278
     .   : milestone, 273,
    master - mean (272ms)  : 269, 276
     .   : milestone, 272,

    section CallTarget+Inlining+NGEN
    This PR (4839) - mean (1,053ms)  : 1027, 1079
     .   : milestone, 1053,
    master - mean (1,057ms)  : 1033, 1080
     .   : milestone, 1057,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (4839) - mean (262ms)  : 259, 266
     .   : milestone, 262,
    master - mean (262ms)  : 258, 266
     .   : milestone, 262,

    section CallTarget+Inlining+NGEN
    This PR (4839) - mean (1,015ms)  : 1000, 1031
     .   : milestone, 1015,
    master - mean (1,023ms)  : 1002, 1044
     .   : milestone, 1023,

github-actions · 2023-11-08T22:15:07Z

Snapshots difference summary

The following differences have been observed in committed snapshots. It is meant to help the reviewer.
The diff is simplistic, so please check some files anyway while we improve it.

2 occurrences of :

+        "language": "dotnet",

5689 occurrences of :

+      language: dotnet,

6 occurrences of :

+      error.msg: Cannot assign requested address,
+      error.stack: Cannot assign requested address (SocketException),
+      error.type: System.Net.WebException,

andrewlock · 2023-11-08T23:40:35Z

Benchmarks Report 🐌

Benchmarks for #4839 compared to master:

1 benchmarks are faster, with geometric mean 1.117
2 benchmarks are slower, with geometric mean 1.137
2 benchmarks have fewer allocations
2 benchmarks have more allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.68μs	47.8ns	283ns	0.0216	0.00866	0	7.48 KB
master	`StartStopWithChild`	netcoreapp3.1	10.6μs	45.4ns	192ns	0.037	0.0158	0	7.58 KB
master	`StartStopWithChild`	net472	17.2μs	53ns	205ns	1.33	0.349	0.111	7.95 KB
#4839	`StartStopWithChild`	net6.0	8.69μs	48.6ns	304ns	0.0177	0.00886	0	7.48 KB
#4839	`StartStopWithChild`	netcoreapp3.1	10.7μs	54.4ns	261ns	0.0313	0.0157	0	7.58 KB
#4839	`StartStopWithChild`	net472	17.3μs	34.7ns	134ns	1.34	0.365	0.122	7.95 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	478μs	255ns	955ns	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	634μs	326ns	1.26μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	804μs	158ns	548ns	0.401	3.3 KB
#4839	`WriteAndFlushEnrichedTraces`	net6.0	434μs	197ns	764ns	0	2.7 KB
#4839	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	612μs	200ns	749ns	0	2.7 KB
#4839	`WriteAndFlushEnrichedTraces`	net472	798μs	406ns	1.52μs	0.398	3.3 KB

Benchmarks.Trace.Asm.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net6.0	39.4μs	45.3ns	169ns	0.0198	0	1.77 KB
master	`AllCycleSimpleBody`	netcoreapp3.1	41.2μs	30.9ns	116ns	0.0208	0	1.74 KB
master	`AllCycleSimpleBody`	net472	44.8μs	19.9ns	71.7ns	0.27	0	1.81 KB
master	`AllCycleMoreComplexBody`	net6.0	201μs	71.6ns	277ns	0.1	0	9.25 KB
master	`AllCycleMoreComplexBody`	netcoreapp3.1	217μs	214ns	829ns	0.106	0	9.14 KB
master	`AllCycleMoreComplexBody`	net472	226μs	117ns	454ns	1.47	0	9.32 KB
master	`ObjectExtractorSimpleBody`	net6.0	142ns	0.143ns	0.556ns	0.00396	0	280 B
master	`ObjectExtractorSimpleBody`	netcoreapp3.1	203ns	0.223ns	0.864ns	0.00369	0	272 B
master	`ObjectExtractorSimpleBody`	net472	173ns	0.133ns	0.48ns	0.0446	0	281 B
master	`ObjectExtractorMoreComplexBody`	net6.0	3.05μs	4.09ns	15.3ns	0.0533	0	3.78 KB
master	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	3.95μs	1.55ns	5.81ns	0.0495	0	3.69 KB
master	`ObjectExtractorMoreComplexBody`	net472	3.98μs	5.01ns	18.7ns	0.602	0.00593	3.8 KB
#4839	`AllCycleSimpleBody`	net6.0	38.7μs	21.7ns	83.9ns	0.0195	0	1.77 KB
#4839	`AllCycleSimpleBody`	netcoreapp3.1	42μs	43.8ns	158ns	0.0209	0	1.74 KB
#4839	`AllCycleSimpleBody`	net472	45.6μs	20.6ns	77.2ns	0.273	0	1.81 KB
#4839	`AllCycleMoreComplexBody`	net6.0	199μs	119ns	444ns	0.1	0	9.25 KB
#4839	`AllCycleMoreComplexBody`	netcoreapp3.1	212μs	246ns	954ns	0.106	0	9.14 KB
#4839	`AllCycleMoreComplexBody`	net472	227μs	50.3ns	195ns	1.48	0	9.32 KB
#4839	`ObjectExtractorSimpleBody`	net6.0	137ns	0.0897ns	0.311ns	0.00393	0	280 B
#4839	`ObjectExtractorSimpleBody`	netcoreapp3.1	199ns	0.167ns	0.647ns	0.00371	0	272 B
#4839	`ObjectExtractorSimpleBody`	net472	167ns	0.102ns	0.382ns	0.0446	0	281 B
#4839	`ObjectExtractorMoreComplexBody`	net6.0	3.08μs	1.47ns	5.5ns	0.0525	0	3.78 KB
#4839	`ObjectExtractorMoreComplexBody`	netcoreapp3.1	4μs	2.01ns	7.53ns	0.0502	0	3.69 KB
#4839	`ObjectExtractorMoreComplexBody`	net472	3.75μs	1.51ns	5.86ns	0.601	0.0056	3.8 KB

Benchmarks.Trace.Asm.AppSecWafBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`RunWaf(args=NestedMap (10))`	net6.0	54.2μs	25.7ns	96.1ns	0.222	0	16.06 KB
master	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	64.7μs	53.9ns	194ns	0.194	0	16.06 KB
master	`RunWaf(args=NestedMap (10))`	net472	100μs	487ns	2.07μs	2.54	0.0959	16.14 KB
master	`RunWafTwice(args=NestedMap (10))`	net6.0	57.7μs	306ns	1.62μs	0.234	0	16.6 KB
master	`RunWafTwice(args=NestedMap (10))`	netcoreapp3.1	71.1μs	265ns	957ns	0.212	0	16.58 KB
master	`RunWafTwice(args=NestedMap (10))`	net472	107μs	494ns	1.91μs	2.63	0.107	16.69 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	112μs	77.6ns	301ns	0.295	0	22.41 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	133μs	679ns	3.18μs	0.256	0	22.36 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	164μs	761ns	2.95μs	3.55	0.161	22.7 KB
master	`RunWaf(args=NestedMap (100))`	net6.0	105μs	220ns	851ns	0.417	0	32.76 KB
master	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	133μs	315ns	1.22μs	0.402	0	33.33 KB
master	`RunWaf(args=NestedMap (100))`	net472	195μs	150ns	562ns	5.27	0.37	33.67 KB
master	`RunWafTwice(args=NestedMap (100))`	net6.0	107μs	339ns	1.27μs	0.428	0	33.3 KB
master	`RunWafTwice(args=NestedMap (100))`	netcoreapp3.1	141μs	127ns	493ns	0.413	0	33.86 KB
master	`RunWafTwice(args=NestedMap (100))`	net472	201μs	607ns	2.35μs	5.44	0.396	34.22 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	162μs	56.1ns	210ns	0.517	0	39.1 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	204μs	385ns	1.49μs	0.488	0	39.63 KB
master	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	253μs	140ns	485ns	6.38	0.51	40.23 KB
master	`RunWaf(args=NestedMap (20))`	net6.0	109μs	14ns	52.2ns	0.453	0	32.18 KB
master	`RunWaf(args=NestedMap (20))`	netcoreapp3.1	134μs	437ns	1.69μs	0.438	0	32.3 KB
master	`RunWaf(args=NestedMap (20))`	net472	188μs	904ns	3.62μs	5.1	0.371	32.63 KB
master	`RunWafTwice(args=NestedMap (20))`	net6.0	103μs	34ns	123ns	0.464	0	32.72 KB
master	`RunWafTwice(args=NestedMap (20))`	netcoreapp3.1	138μs	725ns	3.7μs	0.399	0	32.82 KB
master	`RunWafTwice(args=NestedMap (20))`	net472	198μs	857ns	3.32μs	5.22	0.386	33.19 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	161μs	149ns	515ns	0.543	0	38.53 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	198μs	80.2ns	289ns	0.512	0	38.6 KB
master	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	256μs	1.1μs	4.27μs	6.21	0.507	39.2 KB
#4839	`RunWaf(args=NestedMap (10))`	net6.0	54.4μs	21.3ns	82.6ns	0.21	0	16.06 KB
#4839	`RunWaf(args=NestedMap (10))`	netcoreapp3.1	67.5μs	244ns	913ns	0.199	0	16.06 KB
#4839	`RunWaf(args=NestedMap (10))`	net472	95.7μs	49.2ns	177ns	2.52	0.095	16.14 KB
#4839	`RunWafTwice(args=NestedMap (10))`	net6.0	53μs	222ns	1.15μs	0.231	0	16.6 KB
#4839	`RunWafTwice(args=NestedMap (10))`	netcoreapp3.1	73.5μs	263ns	1.02μs	0.211	0	16.58 KB
#4839	`RunWafTwice(args=NestedMap (10))`	net472	102μs	33.3ns	129ns	2.62	0.103	16.69 KB
#4839	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	109μs	33.6ns	121ns	0.288	0	22.41 KB
#4839	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	126μs	160ns	555ns	0.264	0	22.36 KB
#4839	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	163μs	799ns	3.29μs	3.61	0.16	22.7 KB
#4839	`RunWaf(args=NestedMap (100))`	net6.0	96.7μs	29.5ns	106ns	0.437	0	32.76 KB
#4839	`RunWaf(args=NestedMap (100))`	netcoreapp3.1	128μs	84.4ns	292ns	0.411	0	33.33 KB
#4839	`RunWaf(args=NestedMap (100))`	net472	186μs	150ns	561ns	5.29	0.371	33.67 KB
#4839	`RunWafTwice(args=NestedMap (100))`	net6.0	98.8μs	58.2ns	225ns	0.445	0	33.3 KB
#4839	`RunWafTwice(args=NestedMap (100))`	netcoreapp3.1	139μs	687ns	2.92μs	0.401	0	33.86 KB
#4839	`RunWafTwice(args=NestedMap (100))`	net472	202μs	612ns	2.37μs	5.36	0.39	34.22 KB
#4839	`RunWafWithAttack(args=Neste(...)tack) [23])`	net6.0	166μs	295ns	1.14μs	0.505	0	39.1 KB
#4839	`RunWafWithAttack(args=Neste(...)tack) [23])`	netcoreapp3.1	203μs	114ns	442ns	0.509	0	39.63 KB
#4839	`RunWafWithAttack(args=Neste(...)tack) [23])`	net472	254μs	285ns	1.1μs	6.38	0.51	40.23 KB
#4839	`RunWaf(args=NestedMap (20))`	net6.0	99.3μs	37.2ns	144ns	0.45	0	32.18 KB
#4839	`RunWaf(args=NestedMap (20))`	netcoreapp3.1	138μs	92.8ns	322ns	0.417	0	32.3 KB
#4839	`RunWaf(args=NestedMap (20))`	net472	183μs	100ns	388ns	5.14	0.367	32.63 KB
#4839	`RunWafTwice(args=NestedMap (20))`	net6.0	101μs	37.6ns	146ns	0.448	0	32.72 KB
#4839	`RunWafTwice(args=NestedMap (20))`	netcoreapp3.1	133μs	678ns	3.11μs	0.39	0	32.82 KB
#4839	`RunWafTwice(args=NestedMap (20))`	net472	191μs	79.4ns	308ns	5.2	0.385	33.19 KB
#4839	`RunWafWithAttack(args=Neste(...)tack) [22])`	net6.0	169μs	313ns	1.13μs	0.511	0	38.53 KB
#4839	`RunWafWithAttack(args=Neste(...)tack) [22])`	netcoreapp3.1	195μs	1.03μs	4.93μs	0.48	0	38.6 KB
#4839	`RunWafWithAttack(args=Neste(...)tack) [22])`	net472	261μs	1.17μs	4.23μs	6.21	0.507	39.2 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	173μs	145ns	563ns	0.171	18.25 KB
master	`SendRequest`	netcoreapp3.1	195μs	222ns	831ns	0.192	20.41 KB
master	`SendRequest`	net472	0.000948ns	0.000384ns	0.00149ns	0	0 b
#4839	`SendRequest`	net6.0	173μs	148ns	574ns	0.173	18.25 KB
#4839	`SendRequest`	netcoreapp3.1	191μs	423ns	1.64μs	0.19	20.41 KB
#4839	`SendRequest`	net472	0.000229ns	0.00014ns	0.000542ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #4839

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark.WriteAndFlushEnrichedTraces‑netcoreapp3.1	41.65 KB	41.91 KB	263 B	0.63%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	554μs	196ns	759ns	0.556	0	0	41.72 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	659μs	1.82μs	7.03μs	0.329	0	0	41.65 KB
master	`WriteAndFlushEnrichedTraces`	net472	840μs	3.5μs	12.6μs	8.45	2.53	0.422	53.23 KB
#4839	`WriteAndFlushEnrichedTraces`	net6.0	541μs	1.47μs	5.7μs	0.543	0	0	41.7 KB
#4839	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	650μs	511ns	1.98μs	0.331	0	0	41.91 KB
#4839	`WriteAndFlushEnrichedTraces`	net472	826μs	3.86μs	15μs	8.17	2.45	0.408	53.23 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteNonQuery`	net6.0	1.1μs	0.84ns	3.25ns	0.0104	768 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.51μs	1.01ns	3.89ns	0.0106	768 B
master	`ExecuteNonQuery`	net472	1.83μs	1.36ns	5.08ns	0.116	730 B
#4839	`ExecuteNonQuery`	net6.0	1.12μs	0.57ns	2.21ns	0.0107	768 B
#4839	`ExecuteNonQuery`	netcoreapp3.1	1.47μs	1.76ns	6.81ns	0.0103	768 B
#4839	`ExecuteNonQuery`	net472	1.68μs	0.699ns	2.71ns	0.116	730 B

Benchmarks.Trace.ElasticsearchBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #4839

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearchAsync‑net6.0	1.117	1,410.98	1,262.79

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.23μs	1.41ns	5.28ns	0.0128	936 B
master	`CallElasticsearch`	netcoreapp3.1	1.51μs	0.703ns	2.63ns	0.0129	936 B
master	`CallElasticsearch`	net472	2.48μs	0.801ns	3.1ns	0.151	955 B
master	`CallElasticsearchAsync`	net6.0	1.41μs	1.47ns	5.68ns	0.0128	912 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.79μs	5.2ns	18.8ns	0.013	984 B
master	`CallElasticsearchAsync`	net472	2.78μs	2.4ns	8.99ns	0.16	1.01 KB
#4839	`CallElasticsearch`	net6.0	1.11μs	0.273ns	0.983ns	0.0133	936 B
#4839	`CallElasticsearch`	netcoreapp3.1	1.54μs	0.686ns	2.57ns	0.0123	936 B
#4839	`CallElasticsearch`	net472	2.4μs	0.847ns	3.17ns	0.151	955 B
#4839	`CallElasticsearchAsync`	net6.0	1.26μs	2.15ns	8.32ns	0.0129	912 B
#4839	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	4.3ns	16.7ns	0.0134	984 B
#4839	`CallElasticsearchAsync`	net472	2.74μs	0.935ns	3.5ns	0.161	1.01 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.25μs	3.06ns	13.3ns	0.0127	912 B
master	`ExecuteAsync`	netcoreapp3.1	1.66μs	2.35ns	8.78ns	0.0124	912 B
master	`ExecuteAsync`	net472	1.71μs	1.12ns	4.33ns	0.139	875 B
#4839	`ExecuteAsync`	net6.0	1.26μs	0.815ns	3.05ns	0.0127	912 B
#4839	`ExecuteAsync`	netcoreapp3.1	1.63μs	2.59ns	10ns	0.0125	912 B
#4839	`ExecuteAsync`	net472	1.8μs	0.907ns	3.4ns	0.139	875 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4μs	1.76ns	6.83ns	0.0301	2.1 KB
master	`SendAsync`	netcoreapp3.1	4.95μs	1.59ns	5.94ns	0.0346	2.63 KB
master	`SendAsync`	net472	7.65μs	3.09ns	12ns	0.524	3.31 KB
#4839	`SendAsync`	net6.0	4.13μs	2.02ns	7.56ns	0.0288	2.1 KB
#4839	`SendAsync`	netcoreapp3.1	5.03μs	1.63ns	6.31ns	0.0352	2.63 KB
#4839	`SendAsync`	net472	7.76μs	3.53ns	13.7ns	0.524	3.31 KB

Benchmarks.Trace.Iast.StringAspectsBenchmark - Same speed ✔️ More allocations ⚠️

More allocations ⚠️ in #4839

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑netcoreapp3.1	200.89 KB	212.47 KB	11.58 KB	5.77%

Fewer allocations 🎉 in #4839

Benchmark	Base Allocated	Diff Allocated	Change	Change %
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatBenchmark‑net472	61.25 KB	59.1 KB	-2.14 KB	-3.50%
Benchmarks.Trace.Iast.StringAspectsBenchmark.StringConcatAspectBenchmark‑net6.0	214.22 KB	204.15 KB	-10.07 KB	-4.70%

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`StringConcatBenchmark`	net6.0	60.4μs	1.01μs	10μs	43.44 KB
master	`StringConcatBenchmark`	netcoreapp3.1	53.2μs	215ns	745ns	42.64 KB
master	`StringConcatBenchmark`	net472	37.6μs	128ns	461ns	61.25 KB
master	`StringConcatAspectBenchmark`	net6.0	290μs	1.99μs	19.1μs	214.22 KB
master	`StringConcatAspectBenchmark`	netcoreapp3.1	284μs	2.62μs	24μs	200.89 KB
master	`StringConcatAspectBenchmark`	net472	244μs	4.02μs	38.6μs	221.18 KB
#4839	`StringConcatBenchmark`	net6.0	52μs	235ns	911ns	43.44 KB
#4839	`StringConcatBenchmark`	netcoreapp3.1	56μs	317ns	2.31μs	42.64 KB
#4839	`StringConcatBenchmark`	net472	37.8μs	132ns	493ns	59.1 KB
#4839	`StringConcatAspectBenchmark`	net6.0	285μs	6.06μs	59.1μs	204.15 KB
#4839	`StringConcatAspectBenchmark`	netcoreapp3.1	360μs	10.2μs	102μs	212.47 KB
#4839	`StringConcatAspectBenchmark`	net472	265μs	5.69μs	55.2μs	221.18 KB

Benchmarks.Trace.ILoggerBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4839

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑net6.0	1.122	1,417.34	1,589.71

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.42μs	0.512ns	1.84ns	0.0221	1.57 KB
master	`EnrichedLog`	netcoreapp3.1	2.25μs	1.27ns	4.57ns	0.0214	1.57 KB
master	`EnrichedLog`	net472	2.74μs	4.28ns	16.6ns	0.237	1.5 KB
#4839	`EnrichedLog`	net6.0	1.59μs	0.31ns	1.16ns	0.0219	1.57 KB
#4839	`EnrichedLog`	netcoreapp3.1	2.2μs	1.15ns	4.47ns	0.021	1.57 KB
#4839	`EnrichedLog`	net472	2.68μs	1.98ns	7.66ns	0.238	1.5 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	113μs	116ns	449ns	0	0	4.21 KB
master	`EnrichedLog`	netcoreapp3.1	117μs	132ns	511ns	0.0591	0	4.21 KB
master	`EnrichedLog`	net472	149μs	70.7ns	274ns	0.668	0.223	4.39 KB
#4839	`EnrichedLog`	net6.0	113μs	119ns	460ns	0.0567	0	4.21 KB
#4839	`EnrichedLog`	netcoreapp3.1	120μs	146ns	566ns	0	0	4.21 KB
#4839	`EnrichedLog`	net472	148μs	66.8ns	259ns	0.667	0.222	4.39 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.08μs	0.662ns	2.48ns	0.0293	2.13 KB
master	`EnrichedLog`	netcoreapp3.1	4.19μs	1.89ns	7.06ns	0.0273	2.13 KB
master	`EnrichedLog`	net472	4.87μs	1.95ns	7.56ns	0.308	1.95 KB
#4839	`EnrichedLog`	net6.0	3.09μs	0.484ns	1.68ns	0.0294	2.13 KB
#4839	`EnrichedLog`	netcoreapp3.1	4.26μs	1.33ns	5.16ns	0.0278	2.13 KB
#4839	`EnrichedLog`	net472	4.99μs	1.51ns	5.64ns	0.308	1.95 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.32μs	0.554ns	2.14ns	0.0152	1.1 KB
master	`SendReceive`	netcoreapp3.1	1.75μs	0.533ns	1.99ns	0.0151	1.1 KB
master	`SendReceive`	net472	2.09μs	1.52ns	5.69ns	0.176	1.12 KB
#4839	`SendReceive`	net6.0	1.34μs	0.884ns	3.42ns	0.0154	1.1 KB
#4839	`SendReceive`	netcoreapp3.1	1.73μs	0.499ns	1.8ns	0.0147	1.1 KB
#4839	`SendReceive`	net472	2.14μs	3.75ns	14.5ns	0.177	1.12 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.97μs	1.7ns	6.58ns	0.0208	1.53 KB
master	`EnrichedLog`	netcoreapp3.1	3.95μs	1.8ns	6.97ns	0.0197	1.58 KB
master	`EnrichedLog`	net472	4.4μs	1.91ns	7.13ns	0.312	1.97 KB
#4839	`EnrichedLog`	net6.0	2.78μs	0.689ns	2.67ns	0.0207	1.53 KB
#4839	`EnrichedLog`	netcoreapp3.1	3.95μs	1.05ns	3.92ns	0.0215	1.58 KB
#4839	`EnrichedLog`	net472	4.32μs	2.05ns	7.66ns	0.31	1.97 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	514ns	0.212ns	0.819ns	0.00757	536 B
master	`StartFinishSpan`	netcoreapp3.1	656ns	0.392ns	1.52ns	0.00715	536 B
master	`StartFinishSpan`	net472	808ns	0.203ns	0.76ns	0.0853	538 B
master	`StartFinishScope`	net6.0	627ns	0.208ns	0.78ns	0.00899	656 B
master	`StartFinishScope`	netcoreapp3.1	834ns	0.485ns	1.88ns	0.00878	656 B
master	`StartFinishScope`	net472	963ns	0.429ns	1.66ns	0.0979	618 B
#4839	`StartFinishSpan`	net6.0	475ns	0.1ns	0.348ns	0.00756	536 B
#4839	`StartFinishSpan`	netcoreapp3.1	719ns	0.169ns	0.655ns	0.00721	536 B
#4839	`StartFinishSpan`	net472	753ns	0.284ns	1.1ns	0.0851	538 B
#4839	`StartFinishScope`	net6.0	578ns	0.15ns	0.582ns	0.00925	656 B
#4839	`StartFinishScope`	netcoreapp3.1	860ns	0.378ns	1.46ns	0.00895	656 B
#4839	`StartFinishScope`	net472	966ns	1.22ns	4.73ns	0.098	618 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #4839

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0	1.152	569.26	655.91

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	569ns	0.162ns	0.627ns	0.00933	656 B
master	`RunOnMethodBegin`	netcoreapp3.1	960ns	0.758ns	2.94ns	0.00871	656 B
master	`RunOnMethodBegin`	net472	1.06μs	0.363ns	1.41ns	0.0978	618 B
#4839	`RunOnMethodBegin`	net6.0	656ns	0.266ns	1.03ns	0.00919	656 B
#4839	`RunOnMethodBegin`	netcoreapp3.1	997ns	0.778ns	3.01ns	0.00866	656 B
#4839	`RunOnMethodBegin`	net472	1.05μs	0.38ns	1.47ns	0.098	618 B

andrewlock

LGTM, this going to be a really fun one to update snapshots I expect 😄

The good news is it always appears to be after env: integration_tests, which should be standard across all snapshots, so 🤞 you should be able to regex replace this one

andrewlock · 2023-11-15T00:48:39Z

Throughput/Crank Report:zap:

Throughput results for AspNetCoreSimpleController comparing the following branches/commits:

Cases where throughput results for the PR are worse than latest master (5% drop or greater), results are shown in red.

Note that these results are based on a single point-in-time result for each branch. For full results, see one of the many, many dashboards!

gantt
    title Throughput Linux x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4839) (11.260M)   : 0, 11260477
    master (11.078M)   : 0, 11078217
    benchmarks/2.9.0 (11.015M)   : 0, 11014948

    section Automatic
    This PR (4839) (7.684M)   : 0, 7683640
    master (7.478M)   : 0, 7478193
    benchmarks/2.9.0 (7.926M)   : 0, 7925773

    section Trace stats
    This PR (4839) (7.987M)   : 0, 7986988
    master (7.957M)   : 0, 7956885

    section Manual
    This PR (4839) (9.838M)   : 0, 9838045
    master (9.693M)   : 0, 9692849

    section Manual + Automatic
    This PR (4839) (7.284M)   : 0, 7284378
    master (7.162M)   : 0, 7161560

    section Version Conflict
    This PR (4839) (6.575M)   : 0, 6575109
    master (6.527M)   : 0, 6527327

gantt
    title Throughput Linux arm64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4839) (9.709M)   : 0, 9708513
    master (9.511M)   : 0, 9511060
    benchmarks/2.9.0 (9.652M)   : 0, 9651615

    section Automatic
    This PR (4839) (6.629M)   : 0, 6629273
    master (6.731M)   : 0, 6730572

    section Trace stats
    This PR (4839) (6.817M)   : 0, 6817056
    master (6.843M)   : 0, 6842643

    section Manual
    This PR (4839) (8.057M)   : 0, 8056657
    master (8.329M)   : 0, 8329261

    section Manual + Automatic
    This PR (4839) (6.190M)   : 0, 6189719
    master (6.241M)   : 0, 6241377

    section Version Conflict
    This PR (4839) (5.797M)   : 0, 5796681
    master (5.733M)   : 0, 5732704

gantt
    title Throughput Windows x64 (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4839) (9.802M)   : 0, 9802365
    master (10.008M)   : 0, 10007628
    benchmarks/2.9.0 (10.371M)   : 0, 10371072

    section Automatic
    This PR (4839) (6.910M)   : 0, 6909641
    master (7.094M)   : 0, 7093941
    benchmarks/2.9.0 (7.518M)   : 0, 7518013

    section Trace stats
    This PR (4839) (7.264M)   : 0, 7264326
    master (7.321M)   : 0, 7320885

    section Manual
    This PR (4839) (8.803M)   : 0, 8803299
    master (8.839M)   : 0, 8838799

    section Manual + Automatic
    This PR (4839) (6.662M)   : 0, 6661743
    master (6.905M)   : 0, 6904693

    section Version Conflict
    This PR (4839) (6.105M)   : 0, 6104730
    master (6.177M)   : 0, 6176842

gantt
    title Throughput Linux x64 (ASM) (Total requests) 
    dateFormat  X
    axisFormat %s
    section Baseline
    This PR (4839) (7.489M)   : 0, 7488839
    master (7.477M)   : 0, 7476892
    benchmarks/2.9.0 (7.958M)   : 0, 7957509

    section No attack
    This PR (4839) (1.747M)   : 0, 1747484
    master (1.770M)   : 0, 1770190
    benchmarks/2.9.0 (3.247M)   : 0, 3247318

    section Attack
    This PR (4839) (1.403M)   : 0, 1402862
    master (1.399M)   : 0, 1398783
    benchmarks/2.9.0 (2.539M)   : 0, 2539306

    section Blocking
    This PR (4839) (3.091M)   : 0, 3091176
    master (3.092M)   : 0, 3092380

    section IAST default
    This PR (4839) (6.399M)   : 0, 6398599
    master (6.527M)   : 0, 6527052

    section IAST full
    This PR (4839) (5.588M)   : 0, 5587507
    master (5.701M)   : 0, 5700591

    section Base vuln
    This PR (4839) (0.937M)   : 0, 936853
    master (0.938M)   : 0, 937685

    section IAST vuln
    This PR (4839) (0.844M)   : 0, 843810
    master (0.865M)   : 0, 864967

bouwkast

Looks good to me, I only skimmed a few of the snapshots as they looked the same

datadog-ddstaging · 2023-11-15T22:10:33Z

Datadog Report

Branch report: lpimentel/add-language-tag-to-all-spans
Commit report: cc7bb04

❄️ dd-trace-dotnet: 0 Failed, 1 New Flaky, 301251 Passed, 970 Skipped, 40m 3.99s Wall Time

New Flaky Tests (1)

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.KafkaTests - Last Failure

Expand for error

 Expected allData to contain a single item matching x.IsRequestType("app-closing"), but no such item was found.
 Expected latestIntegrations not to be empty.
 Expected varintegration=latestIntegrations {empty} to contain key "Kafka".
 Expected integration.Enabled to be True because should only be enabled if we generate a span, but found False.
 Expected True because should only be auto-enabled if available, but found <null>.

datadog-ddstaging · 2023-12-04T18:50:59Z

Datadog Report

Branch report: lpimentel/add-language-tag-to-all-spans
Commit report: a5b9940

❌ dd-trace-dotnet: 18 Failed (0 Known Flaky), 0 New Flaky, 308797 Passed, 1028 Skipped, 30m 26.51s Wall Time

❌ Failed Tests (18)

This report shows up to 5 failed tests.

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsSqsTests - Details

Expand for error

 Results do not match.
 Differences:
 Received: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.received.txt
 Verified: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: async-methods,
 ...

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsSqsTests - Details

Expand for error

 Results do not match.
 Differences:
 Received: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.received.txt
 Verified: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: async-methods,
 ...

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsSqsTests - Details

Expand for error

 Results do not match.
 Differences:
 Received: AwsSqsTests.NetCore.SchemaV0.pre3_7_300.received.txt
 Verified: AwsSqsTests.NetCore.SchemaV0.pre3_7_300.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: async-methods,
 ...

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsSqsTests - Details

Expand for error

 Results do not match.
 Differences:
 Received: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.received.txt
 Verified: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: async-methods,
 ...

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsSqsTests - Details

Expand for error

 Results do not match.
 Differences:
 Received: AwsSqsTests.NetCore.SchemaV0.pre3_7_300.received.txt
 Verified: AwsSqsTests.NetCore.SchemaV0.pre3_7_300.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: async-methods,
 ...

andrewlock · 2023-12-05T14:32:55Z

We're going to do this in v3 now right? If so, I suggest rebasing on v3-main and merging into there (once tests are fixed!) 🙂

datadog-ddstaging · 2023-12-13T20:34:54Z

Datadog Report

Branch report: lpimentel/add-language-tag-to-all-spans
Commit report: fe8013a

❌ dd-trace-dotnet: 35 Failed (0 Known Flaky), 0 New Flaky, 298194 Passed, 928 Skipped, 30m 42.14s Wall Time

❌ Failed Tests (35)

This report shows up to 5 failed tests.

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsSqsTests - Details

Expand for error

 Results do not match.
 Differences:
 Received: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.received.txt
 Verified: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: async-methods,
 ...

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsSqsTests - Details

Expand for error

 Results do not match.
 Differences:
 Received: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.received.txt
 Verified: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: async-methods,
 ...

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsSqsTests - Details

Expand for error

 Results do not match.
 Differences:
 Received: AwsSqsTests.NetCore.SchemaV0.pre3_7_300.received.txt
 Verified: AwsSqsTests.NetCore.SchemaV0.pre3_7_300.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: async-methods,
 ...

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsSqsTests - Details

Expand for error

 Results do not match.
 Differences:
 Received: AwsSqsTests.NetCore.SchemaV0.pre3_7_300.received.txt
 Verified: AwsSqsTests.NetCore.SchemaV0.pre3_7_300.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: async-methods,
 ...

SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AWS.AwsSqsTests - Details

Expand for error

 Results do not match.
 Differences:
 Received: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.received.txt
 Verified: AwsSqsTests.NetCore.SchemaV1.pre3_7_300.verified.txt
 Received Content:
 [
   {
     TraceId: Id_1,
     SpanId: Id_2,
     Name: async-methods,
 ...

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

lucaspimentel added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Nov 8, 2023

andrewlock approved these changes Nov 9, 2023

View reviewed changes

lucaspimentel force-pushed the lpimentel/add-language-tag-to-all-spans branch 2 times, most recently from d6533cf to 69d9ecf Compare November 14, 2023 20:05

lucaspimentel marked this pull request as ready for review November 14, 2023 20:07

lucaspimentel requested a review from a team as a code owner November 14, 2023 20:07

lucaspimentel force-pushed the lpimentel/add-language-tag-to-all-spans branch 2 times, most recently from 07e99e4 to c28b88c Compare November 15, 2023 19:51

bouwkast approved these changes Nov 15, 2023

View reviewed changes

lucaspimentel requested a review from a team as a code owner November 15, 2023 21:04

andrewlock approved these changes Nov 17, 2023

View reviewed changes

lucaspimentel added the status:do-not-merge Work is done. Can review, but do not merge yet. label Nov 17, 2023

lucaspimentel changed the title ~~add language tag all spans~~ [DO NOT MERGE] add language tag all spans Nov 17, 2023

lucaspimentel force-pushed the lpimentel/add-language-tag-to-all-spans branch from cc7bb04 to a5b9940 Compare December 4, 2023 18:29

lucaspimentel force-pushed the lpimentel/add-language-tag-to-all-spans branch from a5b9940 to fe8013a Compare December 13, 2023 20:13

lucaspimentel changed the base branch from master to v3-main January 19, 2024 17:17

andrewlock force-pushed the v3-main branch 2 times, most recently from 89d9080 to 5aba9b1 Compare January 22, 2024 15:00

lucaspimentel added 3 commits January 22, 2024 14:04

add language tag all spans

9e232f5

fix unit tests

8074048

update test snapshots

a024ede

andrewlock pushed a commit that referenced this pull request Apr 9, 2024

[v3] add language tag all spans (#4839)

5ec2561

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Apr 10, 2024

[v3] add language tag all spans (#4839)

89a3ed0

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Apr 16, 2024

[v3] add language tag all spans (#4839)

b78d9c1

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Apr 17, 2024

[v3] add language tag all spans (#4839)

136e08d

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Apr 19, 2024

[v3] add language tag all spans (#4839)

ced3239

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Apr 19, 2024

[v3] add language tag all spans (#4839)

3b49372

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Apr 22, 2024

[v3] add language tag all spans (#4839)

f5f30e5

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock added this to the vNext-v3 milestone Apr 22, 2024

andrewlock pushed a commit that referenced this pull request Apr 23, 2024

[v3] add language tag all spans (#4839)

e2d0fd4

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Apr 23, 2024

[v3] add language tag all spans (#4839)

20861c7

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Apr 25, 2024

[v3] add language tag all spans (#4839)

3036932

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Apr 30, 2024

[v3] add language tag all spans (#4839)

0b4a428

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request May 1, 2024

[v3] add language tag all spans (#4839)

143aca9

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request May 24, 2024

[v3] add language tag all spans (#4839)

9916e49

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request May 30, 2024

[v3] add language tag all spans (#4839)

ec550ff

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jun 5, 2024

[v3] add language tag all spans (#4839)

f500756

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jun 12, 2024

[v3] add language tag all spans (#4839)

0bc0e28

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jun 24, 2024

[v3] add language tag all spans (#4839)

010ab4a

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jun 26, 2024

[v3] add language tag all spans (#4839)

7aaae84

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jun 27, 2024

[v3] add language tag all spans (#4839)

9f99805

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jul 1, 2024

[v3] add language tag all spans (#4839)

ec38d1d

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jul 1, 2024

[v3] add language tag all spans (#4839)

3869984

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jul 2, 2024

[v3] add language tag all spans (#4839)

6c781c6

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jul 2, 2024

[v3] add language tag all spans (#4839)

c4d5c46

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jul 2, 2024

[v3] add language tag all spans (#4839)

d0f6d18

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jul 3, 2024

[v3] add language tag all spans (#4839)

bc32756

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jul 4, 2024

[v3] add language tag all spans (#4839)

6107278

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jul 4, 2024

[v3] add language tag all spans (#4839)

0b4908c

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jul 16, 2024

[v3] add language tag all spans (#4839)

86f2c55

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

andrewlock pushed a commit that referenced this pull request Jul 18, 2024

[v3] add language tag all spans (#4839)

3c85590

* add language tag all spans * fix unit tests * update test snapshots * update smoke test snapshots * update test snapshots

Uh oh!

Conversation

lucaspimentel commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

Uh oh!

datadog-ddstaging Bot commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

Uh oh!

andrewlock commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Execution-Time Benchmarks Report ⏱️

Uh oh!

github-actions Bot commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Snapshots difference summary

Uh oh!

andrewlock commented Nov 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

More allocations ⚠️ in #4839

Raw results

Raw results

Faster 🎉 in #4839

Raw results

Raw results

Raw results

More allocations ⚠️ in #4839

Fewer allocations 🎉 in #4839

Raw results

Slower ⚠️ in #4839

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #4839

Raw results

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

andrewlock commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Throughput/Crank Report:zap:

Uh oh!

bouwkast left a comment

Choose a reason for hiding this comment

Uh oh!

datadog-ddstaging Bot commented Nov 15, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

New Flaky Tests (1)

Uh oh!

datadog-ddstaging Bot commented Dec 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

❌ Failed Tests (18)

Uh oh!

andrewlock commented Dec 5, 2023

Uh oh!

datadog-ddstaging Bot commented Dec 13, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Datadog Report

❌ Failed Tests (35)

Uh oh!

Reviewers

Assignees

lucaspimentel commented Nov 8, 2023 •

edited

Loading

datadog-ddstaging Bot commented Nov 8, 2023 •

edited

Loading

andrewlock commented Nov 8, 2023 •

edited

Loading

github-actions Bot commented Nov 8, 2023 •

edited

Loading

andrewlock commented Nov 8, 2023 •

edited

Loading

andrewlock commented Nov 15, 2023 •

edited

Loading

datadog-ddstaging Bot commented Nov 15, 2023 •

edited

Loading

datadog-ddstaging Bot commented Dec 4, 2023 •

edited

Loading

datadog-ddstaging Bot commented Dec 13, 2023 •

edited

Loading