Skip to content

[Test Package Versions Bump] Updating package versions#3376

Merged
andrewlock merged 1 commit into
masterfrom
bot/test-package-versions-bump
Oct 24, 2022
Merged

[Test Package Versions Bump] Updating package versions#3376
andrewlock merged 1 commit into
masterfrom
bot/test-package-versions-bump

Conversation

@github-actions

@github-actions github-actions Bot commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

Updates the package versions for integration tests.

@github-actions
github-actions Bot requested review from a team as code owners October 20, 2022 16:28
andrewlock
andrewlock approved these changes Oct 20, 2022
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good 🤖

@andrewlock

andrewlock commented Oct 20, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #3376 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.139
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 792μs 471ns 1.82μs 0.396 0 0 3.22 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 532μs 318ns 1.19μs 0 0 0 2.63 KB
#3376 WriteAndFlushEnrichedTraces net472 792μs 241ns 903ns 0.396 0 0 3.22 KB
#3376 WriteAndFlushEnrichedTraces netcoreapp3.1 550μs 126ns 470ns 0 0 0 2.62 KB
Benchmarks.Trace.AppSecBodyBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #3376

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 1.139 221.25 194.18

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 197ns 0.112ns 0.434ns 0.0701 0 0 441 B
master AllCycleSimpleBody netcoreapp3.1 255ns 0.281ns 1.09ns 0.00603 0 0 440 B
master AllCycleMoreComplexBody net472 221ns 0.302ns 1.13ns 0.0663 0 0 417 B
master AllCycleMoreComplexBody netcoreapp3.1 251ns 0.235ns 0.911ns 0.00569 0 0 416 B
master BodyExtractorSimpleBody net472 269ns 0.221ns 0.857ns 0.0574 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 238ns 0.107ns 0.4ns 0.00364 0 0 272 B
master BodyExtractorMoreComplexBody net472 16μs 8.82ns 33ns 1.2 0.0159 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 13.1μs 5.41ns 20.2ns 0.0917 0 0 6.75 KB
#3376 AllCycleSimpleBody net472 196ns 0.107ns 0.4ns 0.0701 9.83E-05 0 441 B
#3376 AllCycleSimpleBody netcoreapp3.1 252ns 0.114ns 0.427ns 0.0061 0 0 440 B
#3376 AllCycleMoreComplexBody net472 194ns 0.0329ns 0.127ns 0.0662 0 0 417 B
#3376 AllCycleMoreComplexBody netcoreapp3.1 251ns 0.0871ns 0.326ns 0.00567 0 0 416 B
#3376 BodyExtractorSimpleBody net472 274ns 0.15ns 0.581ns 0.0573 0 0 361 B
#3376 BodyExtractorSimpleBody netcoreapp3.1 245ns 0.0915ns 0.342ns 0.00369 0 0 272 B
#3376 BodyExtractorMoreComplexBody net472 15.6μs 10.4ns 40.3ns 1.21 0.0156 0 7.62 KB
#3376 BodyExtractorMoreComplexBody netcoreapp3.1 12.8μs 4.49ns 16.2ns 0.0898 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 182μs 364ns 1.41μs 0.272 0 0 20.66 KB
#3376 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3376 SendRequest netcoreapp3.1 179μs 211ns 819ns 0.179 0 0 20.66 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.85μs 0.655ns 2.45ns 0.158 0.000927 0 995 B
master ExecuteNonQuery netcoreapp3.1 1.44μs 0.468ns 1.75ns 0.0129 0 0 984 B
#3376 ExecuteNonQuery net472 1.8μs 0.536ns 2.08ns 0.158 0.000903 0 995 B
#3376 ExecuteNonQuery netcoreapp3.1 1.39μs 1.18ns 4.41ns 0.0132 0 0 984 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.41μs 1.32ns 5.11ns 0.19 0 0 1.2 KB
master CallElasticsearch netcoreapp3.1 1.56μs 0.323ns 1.25ns 0.0157 0 0 1.14 KB
master CallElasticsearchAsync net472 2.65μs 1.4ns 5.41ns 0.212 0 0 1.34 KB
master CallElasticsearchAsync netcoreapp3.1 1.56μs 0.723ns 2.61ns 0.0172 0 0 1.26 KB
#3376 CallElasticsearch net472 2.58μs 1.09ns 4.22ns 0.191 0 0 1.2 KB
#3376 CallElasticsearch netcoreapp3.1 1.53μs 0.617ns 2.39ns 0.0153 0 0 1.14 KB
#3376 CallElasticsearchAsync net472 2.64μs 1.15ns 4.47ns 0.213 0 0 1.34 KB
#3376 CallElasticsearchAsync netcoreapp3.1 1.59μs 1.03ns 3.84ns 0.0167 0 0 1.26 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.65μs 1.81ns 7.01ns 0.233 0 0 1.47 KB
master ExecuteAsync netcoreapp3.1 1.75μs 0.869ns 3.13ns 0.0185 0 0 1.39 KB
#3376 ExecuteAsync net472 2.67μs 2.08ns 7.77ns 0.233 0 0 1.47 KB
#3376 ExecuteAsync netcoreapp3.1 1.76μs 0.708ns 2.74ns 0.0193 0 0 1.39 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.8μs 2.78ns 10.8ns 0.446 0 0 2.82 KB
master SendAsync netcoreapp3.1 3.64μs 1.37ns 5.11ns 0.0346 0 0 2.65 KB
#3376 SendAsync net472 5.81μs 2.46ns 9.54ns 0.448 0 0 2.82 KB
#3376 SendAsync netcoreapp3.1 3.7μs 1.08ns 4.06ns 0.0351 0 0 2.65 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.22μs 2.59ns 10ns 0.297 0 0 1.88 KB
master EnrichedLog netcoreapp3.1 2.5μs 1.83ns 6.86ns 0.0248 0 0 1.91 KB
#3376 EnrichedLog net472 3.17μs 2.65ns 10.3ns 0.298 0 0 1.88 KB
#3376 EnrichedLog netcoreapp3.1 2.51μs 2.16ns 8.35ns 0.0252 0 0 1.91 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 151μs 106ns 412ns 0.676 0.225 0 4.72 KB
master EnrichedLog netcoreapp3.1 121μs 226ns 876ns 0 0 0 4.55 KB
#3376 EnrichedLog net472 152μs 92.8ns 335ns 0.684 0.228 0 4.72 KB
#3376 EnrichedLog netcoreapp3.1 120μs 116ns 451ns 0.0602 0 0 4.55 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.8μs 2.75ns 10.3ns 0.578 0.0029 0 3.65 KB
master EnrichedLog netcoreapp3.1 4.47μs 1.74ns 6.52ns 0.0538 0 0 3.98 KB
#3376 EnrichedLog net472 5.74μs 2.52ns 9.44ns 0.579 0.00286 0 3.65 KB
#3376 EnrichedLog netcoreapp3.1 4.46μs 1.7ns 6.36ns 0.0533 0 0 3.98 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.37μs 2.33ns 8.07ns 0.225 0 0 1.42 KB
master SendReceive netcoreapp3.1 1.91μs 1.32ns 5.11ns 0.018 0 0 1.37 KB
#3376 SendReceive net472 2.22μs 1.31ns 5.08ns 0.226 0 0 1.42 KB
#3376 SendReceive netcoreapp3.1 1.8μs 0.671ns 2.6ns 0.0189 0 0 1.37 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.18μs 3.13ns 12.1ns 0.365 0 0 2.3 KB
master EnrichedLog netcoreapp3.1 4.2μs 1.46ns 5.46ns 0.0251 0 0 1.86 KB
#3376 EnrichedLog net472 4.98μs 2.28ns 8.83ns 0.365 0 0 2.3 KB
#3376 EnrichedLog netcoreapp3.1 4.21μs 2.31ns 8.65ns 0.0251 0 0 1.86 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.22μs 0.272ns 1.02ns 0.136 0 0 859 B
master StartFinishSpan netcoreapp3.1 970ns 0.52ns 2.01ns 0.0112 0 0 808 B
master StartFinishScope net472 1.47μs 0.649ns 2.52ns 0.149 0 0 939 B
master StartFinishScope netcoreapp3.1 1.13μs 0.402ns 1.56ns 0.0128 0 0 928 B
#3376 StartFinishSpan net472 1.17μs 0.701ns 2.72ns 0.136 0 0 859 B
#3376 StartFinishSpan netcoreapp3.1 956ns 0.272ns 1.02ns 0.011 0 0 808 B
#3376 StartFinishScope net472 1.5μs 0.213ns 0.768ns 0.149 0 0 939 B
#3376 StartFinishScope netcoreapp3.1 1.17μs 0.492ns 1.84ns 0.0123 0 0 928 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.49μs 0.421ns 1.63ns 0.149 0 0 939 B
master RunOnMethodBegin netcoreapp3.1 1.15μs 0.338ns 1.22ns 0.0127 0 0 928 B
#3376 RunOnMethodBegin net472 1.5μs 0.69ns 2.67ns 0.149 0 0 939 B
#3376 RunOnMethodBegin netcoreapp3.1 1.14μs 0.52ns 1.95ns 0.0125 0 0 928 B

@andrewlock

andrewlock commented Oct 21, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

✔️ Merging #3376 into master will not change line coverage
✔️ Merging #3376 into master will not change branch coverage
✔️ Merging #3376 into master will will decrease complexity by 8

master #3376 Change
Lines 19594 / 27074 19599 / 27060
Lines % 72% 72% 0% ✔️
Branches 11593 / 16760 11596 / 16752
Branches % 69% 69% 0% ✔️
Complexity 18141 18133 -8 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3376 Change
Lines % 72% 72% 0% ✔️
Branches % 69% 69% 0% ✔️
Complexity 18141 18133 -8 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.ClrProfiler.ServerlessInstrumentation.LambdaHandler -2% ⚠️ -6% ⛔ -8 ✔️

View the full reports for further details:

@andrewlock
andrewlock merged commit cf93c80 into master Oct 24, 2022
@andrewlock
andrewlock deleted the bot/test-package-versions-bump branch October 24, 2022 12:34
@github-actions github-actions Bot added this to the vNext milestone Oct 24, 2022
@anna-git anna-git added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes
@pierotibou pierotibou pierotibou approved these changes

Assignees

No one assigned

Labels

area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)

Projects

None yet

Milestone

2.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @pierotibou @anna-git