[Profiler] Samples supports timestamps as label#3372
Merged
Conversation
github-actions
Bot
added
the
area:profiler
kevingosse
approved these changes
Oct 21, 2022
Comment on lines
+29
to
+36
| if (framework != "netcoreapp3.1") | ||
| { | ||
| new SmokeTestRunner(appName, framework, appAssembly, commandLine: "--scenario 1", _output, TransportType.NamedPipe).RunAndCheck(); | ||
| } | ||
| else | ||
| { | ||
| // TODO: need to figure out issue in netcore3.1 for x86 | ||
| } |
Contributor
There was a problem hiding this comment.
I don't think that's related to the PR?
Contributor
Author
There was a problem hiding this comment.
Creating a new PR right away!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Store samples timestamp as a label in .pprof
Reason for change
Before changing the .pprof format with breakdown, support samples timestamp with the current format.
Implementation details
Samples timestamp is stored with the "timestamp_ns" label in .pprof.
Supported under DD_INTERNAL_PROFILING_TIMESTAMPS_AS_LABEL_ENABLED environment variable with a default value of false.
Test coverage
Other details