Skip to content

Fix broken package version bump + add GitHub action#3364

Merged
andrewlock merged 3 commits into
masterfrom
andrew/fix-broken-test-bump
Oct 18, 2022
Merged

Fix broken package version bump + add GitHub action#3364
andrewlock merged 3 commits into
masterfrom
andrew/fix-broken-test-bump

Conversation

@andrewlock

@andrewlock andrewlock commented Oct 18, 2022

Copy link
Copy Markdown
Member

Summary of changes

Reason for change

This is the second time we've broken the auto-version-bump PR by not updating IntegrationMap in recent times, so added a GitHub action to fix it.

Implementation details

The GitHub action runs the same code as the "real" bump action, it just doesn't create a PR.

Test coverage

You can't test an action until it's merged to master, so YOLO (but I think this should work).

Other details

Will mark it required after merging

@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Oct 18, 2022
@andrewlock
andrewlock requested review from a team as code owners October 18, 2022 12:13
@andrewlock andrewlock changed the title Fix broken test versions Fix broken package version bump + add GitHub action Oct 18, 2022
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
pierotibou
pierotibou approved these changes Oct 18, 2022
View reviewed changes

@pierotibou pierotibou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Comment thread .github/workflows/verify_integrations_map_added.yml

- name: Report error
run: |
echo "## :warning: Error generating package versions" >> $GITHUB_STEP_SUMMARY

@pierotibou pierotibou Oct 18, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, I'm not missing something. This will be run all the time even when there are no errors, right?

@andrewlock andrewlock Oct 18, 2022

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops 🤦‍♂️

@andrewlock

andrewlock commented Oct 18, 2022

Copy link
Copy Markdown
Member Author

Benchmarks Report 🐌

Benchmarks for #3364 compared to master:

  • All benchmarks have the same speed
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 808μs 590ns 2.21μs 0.403 0 0 3.22 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 556μs 272ns 1.02μs 0 0 0 2.62 KB
#3364 WriteAndFlushEnrichedTraces net472 809μs 443ns 1.72μs 0.403 0 0 3.22 KB
#3364 WriteAndFlushEnrichedTraces netcoreapp3.1 543μs 207ns 776ns 0 0 0 2.63 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 197ns 0.0869ns 0.313ns 0.0701 9.85E-05 0 441 B
master AllCycleSimpleBody netcoreapp3.1 257ns 0.24ns 0.928ns 0.00605 0 0 440 B
master AllCycleMoreComplexBody net472 196ns 0.0453ns 0.17ns 0.0663 0 0 417 B
master AllCycleMoreComplexBody netcoreapp3.1 252ns 0.244ns 0.945ns 0.00567 0 0 416 B
master BodyExtractorSimpleBody net472 270ns 0.365ns 1.37ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 244ns 0.123ns 0.461ns 0.00368 0 0 272 B
master BodyExtractorMoreComplexBody net472 16.3μs 17.7ns 68.4ns 1.2 0.0163 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 12.9μs 6.84ns 26.5ns 0.0895 0 0 6.75 KB
#3364 AllCycleSimpleBody net472 199ns 0.139ns 0.52ns 0.0701 0 0 441 B
#3364 AllCycleSimpleBody netcoreapp3.1 252ns 0.121ns 0.453ns 0.00605 0 0 440 B
#3364 AllCycleMoreComplexBody net472 194ns 0.0588ns 0.228ns 0.0662 0 0 417 B
#3364 AllCycleMoreComplexBody netcoreapp3.1 250ns 0.122ns 0.458ns 0.00566 0 0 416 B
#3364 BodyExtractorSimpleBody net472 274ns 0.162ns 0.605ns 0.0573 0 0 361 B
#3364 BodyExtractorSimpleBody netcoreapp3.1 230ns 0.0804ns 0.301ns 0.00368 0 0 272 B
#3364 BodyExtractorMoreComplexBody net472 16.1μs 18ns 69.7ns 1.21 0.016 0 7.62 KB
#3364 BodyExtractorMoreComplexBody netcoreapp3.1 13.2μs 4.11ns 15.9ns 0.0922 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 184μs 186ns 720ns 0.274 0 0 20.66 KB
#3364 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3364 SendRequest netcoreapp3.1 183μs 178ns 689ns 0.273 0 0 20.66 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.81μs 0.509ns 1.91ns 0.158 0.000903 0 995 B
master ExecuteNonQuery netcoreapp3.1 1.4μs 0.516ns 1.86ns 0.0133 0 0 984 B
#3364 ExecuteNonQuery net472 1.83μs 0.566ns 2.19ns 0.158 0.000913 0 995 B
#3364 ExecuteNonQuery netcoreapp3.1 1.4μs 0.322ns 1.21ns 0.0135 0 0 984 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.5μs 0.855ns 3.08ns 0.191 0 0 1.2 KB
master CallElasticsearch netcoreapp3.1 1.51μs 0.938ns 3.51ns 0.0158 0 0 1.14 KB
master CallElasticsearchAsync net472 2.63μs 0.441ns 1.59ns 0.212 0 0 1.34 KB
master CallElasticsearchAsync netcoreapp3.1 1.58μs 0.483ns 1.74ns 0.0173 0 0 1.26 KB
#3364 CallElasticsearch net472 2.52μs 0.724ns 2.71ns 0.191 0 0 1.2 KB
#3364 CallElasticsearch netcoreapp3.1 1.53μs 0.843ns 3.16ns 0.0154 0 0 1.14 KB
#3364 CallElasticsearchAsync net472 2.71μs 1.46ns 5.65ns 0.213 0 0 1.34 KB
#3364 CallElasticsearchAsync netcoreapp3.1 1.6μs 0.51ns 1.84ns 0.0168 0 0 1.26 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.77μs 3.81ns 14.2ns 0.233 0 0 1.47 KB
master ExecuteAsync netcoreapp3.1 1.74μs 1.45ns 5.41ns 0.0184 0 0 1.39 KB
#3364 ExecuteAsync net472 2.82μs 1.75ns 6.8ns 0.233 0 0 1.47 KB
#3364 ExecuteAsync netcoreapp3.1 1.69μs 0.55ns 2.13ns 0.0187 0 0 1.39 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.96μs 1.27ns 4.77ns 0.446 0 0 2.82 KB
master SendAsync netcoreapp3.1 3.69μs 1.98ns 7.68ns 0.035 0 0 2.65 KB
#3364 SendAsync net472 5.85μs 1.48ns 5.35ns 0.447 0 0 2.82 KB
#3364 SendAsync netcoreapp3.1 3.65μs 2.31ns 8.64ns 0.0366 0 0 2.65 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.23μs 4.46ns 16.1ns 0.297 0 0 1.88 KB
master EnrichedLog netcoreapp3.1 2.51μs 1.84ns 6.9ns 0.0264 0 0 1.91 KB
#3364 EnrichedLog net472 3.26μs 5.37ns 20.8ns 0.298 0 0 1.88 KB
#3364 EnrichedLog netcoreapp3.1 2.49μs 1.28ns 4.97ns 0.0262 0 0 1.91 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 151μs 170ns 657ns 0.679 0.226 0 4.72 KB
master EnrichedLog netcoreapp3.1 121μs 136ns 510ns 0.0597 0 0 4.55 KB
#3364 EnrichedLog net472 152μs 144ns 539ns 0.676 0.225 0 4.72 KB
#3364 EnrichedLog netcoreapp3.1 120μs 194ns 727ns 0.0596 0 0 4.55 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.66μs 1.64ns 6.35ns 0.579 0.00284 0 3.65 KB
master EnrichedLog netcoreapp3.1 4.42μs 1.63ns 6.09ns 0.053 0 0 3.98 KB
#3364 EnrichedLog net472 5.75μs 2.23ns 8.33ns 0.578 0.00283 0 3.65 KB
#3364 EnrichedLog netcoreapp3.1 4.4μs 1.3ns 4.87ns 0.0552 0 0 3.98 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.24μs 4.02ns 15.6ns 0.226 0 0 1.42 KB
master SendReceive netcoreapp3.1 1.84μs 0.668ns 2.59ns 0.0184 0 0 1.37 KB
#3364 SendReceive net472 2.26μs 2.85ns 11ns 0.225 0 0 1.42 KB
#3364 SendReceive netcoreapp3.1 1.77μs 1.3ns 5.02ns 0.0187 0 0 1.37 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 4.92μs 3.09ns 12ns 0.365 0 0 2.3 KB
master EnrichedLog netcoreapp3.1 4.34μs 2.07ns 7.45ns 0.0242 0 0 1.86 KB
#3364 EnrichedLog net472 5.12μs 1.94ns 7.5ns 0.363 0 0 2.3 KB
#3364 EnrichedLog netcoreapp3.1 4.32μs 1.43ns 5.54ns 0.0236 0 0 1.86 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.18μs 0.48ns 1.8ns 0.136 0 0 859 B
master StartFinishSpan netcoreapp3.1 936ns 0.362ns 1.31ns 0.011 0 0 808 B
master StartFinishScope net472 1.42μs 0.462ns 1.73ns 0.149 0 0 939 B
master StartFinishScope netcoreapp3.1 1.04μs 0.754ns 2.92ns 0.0125 0 0 928 B
#3364 StartFinishSpan net472 1.16μs 0.297ns 1.11ns 0.136 0 0 859 B
#3364 StartFinishSpan netcoreapp3.1 919ns 0.779ns 2.92ns 0.0111 0 0 808 B
#3364 StartFinishScope net472 1.4μs 0.707ns 2.65ns 0.149 0 0 939 B
#3364 StartFinishScope netcoreapp3.1 1.06μs 0.659ns 2.55ns 0.0126 0 0 928 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.44μs 0.546ns 2.12ns 0.149 0 0 939 B
master RunOnMethodBegin netcoreapp3.1 1.17μs 0.438ns 1.7ns 0.0122 0 0 928 B
#3364 RunOnMethodBegin net472 1.48μs 1.16ns 4.5ns 0.149 0 0 939 B
#3364 RunOnMethodBegin netcoreapp3.1 1.13μs 0.348ns 1.3ns 0.0125 0 0 928 B

@andrewlock

andrewlock commented Oct 18, 2022

Copy link
Copy Markdown
Member Author

Code Coverage Report 📊

✔️ Merging #3364 into master will not change line coverage
✔️ Merging #3364 into master will not change branch coverage
✔️ Merging #3364 into master will not change complexity

master #3364 Change
Lines 19602 / 27011 19597 / 27011
Lines % 73% 73% 0% ✔️
Branches 11633 / 16784 11630 / 16784
Branches % 69% 69% 0% ✔️
Complexity 18160 18160 0 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3364 Change
Lines % 73% 73% 0% ✔️
Branches % 69% 69% 0% ✔️
Complexity 18160 18160 0 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Ci.GitInfo 5% ✔️ 8% ✔️ 0 ✔️

View the full reports for further details:

@andrewlock
andrewlock merged commit 955b464 into master Oct 18, 2022
@andrewlock
andrewlock deleted the andrew/fix-broken-test-bump branch October 18, 2022 15:23
@github-actions github-actions Bot added this to the vNext milestone Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pierotibou pierotibou pierotibou approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

2.18.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock @pierotibou