Skip to content

[Test Package Versions Bump] Updating package versions#3300

Merged
pierotibou merged 1 commit into
masterfrom
bot/test-package-versions-bump
Oct 12, 2022
Merged

[Test Package Versions Bump] Updating package versions#3300
pierotibou merged 1 commit into
masterfrom
bot/test-package-versions-bump

Conversation

@github-actions

@github-actions github-actions Bot commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Updates the package versions for integration tests.

@github-actions
github-actions Bot requested review from a team as code owners October 4, 2022 12:32
andrewlock
andrewlock approved these changes Oct 4, 2022
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's alive! :frankenstein:

@andrewlock

This comment has been minimized.

Sign in to view
@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from a4bfbe6 to f1b4731 Compare October 4, 2022 16:39
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from f1b4731 to 8cb1a52 Compare October 10, 2022 17:08
@andrewlock

This comment has been minimized.

Sign in to view
@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from 8cb1a52 to 30b932b Compare October 11, 2022 16:53
@andrewlock

andrewlock commented Oct 11, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #3300 compared to master:

  • All benchmarks have the same speed
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 790μs 502ns 1.94μs 0.396 0 0 3.22 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 525μs 125ns 484ns 0 0 0 2.63 KB
#3300 WriteAndFlushEnrichedTraces net472 797μs 424ns 1.64μs 0.396 0 0 3.22 KB
#3300 WriteAndFlushEnrichedTraces netcoreapp3.1 535μs 541ns 2.09μs 0 0 0 2.63 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 198ns 0.277ns 1.21ns 0.0727 0 0 457 B
master AllCycleSimpleBody netcoreapp3.1 256ns 0.189ns 0.706ns 0.00632 0 0 456 B
master AllCycleMoreComplexBody net472 208ns 0.116ns 0.436ns 0.0688 0 0 433 B
master AllCycleMoreComplexBody netcoreapp3.1 254ns 0.223ns 0.865ns 0.00598 0 0 432 B
master BodyExtractorSimpleBody net472 293ns 0.208ns 0.805ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 230ns 0.0689ns 0.267ns 0.0037 0 0 272 B
master BodyExtractorMoreComplexBody net472 15.7μs 12.1ns 47ns 1.21 0.0156 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 13.1μs 4.57ns 17.1ns 0.0912 0 0 6.75 KB
#3300 AllCycleSimpleBody net472 196ns 0.0412ns 0.159ns 0.0727 0 0 457 B
#3300 AllCycleSimpleBody netcoreapp3.1 252ns 0.186ns 0.696ns 0.00632 0 0 456 B
#3300 AllCycleMoreComplexBody net472 194ns 0.0869ns 0.325ns 0.0688 0 0 433 B
#3300 AllCycleMoreComplexBody netcoreapp3.1 258ns 0.138ns 0.517ns 0.00588 0 0 432 B
#3300 BodyExtractorSimpleBody net472 273ns 0.265ns 0.991ns 0.0574 0 0 361 B
#3300 BodyExtractorSimpleBody netcoreapp3.1 231ns 0.142ns 0.549ns 0.00372 0 0 272 B
#3300 BodyExtractorMoreComplexBody net472 16.2μs 14.3ns 51.5ns 1.21 0.0161 0 7.62 KB
#3300 BodyExtractorMoreComplexBody netcoreapp3.1 12.7μs 4.09ns 14.7ns 0.0891 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 180μs 208ns 807ns 0.271 0 0 20.68 KB
#3300 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3300 SendRequest netcoreapp3.1 181μs 213ns 823ns 0.181 0 0 20.68 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.81μs 1.09ns 4.23ns 0.155 0.00091 0 979 B
master ExecuteNonQuery netcoreapp3.1 1.39μs 0.731ns 2.74ns 0.0132 0 0 968 B
#3300 ExecuteNonQuery net472 1.93μs 0.662ns 2.48ns 0.155 0.000974 0 979 B
#3300 ExecuteNonQuery netcoreapp3.1 1.45μs 0.738ns 2.56ns 0.013 0 0 968 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.44μs 0.6ns 2.24ns 0.189 0 0 1.19 KB
master CallElasticsearch netcoreapp3.1 1.5μs 0.752ns 2.81ns 0.0151 0 0 1.13 KB
master CallElasticsearchAsync net472 2.75μs 3.57ns 13.8ns 0.21 0 0 1.32 KB
master CallElasticsearchAsync netcoreapp3.1 1.59μs 1.41ns 5.26ns 0.0166 0 0 1.25 KB
#3300 CallElasticsearch net472 2.45μs 0.721ns 2.5ns 0.188 0 0 1.19 KB
#3300 CallElasticsearch netcoreapp3.1 1.58μs 0.705ns 2.73ns 0.0151 0 0 1.13 KB
#3300 CallElasticsearchAsync net472 2.61μs 3.52ns 13.6ns 0.209 0 0 1.32 KB
#3300 CallElasticsearchAsync netcoreapp3.1 1.62μs 0.336ns 1.26ns 0.017 0 0 1.25 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.82μs 1.01ns 3.78ns 0.23 0 0 1.45 KB
master ExecuteAsync netcoreapp3.1 1.75μs 0.496ns 1.92ns 0.0185 0 0 1.38 KB
#3300 ExecuteAsync net472 2.79μs 1.68ns 6.49ns 0.23 0 0 1.45 KB
#3300 ExecuteAsync netcoreapp3.1 1.81μs 0.496ns 1.86ns 0.0189 0 0 1.38 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.92μs 1.57ns 5.87ns 0.444 0 0 2.8 KB
master SendAsync netcoreapp3.1 3.75μs 1.58ns 5.69ns 0.0357 0 0 2.63 KB
#3300 SendAsync net472 5.89μs 2.8ns 10.5ns 0.445 0 0 2.8 KB
#3300 SendAsync netcoreapp3.1 3.77μs 2.37ns 8.89ns 0.0364 0 0 2.63 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.26μs 2.1ns 7.87ns 0.298 0 0 1.88 KB
master EnrichedLog netcoreapp3.1 2.52μs 1.17ns 4.4ns 0.0267 0 0 1.91 KB
#3300 EnrichedLog net472 3.15μs 4.53ns 17.6ns 0.297 0 0 1.88 KB
#3300 EnrichedLog netcoreapp3.1 2.5μs 0.801ns 3.1ns 0.0254 0 0 1.91 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 153μs 156ns 604ns 0.694 0.231 0 4.72 KB
master EnrichedLog netcoreapp3.1 118μs 239ns 925ns 0.0591 0 0 4.55 KB
#3300 EnrichedLog net472 151μs 130ns 503ns 0.677 0.226 0 4.72 KB
#3300 EnrichedLog netcoreapp3.1 116μs 193ns 746ns 0.0585 0 0 4.55 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.77μs 1.99ns 7.45ns 0.58 0.00281 0 3.65 KB
master EnrichedLog netcoreapp3.1 4.72μs 2.21ns 7.95ns 0.0542 0 0 3.98 KB
#3300 EnrichedLog net472 5.7μs 3.26ns 12.2ns 0.578 0.00283 0 3.65 KB
#3300 EnrichedLog netcoreapp3.1 4.79μs 2.05ns 7.68ns 0.0547 0 0 3.98 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.29μs 2.45ns 9.49ns 0.223 0 0 1.4 KB
master SendReceive netcoreapp3.1 1.79μs 2.01ns 7.54ns 0.018 0 0 1.35 KB
#3300 SendReceive net472 2.28μs 2.08ns 8.06ns 0.222 0 0 1.4 KB
#3300 SendReceive netcoreapp3.1 1.83μs 0.772ns 2.99ns 0.0183 0 0 1.35 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.2μs 1.99ns 7.72ns 0.363 0 0 2.3 KB
master EnrichedLog netcoreapp3.1 4.3μs 2ns 7.74ns 0.0237 0 0 1.86 KB
#3300 EnrichedLog net472 5.08μs 1.25ns 4.84ns 0.364 0 0 2.3 KB
#3300 EnrichedLog netcoreapp3.1 4.17μs 1.5ns 5.8ns 0.025 0 0 1.86 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.15μs 0.271ns 1.01ns 0.134 0 0 842 B
master StartFinishSpan netcoreapp3.1 942ns 0.418ns 1.62ns 0.0109 0 0 792 B
master StartFinishScope net472 1.39μs 0.6ns 2.24ns 0.147 0 0 923 B
master StartFinishScope netcoreapp3.1 1.06μs 0.717ns 2.78ns 0.0122 0 0 912 B
#3300 StartFinishSpan net472 1.13μs 0.412ns 1.54ns 0.134 0 0 842 B
#3300 StartFinishSpan netcoreapp3.1 907ns 0.399ns 1.55ns 0.0105 0 0 792 B
#3300 StartFinishScope net472 1.36μs 0.549ns 2.13ns 0.147 0 0 923 B
#3300 StartFinishScope netcoreapp3.1 1.13μs 0.464ns 1.74ns 0.0121 0 0 912 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.54μs 0.414ns 1.49ns 0.146 0 0 923 B
master RunOnMethodBegin netcoreapp3.1 1.17μs 0.474ns 1.71ns 0.0123 0 0 912 B
#3300 RunOnMethodBegin net472 1.55μs 3.91ns 15.2ns 0.146 0 0 923 B
#3300 RunOnMethodBegin netcoreapp3.1 1.2μs 0.419ns 1.62ns 0.0125 0 0 912 B

@andrewlock

andrewlock commented Oct 12, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

✔️ Merging #3300 into master will not change line coverage
✔️ Merging #3300 into master will not change branch coverage
✔️ Merging #3300 into master will not change complexity

master #3300 Change
Lines 19367 / 26705 19397 / 26705
Lines % 73% 73% 0% ✔️
Branches 11527 / 16615 11541 / 16615
Branches % 69% 69% 0% ✔️
Complexity 17944 17944 0 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3300 Change
Lines % 73% 73% 0% ✔️
Branches % 69% 69% 0% ✔️
Complexity 17944 17944 0 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change

View the full reports for further details:

@pierotibou
pierotibou merged commit 20a93ee into master Oct 12, 2022
@pierotibou
pierotibou deleted the bot/test-package-versions-bump branch October 12, 2022 12:07
@github-actions github-actions Bot added this to the vNext milestone Oct 12, 2022
@anna-git anna-git added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes
@pierotibou pierotibou pierotibou approved these changes

Assignees

No one assigned

Labels

area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)

Projects

None yet

Milestone

2.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @pierotibou @anna-git