Skip to content

[Profiler] Sample allocation and contention profilers#3268

Merged
chrisnas merged 11 commits into
masterfrom
chrisnas/sample_allocations_contention
Oct 12, 2022
Merged

[Profiler] Sample allocation and contention profilers#3268
chrisnas merged 11 commits into
masterfrom
chrisnas/sample_allocations_contention

Conversation

@chrisnas

Copy link
Copy Markdown
Contributor

Summary of changes

Sample allocation and contention events to reduce performance impacts

Reason for change

CPU consumption was too high for both allocation and contention profiling

Implementation details

Reuse the same sampling algorithm used by exception profiling

Test coverage

Other details

@chrisnas
chrisnas marked this pull request as ready for review September 27, 2022 18:23
@chrisnas
chrisnas requested a review from a team as a code owner September 27, 2022 18:23
@github-actions github-actions Bot added the area:profiler Issues related to the continous-profiler label Sep 27, 2022
Comment thread profiler/src/ProfilerEngine/Datadog.Profiler.Native/GroupSampler.h Outdated
Comment thread profiler/src/ProfilerEngine/Datadog.Profiler.Native/GenericSampler.cpp Outdated
Comment thread profiler/src/ProfilerEngine/Datadog.Profiler.Native/GenericSampler.cpp Outdated
Comment thread profiler/src/ProfilerEngine/Datadog.Profiler.Native/GenericSampler.h Outdated
Comment thread profiler/src/ProfilerEngine/Datadog.Profiler.Native/GroupSampler.h Outdated
Comment thread profiler/src/ProfilerEngine/Datadog.Profiler.Native/AllocationsProvider.cpp Outdated
Comment thread profiler/src/ProfilerEngine/Datadog.Profiler.Native/ContentionProvider.cpp Outdated
Comment thread profiler/src/ProfilerEngine/Datadog.Profiler.Native/ExceptionsProvider.cpp Outdated

@gleocadie gleocadie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisnas
chrisnas merged commit 19e1f18 into master Oct 12, 2022
@chrisnas
chrisnas deleted the chrisnas/sample_allocations_contention branch October 12, 2022 08:10
@github-actions github-actions Bot added this to the vNext milestone Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:profiler Issues related to the continous-profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants