Update the list of expected file changes when doing a version bump#3259
Merged
andrewlock merged 1 commit intoSep 26, 2022
Merged
Conversation
#3147 updated the native loader to set the version correctly. That means we expect these two files to change when we do a version bump
pierotibou
approved these changes
Sep 26, 2022
andrewlock
deleted the
andrew/add-missing-expected-version-change-files
branch
September 26, 2022 13:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
#3147 updated the native loader to set the version correctly. That means we expect these two files to change when we do a version bump (e.g. as in #3258).
Implementation details
Add the missing files to the list