Skip to content

[Version Bump] 2.16.0#3258

Merged
robertpi merged 1 commit into
masterfrom
version-bump-2.16.0
Sep 26, 2022
Merged

[Version Bump] 2.16.0#3258
robertpi merged 1 commit into
masterfrom
version-bump-2.16.0

Conversation

@github-actions

@github-actions github-actions Bot commented Sep 26, 2022

Copy link
Copy Markdown
Contributor

The following files were found to be modified. Confirm that these changes were expected (for example, changes to files in the MSI project are expected if our dependencies have changed).

  • shared/src/Datadog.Trace.ClrProfiler.Native/CMakeLists.txt
  • shared/src/Datadog.Trace.ClrProfiler.Native/Resource.rc

The following files were found to be modified (as expected)

  • docs/CHANGELOG.md
  • .github/scripts/package_and_deploy.sh
  • profiler/src/ProfilerEngine/Datadog.Profiler.Native.Linux/CMakeLists.txt
  • profiler/src/ProfilerEngine/Datadog.Profiler.Native.Windows/Resource.rc
  • profiler/src/ProfilerEngine/Datadog.Profiler.Native/dd_profiler_version.h
  • profiler/src/ProfilerEngine/ProductVersion.props
  • shared/src/msi-installer/WindowsInstaller.wixproj
  • tracer/build/_build/Build.cs
  • tracer/samples/AutomaticTraceIdInjection/MicrosoftExtensionsExample/MicrosoftExtensionsExample.csproj
  • tracer/samples/AutomaticTraceIdInjection/Log4NetExample/Log4NetExample.csproj
  • tracer/samples/AutomaticTraceIdInjection/NLog40Example/NLog40Example.csproj
  • tracer/samples/AutomaticTraceIdInjection/NLog45Example/NLog45Example.csproj
  • tracer/samples/AutomaticTraceIdInjection/NLog46Example/NLog46Example.csproj
  • tracer/samples/AutomaticTraceIdInjection/SerilogExample/SerilogExample.csproj
  • tracer/samples/ConsoleApp/Alpine3.10.dockerfile
  • tracer/samples/ConsoleApp/Alpine3.9.dockerfile
  • tracer/samples/ConsoleApp/Debian.dockerfile
  • tracer/samples/WindowsContainer/Dockerfile
  • tracer/src/Datadog.Monitoring.Distribution/Datadog.Monitoring.Distribution.csproj
  • tracer/src/Datadog.Trace.AspNet/Datadog.Trace.AspNet.csproj
  • tracer/src/Datadog.Trace.ClrProfiler.Managed.Loader/Datadog.Trace.ClrProfiler.Managed.Loader.csproj
  • tracer/src/Datadog.Trace.ClrProfiler.Managed.Loader/Startup.cs
  • tracer/src/Datadog.Tracer.Native/CMakeLists.txt
  • tracer/src/Datadog.Tracer.Native/dd_profiler_constants.h
  • tracer/src/Datadog.Tracer.Native/Resource.rc
  • tracer/src/Datadog.Tracer.Native/version.h
  • tracer/src/Datadog.Trace.MSBuild/Datadog.Trace.MSBuild.csproj
  • tracer/src/Datadog.Trace.OpenTracing/Datadog.Trace.OpenTracing.csproj
  • tracer/src/Datadog.Trace.Tools.Runner/Datadog.Trace.Tools.Runner.csproj
  • tracer/src/Datadog.Trace/Datadog.Trace.csproj
  • tracer/src/Datadog.Trace/TracerConstants.cs
  • tracer/tools/PipelineMonitor/PipelineMonitor.csproj

@DataDog/apm-dotnet

@github-actions
github-actions Bot requested review from a team as code owners September 26, 2022 11:46
andrewlock
andrewlock approved these changes Sep 26, 2022
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we should add those new files to the expected files. I'll do that

@andrewlock andrewlock mentioned this pull request Sep 26, 2022
Merged
@andrewlock

andrewlock commented Sep 26, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #3258 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.113
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 712μs 542ns 2.03μs 0.357 0 0 3.18 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 462μs 164ns 634ns 0 0 0 2.58 KB
#3258 WriteAndFlushEnrichedTraces net472 718μs 525ns 2.03μs 0.357 0 0 3.18 KB
#3258 WriteAndFlushEnrichedTraces netcoreapp3.1 466μs 244ns 946ns 0 0 0 2.58 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 195ns 0.1ns 0.375ns 0.0676 0 0 425 B
master AllCycleSimpleBody netcoreapp3.1 254ns 0.27ns 1.05ns 0.00588 0 0 424 B
master AllCycleMoreComplexBody net472 195ns 0.238ns 0.891ns 0.0637 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 263ns 0.196ns 0.735ns 0.00543 0 0 400 B
master BodyExtractorSimpleBody net472 270ns 0.198ns 0.742ns 0.0574 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 236ns 0.132ns 0.493ns 0.0037 0 0 272 B
master BodyExtractorMoreComplexBody net472 16.1μs 13.4ns 51.8ns 1.21 0.016 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 12.4μs 4.04ns 14.6ns 0.0868 0 0 6.75 KB
#3258 AllCycleSimpleBody net472 197ns 0.155ns 0.6ns 0.0675 0 0 425 B
#3258 AllCycleSimpleBody netcoreapp3.1 256ns 0.136ns 0.51ns 0.00589 0 0 424 B
#3258 AllCycleMoreComplexBody net472 194ns 0.199ns 0.717ns 0.0637 0 0 401 B
#3258 AllCycleMoreComplexBody netcoreapp3.1 251ns 0.204ns 0.79ns 0.00542 0 0 400 B
#3258 BodyExtractorSimpleBody net472 280ns 0.249ns 0.965ns 0.0573 0 0 361 B
#3258 BodyExtractorSimpleBody netcoreapp3.1 240ns 0.1ns 0.388ns 0.00362 0 0 272 B
#3258 BodyExtractorMoreComplexBody net472 16μs 12.2ns 47.2ns 1.21 0.016 0 7.62 KB
#3258 BodyExtractorMoreComplexBody netcoreapp3.1 12.6μs 6.15ns 23.8ns 0.0884 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 180μs 135ns 505ns 0.269 0 0 20.58 KB
#3258 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3258 SendRequest netcoreapp3.1 180μs 203ns 787ns 0.271 0 0 20.58 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.91μs 0.808ns 2.91ns 0.15 0.000943 0 947 B
master ExecuteNonQuery netcoreapp3.1 1.44μs 0.335ns 1.3ns 0.0126 0 0 936 B
#3258 ExecuteNonQuery net472 1.85μs 0.726ns 2.72ns 0.15 0.000929 0 947 B
#3258 ExecuteNonQuery netcoreapp3.1 1.49μs 0.728ns 2.82ns 0.0126 0 0 936 B
Benchmarks.Trace.ElasticsearchBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #3258

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ElasticsearchBenchmark.CallElasticsearch‑netcoreapp3.1 1.113 1,479.69 1,647.39

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.39μs 1.06ns 3.97ns 0.183 0 0 1.16 KB
master CallElasticsearch netcoreapp3.1 1.48μs 0.898ns 3.48ns 0.0148 0 0 1.1 KB
master CallElasticsearchAsync net472 2.53μs 1.74ns 6.75ns 0.204 0 0 1.29 KB
master CallElasticsearchAsync netcoreapp3.1 1.68μs 1.14ns 4.41ns 0.0167 0 0 1.22 KB
#3258 CallElasticsearch net472 2.48μs 0.83ns 3.21ns 0.183 0 0 1.16 KB
#3258 CallElasticsearch netcoreapp3.1 1.65μs 0.878ns 3.4ns 0.0149 0 0 1.1 KB
#3258 CallElasticsearchAsync net472 2.65μs 1.37ns 4.94ns 0.204 0 0 1.29 KB
#3258 CallElasticsearchAsync netcoreapp3.1 1.59μs 0.312ns 1.21ns 0.0168 0 0 1.22 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.87μs 1.96ns 7.58ns 0.225 0 0 1.42 KB
master ExecuteAsync netcoreapp3.1 1.75μs 0.908ns 3.52ns 0.0174 0 0 1.34 KB
#3258 ExecuteAsync net472 2.7μs 1.1ns 4.28ns 0.225 0 0 1.42 KB
#3258 ExecuteAsync netcoreapp3.1 1.79μs 0.575ns 2.23ns 0.018 0 0 1.34 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.85μs 1.56ns 6.05ns 0.439 0 0 2.77 KB
master SendAsync netcoreapp3.1 3.6μs 1.93ns 6.95ns 0.0357 0 0 2.6 KB
#3258 SendAsync net472 5.9μs 1.02ns 3.81ns 0.44 0 0 2.77 KB
#3258 SendAsync netcoreapp3.1 3.74μs 1.19ns 4.62ns 0.0353 0 0 2.6 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.22μs 2.57ns 9.95ns 0.287 0 0 1.81 KB
master EnrichedLog netcoreapp3.1 2.58μs 1.22ns 4.72ns 0.0245 0 0 1.85 KB
#3258 EnrichedLog net472 3.28μs 5.8ns 22.5ns 0.287 0 0 1.81 KB
#3258 EnrichedLog netcoreapp3.1 2.54μs 0.851ns 3.07ns 0.0255 0 0 1.85 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 153μs 108ns 417ns 0.683 0.228 0 4.65 KB
master EnrichedLog netcoreapp3.1 117μs 77.8ns 302ns 0 0 0 4.49 KB
#3258 EnrichedLog net472 152μs 135ns 523ns 0.678 0.226 0 4.65 KB
#3258 EnrichedLog netcoreapp3.1 116μs 176ns 681ns 0.0576 0 0 4.49 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.96μs 1.4ns 5.44ns 0.569 0.00298 0 3.59 KB
master EnrichedLog netcoreapp3.1 4.69μs 1.44ns 4.97ns 0.054 0 0 3.91 KB
#3258 EnrichedLog net472 5.93μs 1.74ns 6.51ns 0.567 0.00295 0 3.59 KB
#3258 EnrichedLog netcoreapp3.1 4.62μs 1.47ns 5.3ns 0.0533 0 0 3.91 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.32μs 1.88ns 7.05ns 0.217 0 0 1.37 KB
master SendReceive netcoreapp3.1 1.85μs 0.773ns 3ns 0.0175 0 0 1.32 KB
#3258 SendReceive net472 2.39μs 5.83ns 22.6ns 0.218 0 0 1.37 KB
#3258 SendReceive netcoreapp3.1 1.76μs 1.78ns 6.68ns 0.0177 0 0 1.32 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.13μs 1.94ns 7.27ns 0.353 0 0 2.23 KB
master EnrichedLog netcoreapp3.1 4.43μs 1.75ns 6.77ns 0.0245 0 0 1.8 KB
#3258 EnrichedLog net472 5μs 1.79ns 6.71ns 0.353 0 0 2.23 KB
#3258 EnrichedLog netcoreapp3.1 4.34μs 1.98ns 7.4ns 0.0238 0 0 1.8 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.12μs 0.67ns 2.51ns 0.128 0 0 810 B
master StartFinishSpan netcoreapp3.1 940ns 0.419ns 1.57ns 0.0102 0 0 760 B
master StartFinishScope net472 1.37μs 0.856ns 3.31ns 0.141 0 0 891 B
master StartFinishScope netcoreapp3.1 1.11μs 0.261ns 0.978ns 0.0117 0 0 880 B
#3258 StartFinishSpan net472 1.16μs 0.511ns 1.98ns 0.129 0 0 810 B
#3258 StartFinishSpan netcoreapp3.1 916ns 0.231ns 0.896ns 0.0105 0 0 760 B
#3258 StartFinishScope net472 1.36μs 0.183ns 0.661ns 0.141 0 0 891 B
#3258 StartFinishScope netcoreapp3.1 1.07μs 0.35ns 1.31ns 0.0118 0 0 880 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.52μs 0.678ns 2.44ns 0.141 0 0 891 B
master RunOnMethodBegin netcoreapp3.1 1.21μs 0.412ns 1.54ns 0.0121 0 0 880 B
#3258 RunOnMethodBegin net472 1.52μs 0.482ns 1.87ns 0.141 0 0 891 B
#3258 RunOnMethodBegin netcoreapp3.1 1.14μs 0.448ns 1.74ns 0.0119 0 0 880 B

gleocadie
gleocadie approved these changes Sep 26, 2022
View reviewed changes

@gleocadie gleocadie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock

andrewlock commented Sep 26, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

✔️ Merging #3258 into master will not change line coverage
✔️ Merging #3258 into master will not change branch coverage
✔️ Merging #3258 into master will not change complexity

master #3258 Change
Lines 17837 / 24970 17868 / 24970
Lines % 71% 72% 0% ✔️
Branches 10430 / 15316 10450 / 15316
Branches % 68% 68% 0% ✔️
Complexity 16547 16547 0 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3258 Change
Lines % 71% 72% 0% ✔️
Branches % 68% 68% 0% ✔️
Complexity 16547 16547 0 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change

View the full reports for further details:

@robertpi
robertpi merged commit e5a31b6 into master Sep 26, 2022
@robertpi
robertpi deleted the version-bump-2.16.0 branch September 26, 2022 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertpi robertpi robertpi approved these changes
@gleocadie gleocadie gleocadie approved these changes
@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @robertpi @gleocadie