Skip to content

[Snapshots] Diff on base branch#3250

Merged
pierotibou merged 4 commits into
masterfrom
pierre/diff-on-merge-root
Sep 23, 2022
Merged

[Snapshots] Diff on base branch#3250
pierotibou merged 4 commits into
masterfrom
pierre/diff-on-merge-root

Conversation

@pierotibou

@pierotibou pierotibou commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

Summary of changes

  • Doing the snapshots diff on base branch.
  • Increased the scope of the diff to debugger and smoke_tests (for a file to be considered in the diff, they have to be in a folder containing snapshots)
  • Doing the diff only on modified files

Test coverage

Tested with a child PR.

@pierotibou
pierotibou requested review from a team as code owners September 22, 2022 09:49
@github-actions github-actions Bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Sep 22, 2022

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, one suggestion for an improvement

Comment thread tracer/build/_build/Build.GitHub.cs Outdated
@pierotibou
pierotibou merged commit d176335 into master Sep 23, 2022
@pierotibou
pierotibou deleted the pierre/diff-on-merge-root branch September 23, 2022 09:04
@github-actions github-actions Bot added this to the vNext milestone Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants