Skip to content

Disable async probe#3248

Merged
OmerRaviv merged 4 commits into
masterfrom
dudik/disable-async-probes
Sep 24, 2022
Merged

Disable async probe#3248
OmerRaviv merged 4 commits into
masterfrom
dudik/disable-async-probes

Conversation

@dudikeleti

@dudikeleti dudikeleti commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

Summary of changes

We are disabling async probes feature for now because we have an issue in certain case when we customer code is running in optimize build

@dudikeleti
dudikeleti requested a review from a team as a code owner September 22, 2022 08:19
@andrewlock

This comment has been minimized.

Sign in to view
OmerRaviv
OmerRaviv approved these changes Sep 22, 2022
View reviewed changes

@OmerRaviv OmerRaviv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Hoping we can bring this feature back soon :)

@OmerRaviv
OmerRaviv requested a review from a team as a code owner September 23, 2022 14:16
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@OmerRaviv
OmerRaviv force-pushed the dudik/disable-async-probes branch from af094ca to 56837c7 Compare September 23, 2022 22:09
@andrewlock

andrewlock commented Sep 23, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #3248 compared to master:

  • All benchmarks have the same speed
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 733μs 286ns 1.03μs 0.359 0 0 3.18 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 465μs 266ns 995ns 0 0 0 2.58 KB
#3248 WriteAndFlushEnrichedTraces net472 720μs 407ns 1.52μs 0.355 0 0 3.18 KB
#3248 WriteAndFlushEnrichedTraces netcoreapp3.1 468μs 81.3ns 304ns 0 0 0 2.58 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 197ns 0.0454ns 0.164ns 0.0675 0 0 425 B
master AllCycleSimpleBody netcoreapp3.1 254ns 0.204ns 0.762ns 0.00575 0 0 424 B
master AllCycleMoreComplexBody net472 198ns 0.0686ns 0.257ns 0.0637 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 251ns 0.374ns 1.45ns 0.00542 0 0 400 B
master BodyExtractorSimpleBody net472 271ns 0.224ns 0.837ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 238ns 0.0828ns 0.287ns 0.00365 0 0 272 B
master BodyExtractorMoreComplexBody net472 15.9μs 10.7ns 41.5ns 1.21 0.0158 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 12.8μs 5.95ns 23ns 0.0891 0 0 6.75 KB
#3248 AllCycleSimpleBody net472 195ns 0.198ns 0.768ns 0.0675 0 0 425 B
#3248 AllCycleSimpleBody netcoreapp3.1 257ns 0.142ns 0.551ns 0.00581 0 0 424 B
#3248 AllCycleMoreComplexBody net472 194ns 0.152ns 0.57ns 0.0638 0 0 401 B
#3248 AllCycleMoreComplexBody netcoreapp3.1 249ns 0.121ns 0.452ns 0.00551 0 0 400 B
#3248 BodyExtractorSimpleBody net472 272ns 0.375ns 1.45ns 0.0574 0 0 361 B
#3248 BodyExtractorSimpleBody netcoreapp3.1 226ns 0.108ns 0.42ns 0.00376 0 0 272 B
#3248 BodyExtractorMoreComplexBody net472 15.8μs 6.13ns 23.8ns 1.21 0.0159 0 7.62 KB
#3248 BodyExtractorMoreComplexBody netcoreapp3.1 12.7μs 7.46ns 26.9ns 0.0887 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 182μs 237ns 888ns 0.182 0 0 20.58 KB
#3248 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3248 SendRequest netcoreapp3.1 179μs 150ns 579ns 0.178 0 0 20.58 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.97μs 0.682ns 2.55ns 0.15 0.000988 0 947 B
master ExecuteNonQuery netcoreapp3.1 1.4μs 0.623ns 2.33ns 0.0127 0 0 936 B
#3248 ExecuteNonQuery net472 1.81μs 0.618ns 2.39ns 0.15 0.000917 0 947 B
#3248 ExecuteNonQuery netcoreapp3.1 1.49μs 0.471ns 1.76ns 0.0127 0 0 936 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.43μs 7.32ns 27.4ns 0.184 0 0 1.16 KB
master CallElasticsearch netcoreapp3.1 1.56μs 1.21ns 4.7ns 0.0149 0 0 1.1 KB
master CallElasticsearchAsync net472 2.68μs 1.35ns 5.25ns 0.204 0 0 1.29 KB
master CallElasticsearchAsync netcoreapp3.1 1.7μs 0.444ns 1.6ns 0.0162 0 0 1.22 KB
#3248 CallElasticsearch net472 2.5μs 2.13ns 7.96ns 0.183 0 0 1.16 KB
#3248 CallElasticsearch netcoreapp3.1 1.58μs 0.426ns 1.53ns 0.0148 0 0 1.1 KB
#3248 CallElasticsearchAsync net472 2.62μs 1.95ns 7.54ns 0.205 0 0 1.29 KB
#3248 CallElasticsearchAsync netcoreapp3.1 1.58μs 0.811ns 2.92ns 0.0165 0 0 1.22 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.78μs 2.02ns 7.82ns 0.225 0 0 1.42 KB
master ExecuteAsync netcoreapp3.1 1.72μs 0.59ns 2.28ns 0.0181 0 0 1.34 KB
#3248 ExecuteAsync net472 2.82μs 0.745ns 2.89ns 0.225 0 0 1.42 KB
#3248 ExecuteAsync netcoreapp3.1 1.8μs 0.537ns 2.01ns 0.018 0 0 1.34 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.85μs 1.39ns 5.2ns 0.438 0 0 2.77 KB
master SendAsync netcoreapp3.1 3.75μs 2.77ns 9.99ns 0.0358 0 0 2.6 KB
#3248 SendAsync net472 5.85μs 1.37ns 5.14ns 0.437 0 0 2.77 KB
#3248 SendAsync netcoreapp3.1 3.7μs 3.04ns 11.4ns 0.0352 0 0 2.6 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.25μs 2.16ns 8.37ns 0.288 0 0 1.81 KB
master EnrichedLog netcoreapp3.1 2.38μs 1.07ns 4.13ns 0.0249 0 0 1.85 KB
#3248 EnrichedLog net472 2.98μs 2.5ns 9ns 0.287 0 0 1.81 KB
#3248 EnrichedLog netcoreapp3.1 2.5μs 1ns 3.74ns 0.0251 0 0 1.85 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 152μs 160ns 621ns 0.689 0.23 0 4.65 KB
master EnrichedLog netcoreapp3.1 116μs 202ns 782ns 0.0585 0 0 4.49 KB
#3248 EnrichedLog net472 152μs 116ns 450ns 0.685 0.228 0 4.65 KB
#3248 EnrichedLog netcoreapp3.1 118μs 137ns 531ns 0.0589 0 0 4.49 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.88μs 1.63ns 6.33ns 0.569 0.00295 0 3.59 KB
master EnrichedLog netcoreapp3.1 4.4μs 1.53ns 5.73ns 0.0528 0 0 3.91 KB
#3248 EnrichedLog net472 5.81μs 2.77ns 10.4ns 0.568 0.0029 0 3.59 KB
#3248 EnrichedLog netcoreapp3.1 4.43μs 2.06ns 7.72ns 0.0531 0 0 3.91 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.24μs 1.29ns 5ns 0.218 0 0 1.37 KB
master SendReceive netcoreapp3.1 1.88μs 0.744ns 2.79ns 0.0179 0 0 1.32 KB
#3248 SendReceive net472 2.21μs 2.02ns 7.57ns 0.218 0 0 1.37 KB
#3248 SendReceive netcoreapp3.1 1.81μs 0.751ns 2.91ns 0.0173 0 0 1.32 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.04μs 1.25ns 4.66ns 0.353 0 0 2.23 KB
master EnrichedLog netcoreapp3.1 4.33μs 1.17ns 4.4ns 0.024 0 0 1.8 KB
#3248 EnrichedLog net472 4.91μs 1.49ns 5.58ns 0.353 0 0 2.23 KB
#3248 EnrichedLog netcoreapp3.1 4.29μs 1.79ns 6.92ns 0.0237 0 0 1.8 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.14μs 0.501ns 1.87ns 0.129 0 0 810 B
master StartFinishSpan netcoreapp3.1 973ns 0.375ns 1.35ns 0.0102 0 0 760 B
master StartFinishScope net472 1.41μs 0.922ns 3.57ns 0.141 0 0 891 B
master StartFinishScope netcoreapp3.1 1.07μs 0.343ns 1.33ns 0.0118 0 0 880 B
#3248 StartFinishSpan net472 1.22μs 0.258ns 0.963ns 0.128 0 0 810 B
#3248 StartFinishSpan netcoreapp3.1 957ns 0.411ns 1.59ns 0.0105 0 0 760 B
#3248 StartFinishScope net472 1.39μs 0.697ns 2.7ns 0.141 0 0 891 B
#3248 StartFinishScope netcoreapp3.1 1.04μs 0.2ns 0.748ns 0.0119 0 0 880 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.47μs 0.357ns 1.38ns 0.141 0 0 891 B
master RunOnMethodBegin netcoreapp3.1 1.16μs 0.815ns 3.05ns 0.0116 0 0 880 B
#3248 RunOnMethodBegin net472 1.43μs 0.868ns 3.36ns 0.141 0 0 891 B
#3248 RunOnMethodBegin netcoreapp3.1 1.13μs 0.323ns 1.21ns 0.012 0 0 880 B

@andrewlock

andrewlock commented Sep 23, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

⚠️ Merging #3248 into master will will decrease line coverage by 1%
⚠️ Merging #3248 into master will will decrease branch coverage by 1%
✔️ Merging #3248 into master will not change complexity

master #3248 Change
Lines 18078 / 24970 17845 / 24970
Lines % 72% 71% -1% ⚠️
Branches 10549 / 15316 10433 / 15316
Branches % 69% 68% -1% ⚠️
Complexity 16547 16547 0 ✔️

View the full report for further details:

Datadog.Trace Breakdown ⚠️

master #3248 Change
Lines % 72% 71% -1% ⚠️
Branches % 69% 68% -1% ⚠️
Complexity 16547 16547 0 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Debugger.Instrumentation.AsyncMethodDebuggerInvoker -87% ⛔ -65% ⛔ 0 ✔️
Datadog.Trace.Debugger.Helpers.AsyncHelper -84% ⛔ -68% ⛔ 0 ✔️
Datadog.Trace.Debugger.Instrumentation.AsyncMethodDebuggerState -50% ⛔ 0% ✔️ 0 ✔️
Datadog.Trace.Debugger.Snapshots.ExceptionSnapshotSerializerFieldsAndPropsSelector -44% ⛔ 0% ✔️ 0 ✔️
Datadog.Trace.Debugger.Instrumentation.MethodMetadataInfoFactory -27% ⛔ 0% ✔️ 0 ✔️

View the full reports for further details:

@OmerRaviv
OmerRaviv merged commit ca92d31 into master Sep 24, 2022
@OmerRaviv
OmerRaviv deleted the dudik/disable-async-probes branch September 24, 2022 00:03
@github-actions github-actions Bot added this to the vNext milestone Sep 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OmerRaviv OmerRaviv OmerRaviv approved these changes
@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@dudikeleti @andrewlock @OmerRaviv