Skip to content

Add manual repo clone to unit_tests_macos#3232

Merged
andrewlock merged 1 commit into
masterfrom
andrew/fix-macos-unit-tests
Sep 20, 2022
Merged

Add manual repo clone to unit_tests_macos#3232
andrewlock merged 1 commit into
masterfrom
andrew/fix-macos-unit-tests

Conversation

@andrewlock

@andrewlock andrewlock commented Sep 20, 2022

Copy link
Copy Markdown
Member

Summary of changes

Add steps/clone-repo.yml step to unit_tests_macos stage

Reason for change

Without this, we can get issues with concurrent merges to master. All other stages have it, this one must have been missed.

Implementation details

Add the missing stage

Test coverage

Hopefully the build passes

Other details

N/A

@andrewlock
Add manual repo clone to unit_tests_macos
2041a36 
Use the steps/clone-repo.yml to avoid problems with concurrent merges to master
@andrewlock andrewlock added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Sep 20, 2022
@andrewlock
andrewlock requested review from a team as code owners September 20, 2022 07:40
@andrewlock

andrewlock commented Sep 20, 2022

Copy link
Copy Markdown
Member Author

Benchmarks Report 🐌

Benchmarks for #3232 compared to master:

  • All benchmarks have the same speed
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 720μs 202ns 756ns 0.359 0 0 3.18 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 472μs 193ns 723ns 0 0 0 2.58 KB
#3232 WriteAndFlushEnrichedTraces net472 714μs 607ns 2.27μs 0.357 0 0 3.18 KB
#3232 WriteAndFlushEnrichedTraces netcoreapp3.1 459μs 147ns 567ns 0 0 0 2.58 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 204ns 0.289ns 1.08ns 0.0675 0 0 425 B
master AllCycleSimpleBody netcoreapp3.1 235ns 0.198ns 0.769ns 0.0059 0 0 424 B
master AllCycleMoreComplexBody net472 182ns 0.268ns 1.04ns 0.0637 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 235ns 0.333ns 1.25ns 0.00543 0 0 400 B
master BodyExtractorSimpleBody net472 257ns 0.437ns 1.69ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 223ns 0.381ns 1.48ns 0.00377 0 0 272 B
master BodyExtractorMoreComplexBody net472 14.4μs 11.7ns 45.3ns 1.21 0.0216 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 12.4μs 14.5ns 56.3ns 0.0923 0 0 6.75 KB
#3232 AllCycleSimpleBody net472 191ns 0.188ns 0.728ns 0.0676 0 0 425 B
#3232 AllCycleSimpleBody netcoreapp3.1 237ns 0.276ns 1.07ns 0.00581 0 0 424 B
#3232 AllCycleMoreComplexBody net472 180ns 0.181ns 0.701ns 0.0637 0 0 401 B
#3232 AllCycleMoreComplexBody netcoreapp3.1 235ns 0.0924ns 0.346ns 0.00545 0 0 400 B
#3232 BodyExtractorSimpleBody net472 262ns 0.247ns 0.956ns 0.0573 0 0 361 B
#3232 BodyExtractorSimpleBody netcoreapp3.1 213ns 0.166ns 0.575ns 0.00366 0 0 272 B
#3232 BodyExtractorMoreComplexBody net472 14.5μs 13.4ns 52ns 1.21 0.0218 0 7.62 KB
#3232 BodyExtractorMoreComplexBody netcoreapp3.1 12.2μs 14.2ns 53.3ns 0.0913 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 181μs 243ns 908ns 0.182 0 0 20.58 KB
#3232 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3232 SendRequest netcoreapp3.1 181μs 227ns 820ns 0.269 0 0 20.6 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.9μs 1.8ns 6.99ns 0.15 0.000935 0 947 B
master ExecuteNonQuery netcoreapp3.1 1.41μs 0.88ns 3.29ns 0.0127 0 0 936 B
#3232 ExecuteNonQuery net472 1.83μs 0.737ns 2.85ns 0.15 0.00092 0 947 B
#3232 ExecuteNonQuery netcoreapp3.1 1.43μs 0.501ns 1.94ns 0.0122 0 0 936 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.65μs 1ns 3.76ns 0.183 0 0 1.16 KB
master CallElasticsearch netcoreapp3.1 1.56μs 0.747ns 2.89ns 0.0148 0 0 1.1 KB
master CallElasticsearchAsync net472 2.7μs 1.91ns 7.39ns 0.205 0 0 1.29 KB
master CallElasticsearchAsync netcoreapp3.1 1.6μs 0.503ns 1.88ns 0.0168 0 0 1.22 KB
#3232 CallElasticsearch net472 2.72μs 1.73ns 6.69ns 0.183 0 0 1.16 KB
#3232 CallElasticsearch netcoreapp3.1 1.54μs 0.746ns 2.79ns 0.0146 0 0 1.1 KB
#3232 CallElasticsearchAsync net472 2.69μs 2.04ns 7.89ns 0.205 0 0 1.29 KB
#3232 CallElasticsearchAsync netcoreapp3.1 1.69μs 1.31ns 4.92ns 0.0167 0.000837 0 1.22 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.79μs 8.67ns 33.6ns 0.226 0 0 1.42 KB
master ExecuteAsync netcoreapp3.1 1.77μs 3.29ns 12.7ns 0.0183 0 0 1.34 KB
#3232 ExecuteAsync net472 2.77μs 5.54ns 21.4ns 0.225 0 0 1.42 KB
#3232 ExecuteAsync netcoreapp3.1 1.7μs 2.98ns 11.6ns 0.0183 0 0 1.34 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.78μs 9.2ns 33.2ns 0.438 0 0 2.77 KB
master SendAsync netcoreapp3.1 3.66μs 6.72ns 24.2ns 0.0349 0 0 2.6 KB
#3232 SendAsync net472 5.72μs 24.9ns 93.1ns 0.439 0 0 2.77 KB
#3232 SendAsync netcoreapp3.1 3.57μs 6.33ns 23.7ns 0.0356 0 0 2.6 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.17μs 2.66ns 10.3ns 0.287 0 0 1.81 KB
master EnrichedLog netcoreapp3.1 2.48μs 3.13ns 11.7ns 0.025 0 0 1.85 KB
#3232 EnrichedLog net472 3.16μs 2.57ns 9.97ns 0.288 0 0 1.81 KB
#3232 EnrichedLog netcoreapp3.1 2.48μs 0.883ns 3.3ns 0.0248 0 0 1.85 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 152μs 208ns 807ns 0.677 0.226 0 4.67 KB
master EnrichedLog netcoreapp3.1 116μs 100ns 388ns 0.0582 0 0 4.49 KB
#3232 EnrichedLog net472 153μs 91.3ns 342ns 0.689 0.23 0 4.66 KB
#3232 EnrichedLog netcoreapp3.1 116μs 232ns 900ns 0.0581 0 0 4.5 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.73μs 14.3ns 55.4ns 0.57 0.00285 0 3.59 KB
master EnrichedLog netcoreapp3.1 4.28μs 5.91ns 22.9ns 0.0533 0 0 3.91 KB
#3232 EnrichedLog net472 5.79μs 5.18ns 19.4ns 0.569 0.00288 0 3.59 KB
#3232 EnrichedLog netcoreapp3.1 4.47μs 8.24ns 30.8ns 0.0521 0 0 3.91 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.3μs 3.86ns 14.9ns 0.218 0 0 1.37 KB
master SendReceive netcoreapp3.1 1.79μs 0.695ns 2.69ns 0.0179 0 0 1.32 KB
#3232 SendReceive net472 2.3μs 1.62ns 6.27ns 0.218 0.00115 0 1.37 KB
#3232 SendReceive netcoreapp3.1 1.89μs 0.686ns 2.57ns 0.018 0 0 1.32 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.16μs 2.4ns 9ns 0.353 0.00257 0 2.23 KB
master EnrichedLog netcoreapp3.1 4.37μs 1.68ns 6.3ns 0.0239 0 0 1.8 KB
#3232 EnrichedLog net472 5.03μs 2.9ns 11.2ns 0.353 0 0 2.23 KB
#3232 EnrichedLog netcoreapp3.1 4.18μs 2ns 7.49ns 0.025 0 0 1.8 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.2μs 0.731ns 2.83ns 0.128 0 0 810 B
master StartFinishSpan netcoreapp3.1 944ns 0.361ns 1.35ns 0.0102 0 0 760 B
master StartFinishScope net472 1.43μs 0.981ns 3.8ns 0.141 0.000714 0 891 B
master StartFinishScope netcoreapp3.1 1.07μs 0.808ns 3.02ns 0.0118 0 0 880 B
#3232 StartFinishSpan net472 1.16μs 0.699ns 2.71ns 0.128 0 0 810 B
#3232 StartFinishSpan netcoreapp3.1 959ns 2.81ns 10.5ns 0.0104 0 0 760 B
#3232 StartFinishScope net472 1.43μs 0.791ns 2.96ns 0.141 0 0 891 B
#3232 StartFinishScope netcoreapp3.1 1.07μs 0.48ns 1.8ns 0.0124 0 0 880 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.51μs 1.34ns 4.84ns 0.141 0 0 891 B
master RunOnMethodBegin netcoreapp3.1 1.16μs 0.471ns 1.82ns 0.0116 0 0 880 B
#3232 RunOnMethodBegin net472 1.47μs 1.01ns 3.91ns 0.141 0 0 891 B
#3232 RunOnMethodBegin netcoreapp3.1 1.22μs 0.411ns 1.59ns 0.0116 0 0 880 B

@andrewlock

andrewlock commented Sep 20, 2022

Copy link
Copy Markdown
Member Author

Code Coverage Report 📊

✔️ Merging #3232 into master will not change line coverage
✔️ Merging #3232 into master will not change branch coverage
✔️ Merging #3232 into master will not change complexity

master #3232 Change
Lines 17945 / 24888 17963 / 24888
Lines % 72% 72% 0% ✔️
Branches 10462 / 15254 10468 / 15254
Branches % 69% 69% 0% ✔️
Complexity 16476 16476 0 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3232 Change
Lines % 72% 72% 0% ✔️
Branches % 69% 69% 0% ✔️
Complexity 16476 16476 0 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Ci.GitInfo 4% ✔️ 6% ✔️ 0 ✔️
Datadog.Trace.Activity.DiagnosticSourceEventListener 6% ✔️ 0% ✔️ 0 ✔️

View the full reports for further details:

@andrewlock
andrewlock merged commit 06088c5 into master Sep 20, 2022
@andrewlock
andrewlock deleted the andrew/fix-macos-unit-tests branch September 20, 2022 08:45
@github-actions github-actions Bot added this to the vNext milestone Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@robertpi robertpi robertpi approved these changes
@tonyredondo tonyredondo tonyredondo approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewlock @robertpi @tonyredondo