Fix WindowsContainer tracing sample#3208
Merged
Merged
Conversation
pierotibou
approved these changes
Sep 13, 2022
andrewlock
reviewed
Sep 13, 2022
|
|
||
| datadog-agent: | ||
| image: "gcr.io/datadoghq/agent:7" | ||
| image: "gcr.io/datadoghq/agent:latest" |
Member
There was a problem hiding this comment.
Just FYI, these images are synonymous, so not required 🙂
andrewlock
reviewed
Sep 13, 2022
| image: "gcr.io/datadoghq/agent:7" | ||
| image: "gcr.io/datadoghq/agent:latest" | ||
| environment: | ||
| DD_HOSTNAME: "windowscontainer-datadog-agent" |
Member
There was a problem hiding this comment.
These is the "real" issue - it's a recent requirement in the latest version of the agent. We should ensure that all other docker-compose files that use it similarly have a hostname, e.g.:
andrewlock
approved these changes
Sep 13, 2022
andrewlock
left a comment
andrewlock
left a comment
Member
There was a problem hiding this comment.
Good catch, this was a recent change to the agent to make DD_HOSTNAME required IIRC
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Fix the C# build error and make required changes for datadog-agent to start properly on the latest Windows 11. After the changes, I am able to see traces in Datadog after following the steps in the sample's
README.mdReason for change
Implementation details
Test coverage
Other details