Skip to content

[Debugger] Fix Debugger Method Probe Async Tests#3199

Merged
OmerRaviv merged 1 commit into
masterfrom
omerr/fix-async-tests
Sep 18, 2022
Merged

[Debugger] Fix Debugger Method Probe Async Tests#3199
OmerRaviv merged 1 commit into
masterfrom
omerr/fix-async-tests

Conversation

@OmerRaviv

@OmerRaviv OmerRaviv commented Sep 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Reason for change

Due to a typo (likely caused by a merge conflict) in #3079, the integration tests that were added in that PR did not execute and never actually ran in CI 😓. This PR addresses that typo and updates the verified file names that have since been changed.

@OmerRaviv
OmerRaviv requested a review from a team as a code owner September 11, 2022 06:56
@github-actions github-actions Bot added area:debugger area:tests unit tests, integration tests labels Sep 11, 2022
@OmerRaviv
OmerRaviv force-pushed the omerr/fix-async-tests branch from 7cb9984 to da875de Compare September 11, 2022 06:58
@andrewlock

This comment has been minimized.

Sign in to view
GreenMatan
GreenMatan approved these changes Sep 11, 2022
View reviewed changes

@GreenMatan GreenMatan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OmerRaviv
OmerRaviv force-pushed the omerr/fix-async-tests branch from da875de to 4146a08 Compare September 13, 2022 06:26
@andrewlock

This comment has been minimized.

Sign in to view
@OmerRaviv
OmerRaviv force-pushed the omerr/fix-async-tests branch from 4146a08 to c979aae Compare September 13, 2022 08:20
@andrewlock

This comment has been minimized.

Sign in to view
@OmerRaviv
OmerRaviv force-pushed the omerr/fix-async-tests branch from c979aae to 4b3824a Compare September 18, 2022 08:34
@andrewlock

andrewlock commented Sep 18, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #3199 compared to master:

  • All benchmarks have the same speed
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 717μs 348ns 1.3μs 0.357 0 0 3.18 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 465μs 197ns 763ns 0 0 0 2.59 KB
#3199 WriteAndFlushEnrichedTraces net472 718μs 565ns 2.11μs 0.357 0 0 3.18 KB
#3199 WriteAndFlushEnrichedTraces netcoreapp3.1 475μs 409ns 1.47μs 0 0 0 2.58 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 183ns 0.207ns 0.8ns 0.0675 0 0 425 B
master AllCycleSimpleBody netcoreapp3.1 238ns 0.167ns 0.604ns 0.00583 0 0 424 B
master AllCycleMoreComplexBody net472 178ns 0.146ns 0.566ns 0.0638 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 233ns 0.175ns 0.676ns 0.00551 0 0 400 B
master BodyExtractorSimpleBody net472 260ns 0.361ns 1.3ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 221ns 0.203ns 0.759ns 0.00369 0 0 272 B
master BodyExtractorMoreComplexBody net472 14.4μs 7.73ns 27.9ns 1.21 0.022 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 12.1μs 13.8ns 53.3ns 0.0903 0 0 6.75 KB
#3199 AllCycleSimpleBody net472 181ns 0.206ns 0.769ns 0.0675 0 0 425 B
#3199 AllCycleSimpleBody netcoreapp3.1 239ns 0.236ns 0.883ns 0.00574 0 0 424 B
#3199 AllCycleMoreComplexBody net472 179ns 0.169ns 0.654ns 0.0637 0 0 401 B
#3199 AllCycleMoreComplexBody netcoreapp3.1 233ns 0.166ns 0.642ns 0.00539 0 0 400 B
#3199 BodyExtractorSimpleBody net472 285ns 0.268ns 1.04ns 0.0574 0 0 361 B
#3199 BodyExtractorSimpleBody netcoreapp3.1 217ns 0.228ns 0.882ns 0.00373 0 0 272 B
#3199 BodyExtractorMoreComplexBody net472 14.7μs 18.6ns 69.6ns 1.21 0.0218 0 7.62 KB
#3199 BodyExtractorMoreComplexBody netcoreapp3.1 12.1μs 17.8ns 68.9ns 0.0911 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 180μs 191ns 740ns 0.181 0 0 20.58 KB
#3199 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3199 SendRequest netcoreapp3.1 182μs 185ns 715ns 0.182 0 0 20.59 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.88μs 0.672ns 2.51ns 0.15 0.000937 0 947 B
master ExecuteNonQuery netcoreapp3.1 1.45μs 0.771ns 2.99ns 0.013 0 0 936 B
#3199 ExecuteNonQuery net472 1.84μs 1.99ns 7.16ns 0.15 0 0 947 B
#3199 ExecuteNonQuery netcoreapp3.1 1.43μs 1.56ns 6.03ns 0.0128 0 0 936 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.68μs 1.68ns 6.51ns 0.182 0 0 1.16 KB
master CallElasticsearch netcoreapp3.1 1.55μs 1.15ns 4.45ns 0.0146 0 0 1.1 KB
master CallElasticsearchAsync net472 2.8μs 1.59ns 5.95ns 0.205 0 0 1.29 KB
master CallElasticsearchAsync netcoreapp3.1 1.62μs 0.852ns 3.19ns 0.0162 0 0 1.22 KB
#3199 CallElasticsearch net472 2.63μs 0.728ns 2.72ns 0.183 0 0 1.16 KB
#3199 CallElasticsearch netcoreapp3.1 1.54μs 1.02ns 3.95ns 0.0147 0 0 1.1 KB
#3199 CallElasticsearchAsync net472 2.84μs 1.58ns 5.9ns 0.205 0 0 1.29 KB
#3199 CallElasticsearchAsync netcoreapp3.1 1.61μs 0.412ns 1.54ns 0.0161 0 0 1.22 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.84μs 1.3ns 4.86ns 0.225 0 0 1.42 KB
master ExecuteAsync netcoreapp3.1 1.72μs 1.72ns 6.67ns 0.0181 0 0 1.34 KB
#3199 ExecuteAsync net472 2.91μs 2.73ns 10.6ns 0.225 0 0 1.42 KB
#3199 ExecuteAsync netcoreapp3.1 1.75μs 5.19ns 19.4ns 0.018 0.000899 0 1.34 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.86μs 11.3ns 43.9ns 0.438 0 0 2.77 KB
master SendAsync netcoreapp3.1 3.7μs 3.87ns 14.5ns 0.0347 0.00183 0 2.6 KB
#3199 SendAsync net472 5.74μs 20.8ns 80.6ns 0.439 0 0 2.77 KB
#3199 SendAsync netcoreapp3.1 3.8μs 2.28ns 8.54ns 0.0341 0 0 2.6 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.13μs 1.78ns 6.91ns 0.287 0 0 1.81 KB
master EnrichedLog netcoreapp3.1 2.57μs 1.16ns 4.33ns 0.0243 0 0 1.85 KB
#3199 EnrichedLog net472 3.24μs 2.12ns 7.94ns 0.287 0 0 1.81 KB
#3199 EnrichedLog netcoreapp3.1 2.42μs 1.14ns 4.13ns 0.0255 0 0 1.85 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 154μs 172ns 664ns 0.693 0.231 0 4.66 KB
master EnrichedLog netcoreapp3.1 119μs 408ns 1.58μs 0.0583 0 0 4.49 KB
#3199 EnrichedLog net472 153μs 189ns 731ns 0.691 0.23 0 4.65 KB
#3199 EnrichedLog netcoreapp3.1 120μs 159ns 615ns 0.0593 0 0 4.5 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.85μs 2.21ns 8.56ns 0.569 0.00292 0 3.59 KB
master EnrichedLog netcoreapp3.1 4.58μs 1.55ns 6ns 0.0527 0 0 3.91 KB
#3199 EnrichedLog net472 6μs 1.99ns 7.46ns 0.567 0.003 0 3.59 KB
#3199 EnrichedLog netcoreapp3.1 4.5μs 2.43ns 9.1ns 0.0536 0 0 3.91 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.25μs 2.38ns 8.92ns 0.217 0 0 1.37 KB
master SendReceive netcoreapp3.1 1.91μs 0.598ns 2.24ns 0.0183 0 0 1.32 KB
#3199 SendReceive net472 2.28μs 2.62ns 10.2ns 0.217 0 0 1.37 KB
#3199 SendReceive netcoreapp3.1 1.78μs 1.01ns 3.79ns 0.0176 0 0 1.32 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.02μs 4.89ns 18.9ns 0.353 0 0 2.23 KB
master EnrichedLog netcoreapp3.1 4.29μs 2.32ns 8.97ns 0.0237 0 0 1.8 KB
#3199 EnrichedLog net472 5.01μs 3.18ns 12.3ns 0.353 0 0 2.23 KB
#3199 EnrichedLog netcoreapp3.1 4.24μs 1.79ns 6.92ns 0.0235 0 0 1.8 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.2μs 0.676ns 2.53ns 0.129 0 0 810 B
master StartFinishSpan netcoreapp3.1 965ns 0.31ns 1.16ns 0.0101 0 0 760 B
master StartFinishScope net472 1.44μs 0.599ns 2.24ns 0.141 0 0 891 B
master StartFinishScope netcoreapp3.1 1.11μs 0.469ns 1.75ns 0.0116 0 0 880 B
#3199 StartFinishSpan net472 1.2μs 0.571ns 2.14ns 0.129 0.000598 0 810 B
#3199 StartFinishSpan netcoreapp3.1 978ns 0.513ns 1.92ns 0.0102 0 0 760 B
#3199 StartFinishScope net472 1.4μs 0.712ns 2.66ns 0.141 0 0 891 B
#3199 StartFinishScope netcoreapp3.1 1.08μs 0.435ns 1.68ns 0.0119 0 0 880 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.48μs 1.14ns 4.41ns 0.141 0 0 891 B
master RunOnMethodBegin netcoreapp3.1 1.14μs 0.66ns 2.56ns 0.0119 0 0 880 B
#3199 RunOnMethodBegin net472 1.46μs 0.773ns 3ns 0.141 0 0 891 B
#3199 RunOnMethodBegin netcoreapp3.1 1.17μs 1.12ns 4.03ns 0.0122 0 0 880 B

@andrewlock

andrewlock commented Sep 18, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

✔️ Merging #3199 into master will will increase line coverage by 1%
✔️ Merging #3199 into master will will increase branch coverage by 1%
✔️ Merging #3199 into master will not change complexity

master #3199 Change
Lines 17978 / 24587 18192 / 24587
Lines % 73% 74% 1% ✔️
Branches 10582 / 15064 10687 / 15064
Branches % 70% 71% 1% ✔️
Complexity 16290 16290 0 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3199 Change
Lines % 73% 74% 1% ✔️
Branches % 70% 71% 1% ✔️
Complexity 16290 16290 0 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Activity.DiagnosticSourceEventListener -6% ⛔ 0% ✔️ 0 ✔️
Datadog.Trace.Ci.CIVisibility 5% ✔️ 6% ✔️ 0 ✔️
Datadog.Trace.Telemetry.Transports.JsonTelemetryTransport 9% ✔️ 17% ✔️ 0 ✔️
Datadog.Trace.Agent.Transports.HttpStreamRequestFactory 12% ✔️ 0% ✔️ 0 ✔️
Datadog.Trace.Debugger.Instrumentation.MethodMetadataInfoFactory 27% ✔️ 0% ✔️ 0 ✔️
Datadog.Trace.Debugger.Snapshots.ExceptionSnapshotSerializerFieldsAndPropsSelector 44% ✔️ 0% ✔️ 0 ✔️
Datadog.Trace.Debugger.Instrumentation.AsyncMethodDebuggerState 50% ✔️ 0% ✔️ 0 ✔️
Datadog.Trace.Debugger.Helpers.AsyncHelper 84% ✔️ 68% ✔️ 0 ✔️
Datadog.Trace.Debugger.Instrumentation.AsyncMethodDebuggerInvoker 87% ✔️ 65% ✔️ 0 ✔️

View the full reports for further details:

@OmerRaviv
OmerRaviv merged commit 338e9ce into master Sep 18, 2022
@OmerRaviv
OmerRaviv deleted the omerr/fix-async-tests branch September 18, 2022 11:42
@github-actions github-actions Bot added this to the vNext milestone Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@GreenMatan GreenMatan GreenMatan approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:debugger area:tests unit tests, integration tests

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@OmerRaviv @andrewlock @GreenMatan