Skip to content

CI: Fetch committer and author in buildkite and bitrise#3187

Merged
albertvaka merged 5 commits into
masterfrom
albertvaka/add-commiter-info
Sep 18, 2022
Merged

CI: Fetch committer and author in buildkite and bitrise#3187
albertvaka merged 5 commits into
masterfrom
albertvaka/add-commiter-info

Conversation

@albertvaka

@albertvaka albertvaka commented Sep 7, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary of changes

Reads committer and author info from the env vars set by the CI provider.

Reason for change

These are in the CI spec but were missing.

Implementation details

Other tracers always set CommitterEmail to the committer name. However there's a committer email variable we can use. I assume this was a typo that propagated from the spec to all tracers, so I've changed the spec to say we should use the email and fallback to the name if not available (just in case the spec was intentional because the email is not always available).

@albertvaka
albertvaka requested review from a team as code owners September 7, 2022 16:30
@albertvaka albertvaka changed the title CI: Fetch commiter and author in buildkite and bitrise CI: Fetch committer and author in buildkite and bitrise Sep 7, 2022
@albertvaka
albertvaka force-pushed the albertvaka/add-commiter-info branch from 7f70354 to d868c5f Compare September 7, 2022 16:42
pierotibou
pierotibou reviewed Sep 8, 2022
View reviewed changes
Comment thread tracer/src/Datadog.Trace/Ci/CIEnvironmentValues.cs Outdated
zacharycmontoya
zacharycmontoya reviewed Sep 10, 2022
View reviewed changes
Comment thread tracer/src/Datadog.Trace/Ci/CIEnvironmentValues.cs Outdated
zacharycmontoya
zacharycmontoya reviewed Sep 10, 2022
View reviewed changes
Comment thread tracer/src/Datadog.Trace/Ci/CIEnvironmentValues.cs Outdated
@albertvaka
albertvaka force-pushed the albertvaka/add-commiter-info branch 2 times, most recently from f7d7d79 to ce72f05 Compare September 15, 2022 12:29
@albertvaka
albertvaka force-pushed the albertvaka/add-commiter-info branch from ce72f05 to 36119ed Compare September 15, 2022 12:29
@albertvaka
albertvaka force-pushed the albertvaka/add-commiter-info branch from 36119ed to ec12d8c Compare September 15, 2022 14:05
@andrewlock

This comment has been minimized.

Sign in to view
zacharycmontoya
zacharycmontoya reviewed Sep 16, 2022
View reviewed changes
Comment thread tracer/src/Datadog.Trace/Ci/CIEnvironmentValues.cs Outdated
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

andrewlock commented Sep 18, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #3187 compared to master:

  • All benchmarks have the same speed
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 723μs 768ns 2.97μs 0.361 0 0 3.18 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 475μs 155ns 599ns 0 0 0 2.58 KB
#3187 WriteAndFlushEnrichedTraces net472 720μs 587ns 2.12μs 0.357 0 0 3.18 KB
#3187 WriteAndFlushEnrichedTraces netcoreapp3.1 465μs 217ns 840ns 0 0 0 2.58 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 186ns 0.239ns 0.924ns 0.0676 0 0 425 B
master AllCycleSimpleBody netcoreapp3.1 238ns 0.276ns 1.07ns 0.00578 0 0 424 B
master AllCycleMoreComplexBody net472 179ns 0.235ns 0.911ns 0.0637 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 235ns 0.163ns 0.565ns 0.00546 0 0 400 B
master BodyExtractorSimpleBody net472 283ns 0.336ns 1.16ns 0.0574 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 221ns 0.273ns 1.06ns 0.00374 0 0 272 B
master BodyExtractorMoreComplexBody net472 14.7μs 11ns 41.1ns 1.21 0.0147 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 11.8μs 13.3ns 51.3ns 0.0888 0 0 6.75 KB
#3187 AllCycleSimpleBody net472 189ns 0.295ns 1.1ns 0.0675 0 0 425 B
#3187 AllCycleSimpleBody netcoreapp3.1 243ns 0.253ns 0.98ns 0.00572 0 0 424 B
#3187 AllCycleMoreComplexBody net472 179ns 0.178ns 0.69ns 0.0637 0 0 401 B
#3187 AllCycleMoreComplexBody netcoreapp3.1 235ns 0.298ns 1.11ns 0.0056 0 0 400 B
#3187 BodyExtractorSimpleBody net472 289ns 0.749ns 2.8ns 0.0574 0 0 361 B
#3187 BodyExtractorSimpleBody netcoreapp3.1 223ns 0.222ns 0.86ns 0.00367 0 0 272 B
#3187 BodyExtractorMoreComplexBody net472 14.6μs 6.88ns 25.7ns 1.21 0.022 0 7.62 KB
#3187 BodyExtractorMoreComplexBody netcoreapp3.1 11.8μs 12ns 46.6ns 0.0885 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 180μs 242ns 937ns 0.271 0 0 20.58 KB
#3187 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3187 SendRequest netcoreapp3.1 181μs 208ns 806ns 0.273 0 0 20.58 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.93μs 0.85ns 3.18ns 0.15 0 0 947 B
master ExecuteNonQuery netcoreapp3.1 1.4μs 1.68ns 6.51ns 0.0127 0 0 936 B
#3187 ExecuteNonQuery net472 1.76μs 0.721ns 2.6ns 0.15 0.000882 0 947 B
#3187 ExecuteNonQuery netcoreapp3.1 1.47μs 0.748ns 2.9ns 0.0125 0 0 936 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.51μs 1.95ns 7.55ns 0.183 0.00125 0 1.16 KB
master CallElasticsearch netcoreapp3.1 1.5μs 0.486ns 1.75ns 0.015 0 0 1.1 KB
master CallElasticsearchAsync net472 2.69μs 1.5ns 5.8ns 0.204 0 0 1.29 KB
master CallElasticsearchAsync netcoreapp3.1 1.66μs 0.557ns 2.16ns 0.0158 0 0 1.22 KB
#3187 CallElasticsearch net472 2.62μs 2.19ns 8.47ns 0.183 0 0 1.16 KB
#3187 CallElasticsearch netcoreapp3.1 1.53μs 1.34ns 5.02ns 0.0146 0 0 1.1 KB
#3187 CallElasticsearchAsync net472 2.74μs 1.96ns 7.58ns 0.205 0 0 1.29 KB
#3187 CallElasticsearchAsync netcoreapp3.1 1.64μs 0.573ns 2.14ns 0.0165 0 0 1.22 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.92μs 2.31ns 8.95ns 0.225 0 0 1.42 KB
master ExecuteAsync netcoreapp3.1 1.72μs 5.59ns 21.6ns 0.0182 0 0 1.34 KB
#3187 ExecuteAsync net472 2.83μs 10.6ns 41.2ns 0.225 0 0 1.42 KB
#3187 ExecuteAsync netcoreapp3.1 1.67μs 4.83ns 18.7ns 0.0181 0 0 1.34 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.71μs 12.6ns 48.9ns 0.439 0 0 2.77 KB
master SendAsync netcoreapp3.1 3.63μs 3.91ns 15.1ns 0.0356 0 0 2.6 KB
#3187 SendAsync net472 5.66μs 18.3ns 70.8ns 0.437 0 0 2.77 KB
#3187 SendAsync netcoreapp3.1 3.8μs 2.45ns 9.17ns 0.0344 0 0 2.6 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.1μs 0.896ns 3.23ns 0.287 0 0 1.81 KB
master EnrichedLog netcoreapp3.1 2.5μs 1.19ns 4.62ns 0.0252 0 0 1.85 KB
#3187 EnrichedLog net472 3.04μs 1.5ns 5.82ns 0.287 0 0 1.81 KB
#3187 EnrichedLog netcoreapp3.1 2.58μs 1.24ns 4.63ns 0.0247 0 0 1.85 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 154μs 249ns 966ns 0.699 0.233 0 4.65 KB
master EnrichedLog netcoreapp3.1 118μs 173ns 670ns 0.0585 0 0 4.49 KB
#3187 EnrichedLog net472 152μs 111ns 431ns 0.684 0.228 0 4.65 KB
#3187 EnrichedLog netcoreapp3.1 119μs 159ns 618ns 0.0593 0 0 4.5 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.72μs 1.76ns 6.6ns 0.567 0.00284 0 3.59 KB
master EnrichedLog netcoreapp3.1 4.39μs 2.45ns 9.48ns 0.0525 0 0 3.91 KB
#3187 EnrichedLog net472 5.8μs 2.74ns 10.6ns 0.568 0.00291 0 3.59 KB
#3187 EnrichedLog netcoreapp3.1 4.35μs 12.6ns 48.7ns 0.0534 0 0 3.91 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.26μs 1.84ns 6.63ns 0.218 0 0 1.37 KB
master SendReceive netcoreapp3.1 1.89μs 0.897ns 3.35ns 0.0179 0 0 1.32 KB
#3187 SendReceive net472 2.34μs 2.1ns 8.14ns 0.218 0 0 1.37 KB
#3187 SendReceive netcoreapp3.1 1.82μs 1.98ns 7.41ns 0.0181 0 0 1.32 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 4.96μs 3.12ns 11.7ns 0.353 0 0 2.23 KB
master EnrichedLog netcoreapp3.1 4.35μs 1.79ns 6.93ns 0.0238 0 0 1.8 KB
#3187 EnrichedLog net472 5.01μs 2.09ns 7.81ns 0.353 0 0 2.23 KB
#3187 EnrichedLog netcoreapp3.1 4.29μs 1.43ns 5.35ns 0.0237 0 0 1.8 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.18μs 2.13ns 7.99ns 0.128 0 0 810 B
master StartFinishSpan netcoreapp3.1 954ns 0.363ns 1.4ns 0.0104 0 0 760 B
master StartFinishScope net472 1.33μs 0.766ns 2.76ns 0.141 0 0 891 B
master StartFinishScope netcoreapp3.1 1.09μs 0.597ns 2.31ns 0.012 0 0 880 B
#3187 StartFinishSpan net472 1.15μs 0.477ns 1.85ns 0.128 0 0 810 B
#3187 StartFinishSpan netcoreapp3.1 937ns 0.349ns 1.3ns 0.0103 0 0 760 B
#3187 StartFinishScope net472 1.46μs 0.826ns 3.2ns 0.141 0 0 891 B
#3187 StartFinishScope netcoreapp3.1 1.1μs 0.446ns 1.67ns 0.0121 0 0 880 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.55μs 0.684ns 2.65ns 0.142 0.000773 0 891 B
master RunOnMethodBegin netcoreapp3.1 1.18μs 0.588ns 2.04ns 0.0119 0 0 880 B
#3187 RunOnMethodBegin net472 1.53μs 0.942ns 3.65ns 0.141 0 0 891 B
#3187 RunOnMethodBegin netcoreapp3.1 1.12μs 0.779ns 2.92ns 0.0118 0 0 880 B

@andrewlock

andrewlock commented Sep 18, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

✔️ Merging #3187 into master will not change line coverage
✔️ Merging #3187 into master will not change branch coverage
⛔ Merging #3187 into master will will increase complexity by 2

master #3187 Change
Lines 18203 / 24587 18196 / 24595
Lines % 74% 74% 0% ✔️
Branches 10692 / 15064 10688 / 15066
Branches % 71% 71% 0% ✔️
Complexity 16290 16292 2 ⛔

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3187 Change
Lines % 74% 74% 0% ✔️
Branches % 71% 71% 0% ✔️
Complexity 16290 16292 2 ⛔

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Ci.CIVisibility 5% ✔️ 6% ✔️ 0 ✔️
Datadog.Trace.Ci.GitInfo 5% ✔️ 8% ✔️ 0 ✔️

View the full reports for further details:

@albertvaka
albertvaka merged commit 11010c8 into master Sep 18, 2022
@albertvaka
albertvaka deleted the albertvaka/add-commiter-info branch September 18, 2022 20:13
@github-actions github-actions Bot added this to the vNext milestone Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lucaspimentel lucaspimentel lucaspimentel approved these changes
@zacharycmontoya zacharycmontoya zacharycmontoya left review comments
@pierotibou pierotibou pierotibou left review comments
@tonyredondo tonyredondo tonyredondo approved these changes

Assignees

No one assigned

Labels

area:ci-visibility

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

6 participants

@albertvaka @andrewlock @tonyredondo @lucaspimentel @zacharycmontoya @pierotibou