Skip to content

Add support for Microsoft.Data.SqlClient 5.x.x#3184

Merged
andrewlock merged 2 commits into
masterfrom
andrew/support-latest-Microsoft.Data.SqlClient
Sep 8, 2022
Merged

Add support for Microsoft.Data.SqlClient 5.x.x#3184
andrewlock merged 2 commits into
masterfrom
andrew/support-latest-Microsoft.Data.SqlClient

Conversation

@andrewlock

@andrewlock andrewlock commented Sep 7, 2022

Copy link
Copy Markdown
Member

Summary of changes

Adds support (and testing) for Microsoft.Data.SqlClient 5.x.x

Reason for change

We want to support the latest versions of integrations

Implementation details

Easy one - just bumped the version numbers and it seemed to work.

Test coverage

Bumped the tested version, and confirmed it worked.

Other details

This was easy. Too easy 🤔 :suspicious:

@andrewlock andrewlock added type:enhancement Improvement to an existing feature area:tests unit tests, integration tests area:test-apps apps used to test integrations labels Sep 7, 2022
@andrewlock
andrewlock requested review from a team as code owners September 7, 2022 13:42
@andrewlock

andrewlock commented Sep 7, 2022

Copy link
Copy Markdown
Member Author

Benchmarks Report 🐌

Benchmarks for #3184 compared to master:

  • 1 benchmarks are faster, with geometric mean 1.254
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 720μs 741ns 2.87μs 0.357 0 0 3.18 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 461μs 198ns 713ns 0 0 0 2.58 KB
#3184 WriteAndFlushEnrichedTraces net472 719μs 534ns 2μs 0.357 0 0 3.18 KB
#3184 WriteAndFlushEnrichedTraces netcoreapp3.1 474μs 233ns 871ns 0 0 0 2.58 KB
Benchmarks.Trace.AppSecBodyBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #3184

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 1.254 230.47 183.73

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 187ns 0.0739ns 0.286ns 0.0675 0 0 425 B
master AllCycleSimpleBody netcoreapp3.1 239ns 0.29ns 1.12ns 0.00576 0 0 424 B
master AllCycleMoreComplexBody net472 230ns 0.121ns 0.468ns 0.0638 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 233ns 0.341ns 1.32ns 0.00551 0 0 400 B
master BodyExtractorSimpleBody net472 264ns 0.188ns 0.729ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 228ns 0.269ns 1.01ns 0.00364 0 0 272 B
master BodyExtractorMoreComplexBody net472 14.4μs 8.33ns 32.3ns 1.2 0.0216 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 11.7μs 7.61ns 27.4ns 0.0885 0 0 6.75 KB
#3184 AllCycleSimpleBody net472 189ns 0.15ns 0.56ns 0.0676 0 0 425 B
#3184 AllCycleSimpleBody netcoreapp3.1 239ns 0.372ns 1.44ns 0.00579 0 0 424 B
#3184 AllCycleMoreComplexBody net472 184ns 0.0863ns 0.311ns 0.0637 0 0 401 B
#3184 AllCycleMoreComplexBody netcoreapp3.1 232ns 0.321ns 1.24ns 0.00544 0 0 400 B
#3184 BodyExtractorSimpleBody net472 285ns 0.263ns 1.02ns 0.0573 0 0 361 B
#3184 BodyExtractorSimpleBody netcoreapp3.1 227ns 0.235ns 0.911ns 0.00374 0 0 272 B
#3184 BodyExtractorMoreComplexBody net472 15.2μs 9.3ns 34.8ns 1.21 0.0152 0 7.62 KB
#3184 BodyExtractorMoreComplexBody netcoreapp3.1 12.1μs 12.2ns 45.7ns 0.0905 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 185μs 228ns 884ns 0.185 0 0 20.57 KB
#3184 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3184 SendRequest netcoreapp3.1 181μs 149ns 578ns 0.181 0 0 20.57 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.91μs 0.799ns 3.09ns 0.15 0.00096 0 947 B
master ExecuteNonQuery netcoreapp3.1 1.46μs 0.605ns 2.26ns 0.0124 0 0 936 B
#3184 ExecuteNonQuery net472 1.91μs 0.836ns 3.24ns 0.15 0.000952 0 947 B
#3184 ExecuteNonQuery netcoreapp3.1 1.44μs 0.965ns 3.61ns 0.0123 0 0 936 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.52μs 0.894ns 3.34ns 0.183 0 0 1.16 KB
master CallElasticsearch netcoreapp3.1 1.47μs 0.355ns 1.28ns 0.0147 0 0 1.1 KB
master CallElasticsearchAsync net472 2.64μs 1.32ns 5.1ns 0.205 0 0 1.29 KB
master CallElasticsearchAsync netcoreapp3.1 1.64μs 0.495ns 1.85ns 0.0164 0 0 1.22 KB
#3184 CallElasticsearch net472 2.48μs 0.653ns 2.53ns 0.183 0 0 1.16 KB
#3184 CallElasticsearch netcoreapp3.1 1.55μs 0.988ns 3.7ns 0.0146 0 0 1.1 KB
#3184 CallElasticsearchAsync net472 2.57μs 2.42ns 8.74ns 0.205 0 0 1.29 KB
#3184 CallElasticsearchAsync netcoreapp3.1 1.61μs 0.388ns 1.45ns 0.0161 0 0 1.22 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.65μs 6.63ns 25.7ns 0.225 0 0 1.42 KB
master ExecuteAsync netcoreapp3.1 1.72μs 5.27ns 20.4ns 0.0181 0 0 1.34 KB
#3184 ExecuteAsync net472 2.66μs 7.04ns 27.3ns 0.225 0 0 1.42 KB
#3184 ExecuteAsync netcoreapp3.1 1.75μs 3.67ns 14.2ns 0.0184 0 0 1.34 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.7μs 16.1ns 62.2ns 0.438 0 0 2.77 KB
master SendAsync netcoreapp3.1 3.65μs 17.6ns 72.6ns 0.0342 0 0 2.6 KB
#3184 SendAsync net472 5.69μs 16.1ns 60.4ns 0.437 0 0 2.77 KB
#3184 SendAsync netcoreapp3.1 3.69μs 9.17ns 35.5ns 0.0345 0 0 2.6 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.09μs 1.79ns 6.45ns 0.287 0 0 1.81 KB
master EnrichedLog netcoreapp3.1 2.49μs 1.39ns 5.02ns 0.0248 0 0 1.85 KB
#3184 EnrichedLog net472 3.27μs 3.78ns 14.2ns 0.287 0 0 1.81 KB
#3184 EnrichedLog netcoreapp3.1 2.57μs 1.57ns 5.68ns 0.0244 0 0 1.85 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 149μs 133ns 514ns 0.675 0.225 0 4.65 KB
master EnrichedLog netcoreapp3.1 116μs 279ns 1.08μs 0 0 0 4.49 KB
#3184 EnrichedLog net472 153μs 134ns 518ns 0.691 0.23 0 4.65 KB
#3184 EnrichedLog netcoreapp3.1 115μs 141ns 526ns 0.058 0 0 4.49 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.48μs 11.7ns 45.4ns 0.569 0.00272 0 3.59 KB
master EnrichedLog netcoreapp3.1 4.38μs 8.34ns 32.3ns 0.0551 0 0 3.91 KB
#3184 EnrichedLog net472 5.61μs 14.6ns 56.5ns 0.57 0.00281 0 3.59 KB
#3184 EnrichedLog netcoreapp3.1 4.58μs 8.69ns 32.5ns 0.0525 0 0 3.91 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.26μs 1.71ns 6.38ns 0.217 0 0 1.37 KB
master SendReceive netcoreapp3.1 1.91μs 1.08ns 4.17ns 0.0181 0 0 1.32 KB
#3184 SendReceive net472 2.32μs 2.71ns 10.5ns 0.218 0 0 1.37 KB
#3184 SendReceive netcoreapp3.1 1.86μs 8.93ns 36.8ns 0.0183 0 0 1.32 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.07μs 1.88ns 7.28ns 0.354 0 0 2.23 KB
master EnrichedLog netcoreapp3.1 4.28μs 2.01ns 7.77ns 0.0236 0 0 1.8 KB
#3184 EnrichedLog net472 5.18μs 1.38ns 4.97ns 0.354 0 0 2.23 KB
#3184 EnrichedLog netcoreapp3.1 4.36μs 7.03ns 24.4ns 0.024 0 0 1.8 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.18μs 0.4ns 1.49ns 0.129 0 0 810 B
master StartFinishSpan netcoreapp3.1 1.04μs 0.591ns 2.21ns 0.00989 0 0 760 B
master StartFinishScope net472 1.41μs 0.625ns 2.42ns 0.141 0 0 891 B
master StartFinishScope netcoreapp3.1 1.07μs 0.525ns 1.96ns 0.0117 0 0 880 B
#3184 StartFinishSpan net472 1.18μs 0.498ns 1.93ns 0.128 0 0 810 B
#3184 StartFinishSpan netcoreapp3.1 959ns 0.377ns 1.41ns 0.0106 0 0 760 B
#3184 StartFinishScope net472 1.35μs 0.65ns 2.52ns 0.141 0 0 891 B
#3184 StartFinishScope netcoreapp3.1 1.09μs 0.298ns 1.15ns 0.012 0 0 880 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.48μs 1.52ns 5.68ns 0.141 0 0 891 B
master RunOnMethodBegin netcoreapp3.1 1.14μs 0.331ns 1.24ns 0.0119 0 0 880 B
#3184 RunOnMethodBegin net472 1.5μs 0.7ns 2.62ns 0.141 0 0 891 B
#3184 RunOnMethodBegin netcoreapp3.1 1.14μs 0.378ns 1.46ns 0.012 0 0 880 B

@andrewlock

andrewlock commented Sep 7, 2022

Copy link
Copy Markdown
Member Author

Code Coverage Report 📊

✔️ Merging #3184 into master will not change line coverage
✔️ Merging #3184 into master will not change branch coverage
✔️ Merging #3184 into master will not change complexity

master #3184 Change
Lines 17764 / 24287 17783 / 24287
Lines % 73% 73% 0% ✔️
Branches 10465 / 14928 10481 / 14928
Branches % 70% 70% 0% ✔️
Complexity 16123 16123 0 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3184 Change
Lines % 73% 73% 0% ✔️
Branches % 70% 70% 0% ✔️
Complexity 16123 16123 0 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Agent.DiscoveryService.DiscoveryService -11% ⛔ 0% ✔️ 0 ✔️
Datadog.Trace.Debugger.ProbeStatuses.ProbeStatusPoller 0% ✔️ 6% ✔️ 0 ✔️
Datadog.Trace.Ci.CIVisibility 5% ✔️ 6% ✔️ 0 ✔️

View the full reports for further details:

zacharycmontoya
zacharycmontoya approved these changes Sep 8, 2022
View reviewed changes

@zacharycmontoya zacharycmontoya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@andrewlock
andrewlock merged commit 16d93e1 into master Sep 8, 2022
@andrewlock
andrewlock deleted the andrew/support-latest-Microsoft.Data.SqlClient branch September 8, 2022 07:53
@github-actions github-actions Bot added this to the vNext milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes

Assignees

No one assigned

Labels

area:test-apps apps used to test integrations area:tests unit tests, integration tests type:enhancement Improvement to an existing feature

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

2 participants

@andrewlock @zacharycmontoya