[CIVisibility] - Correctly extract commit message from AppVeyor by albertvaka · Pull Request #3183 · DataDog/dd-trace-dotnet

albertvaka · 2022-09-07T13:27:11Z

Summary of changes

Fix getting the full commit message when running on the AppVeyor CI.

Reason for change

Previously we were only checking APPVEYOR_REPO_COMMIT_MESSAGE_EXTENDED which, as per the docs only contains the "rest" of the commit message. The first line of the commit message is in APPVEYOR_REPO_COMMIT_MESSAGE.

Test coverage

Updated appveyor fixture.

andrewlock

Thanks!

tonyredondo

LGTM

Co-authored-by: Andrew Lock <[email protected]>

andrewlock · 2022-09-14T16:26:22Z

Benchmarks Report 🐌

Benchmarks for #3183 compared to master:

1 benchmarks are slower, with geometric mean 1.134
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net472	720μs	916ns	3.55μs	0.359	3.18 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	458μs	649ns	2.52μs	0	2.58 KB
#3183	`WriteAndFlushEnrichedTraces`	net472	712μs	712ns	2.66μs	0.359	3.18 KB
#3183	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	474μs	390ns	1.51μs	0	2.59 KB

Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`AllCycleSimpleBody`	net472	190ns	0.13ns	0.467ns	0.0676	0	425 B
master	`AllCycleSimpleBody`	netcoreapp3.1	236ns	0.322ns	1.25ns	0.00581	0	424 B
master	`AllCycleMoreComplexBody`	net472	188ns	0.105ns	0.377ns	0.0638	0	401 B
master	`AllCycleMoreComplexBody`	netcoreapp3.1	236ns	0.297ns	1.11ns	0.00546	0	400 B
master	`BodyExtractorSimpleBody`	net472	256ns	0.244ns	0.946ns	0.0573	0	361 B
master	`BodyExtractorSimpleBody`	netcoreapp3.1	222ns	0.191ns	0.714ns	0.00369	0	272 B
master	`BodyExtractorMoreComplexBody`	net472	14.4μs	17.1ns	66.1ns	1.21	0.0217	7.62 KB
master	`BodyExtractorMoreComplexBody`	netcoreapp3.1	12.4μs	17.2ns	64.2ns	0.0869	0	6.75 KB
#3183	`AllCycleSimpleBody`	net472	186ns	0.15ns	0.562ns	0.0676	0	425 B
#3183	`AllCycleSimpleBody`	netcoreapp3.1	237ns	0.25ns	0.969ns	0.00576	0	424 B
#3183	`AllCycleMoreComplexBody`	net472	181ns	0.193ns	0.748ns	0.0637	0	401 B
#3183	`AllCycleMoreComplexBody`	netcoreapp3.1	237ns	0.176ns	0.68ns	0.00545	0	400 B
#3183	`BodyExtractorSimpleBody`	net472	256ns	0.241ns	0.903ns	0.0574	0	361 B
#3183	`BodyExtractorSimpleBody`	netcoreapp3.1	222ns	0.147ns	0.57ns	0.00369	0	272 B
#3183	`BodyExtractorMoreComplexBody`	net472	15.1μs	17.6ns	68ns	1.21	0.0152	7.62 KB
#3183	`BodyExtractorMoreComplexBody`	netcoreapp3.1	12.3μs	8.94ns	33.4ns	0.0918	0	6.75 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
master	`SendRequest`	netcoreapp3.1	181μs	316ns	1.23μs	0.271	20.6 KB
#3183	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#3183	`SendRequest`	netcoreapp3.1	183μs	202ns	781ns	0.183	20.58 KB

Benchmarks.Trace.DbCommandBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #3183

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472	1.134	1,730.43	1,961.72

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net472	1.73μs	2.1ns	7.84ns	0.15	0	947 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.43μs	0.867ns	3.24ns	0.0122	0	936 B
#3183	`ExecuteNonQuery`	net472	1.96μs	2.69ns	10.4ns	0.15	0.000982	947 B
#3183	`ExecuteNonQuery`	netcoreapp3.1	1.47μs	1.09ns	4.09ns	0.0124	0	936 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net472	2.52μs	2.8ns	10.8ns	0.183	1.16 KB
master	`CallElasticsearch`	netcoreapp3.1	1.57μs	0.913ns	3.42ns	0.0149	1.1 KB
master	`CallElasticsearchAsync`	net472	2.73μs	1.81ns	7.01ns	0.204	1.29 KB
master	`CallElasticsearchAsync`	netcoreapp3.1	1.61μs	0.714ns	2.67ns	0.0162	1.22 KB
#3183	`CallElasticsearch`	net472	2.58μs	1.9ns	7.37ns	0.183	1.16 KB
#3183	`CallElasticsearch`	netcoreapp3.1	1.64μs	0.761ns	2.85ns	0.0146	1.1 KB
#3183	`CallElasticsearchAsync`	net472	2.74μs	2.21ns	8.26ns	0.205	1.29 KB
#3183	`CallElasticsearchAsync`	netcoreapp3.1	1.6μs	0.757ns	2.83ns	0.0159	1.22 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteAsync`	net472	2.72μs	7.54ns	28.2ns	0.225	0.00135	1.42 KB
master	`ExecuteAsync`	netcoreapp3.1	1.76μs	3.48ns	13.5ns	0.0185	0	1.34 KB
#3183	`ExecuteAsync`	net472	2.76μs	5.69ns	21.3ns	0.226	0	1.42 KB
#3183	`ExecuteAsync`	netcoreapp3.1	1.67μs	5.26ns	20.4ns	0.0183	0	1.34 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`SendAsync`	net472	5.67μs	8.76ns	33.9ns	0.44	0	2.77 KB
master	`SendAsync`	netcoreapp3.1	3.64μs	7.35ns	27.5ns	0.0344	0.00181	2.6 KB
#3183	`SendAsync`	net472	5.78μs	7.9ns	30.6ns	0.439	0	2.77 KB
#3183	`SendAsync`	netcoreapp3.1	3.71μs	11.7ns	45.3ns	0.0343	0	2.6 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net472	3.22μs	1.67ns	6.49ns	0.287	1.81 KB
master	`EnrichedLog`	netcoreapp3.1	2.59μs	0.974ns	3.51ns	0.0254	1.85 KB
#3183	`EnrichedLog`	net472	3.22μs	7ns	27.1ns	0.288	1.81 KB
#3183	`EnrichedLog`	netcoreapp3.1	2.49μs	1.15ns	4.29ns	0.0249	1.85 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net472	153μs	216ns	835ns	0.684	0.076	4.66 KB
master	`EnrichedLog`	netcoreapp3.1	118μs	304ns	1.18μs	0.0586	0	4.49 KB
#3183	`EnrichedLog`	net472	156μs	203ns	788ns	0.721	0.24	4.66 KB
#3183	`EnrichedLog`	netcoreapp3.1	118μs	282ns	1.09μs	0.0582	0	4.49 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net472	5.59μs	10.3ns	37.1ns	0.569	0.0028	3.59 KB
master	`EnrichedLog`	netcoreapp3.1	4.28μs	7.24ns	27.1ns	0.0525	0.0021	3.91 KB
#3183	`EnrichedLog`	net472	5.72μs	15.5ns	60.2ns	0.569	0.00283	3.59 KB
#3183	`EnrichedLog`	netcoreapp3.1	4.22μs	8.72ns	33.8ns	0.0529	0	3.91 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net472	2.37μs	1.15ns	4.29ns	0.218	1.37 KB
master	`SendReceive`	netcoreapp3.1	1.88μs	1.97ns	7.36ns	0.0181	1.32 KB
#3183	`SendReceive`	net472	2.4μs	1.88ns	7.27ns	0.218	1.37 KB
#3183	`SendReceive`	netcoreapp3.1	1.8μs	0.946ns	3.41ns	0.0181	1.32 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net472	5.06μs	3.59ns	13.4ns	0.354	0.00253	2.23 KB
master	`EnrichedLog`	netcoreapp3.1	4.36μs	1.32ns	5.12ns	0.0239	0	1.8 KB
#3183	`EnrichedLog`	net472	5.06μs	2.09ns	7.8ns	0.353	0	2.23 KB
#3183	`EnrichedLog`	netcoreapp3.1	4.14μs	1.61ns	6.02ns	0.0227	0	1.8 KB

Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net472	1.17μs	0.483ns	1.81ns	0.129	810 B
master	`StartFinishSpan`	netcoreapp3.1	956ns	0.403ns	1.45ns	0.00996	760 B
master	`StartFinishScope`	net472	1.41μs	0.587ns	2.27ns	0.142	891 B
master	`StartFinishScope`	netcoreapp3.1	1.07μs	0.637ns	2.3ns	0.0119	880 B
#3183	`StartFinishSpan`	net472	1.15μs	0.67ns	2.59ns	0.128	810 B
#3183	`StartFinishSpan`	netcoreapp3.1	997ns	0.382ns	1.38ns	0.0105	760 B
#3183	`StartFinishScope`	net472	1.36μs	1.71ns	6.62ns	0.141	891 B
#3183	`StartFinishScope`	netcoreapp3.1	1.11μs	1.72ns	6.65ns	0.0118	880 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net472	1.5μs	1.05ns	4.07ns	0.142	891 B
master	`RunOnMethodBegin`	netcoreapp3.1	1.13μs	0.639ns	2.39ns	0.0119	880 B
#3183	`RunOnMethodBegin`	net472	1.53μs	1.17ns	4.54ns	0.141	891 B
#3183	`RunOnMethodBegin`	netcoreapp3.1	1.18μs	0.557ns	2.08ns	0.0118	880 B

andrewlock · 2022-09-14T16:49:52Z

Code Coverage Report 📊

✔️ Merging #3183 into master will not change line coverage
✔️ Merging #3183 into master will not change branch coverage
⛔ Merging #3183 into master will will increase complexity by 21

	master	#3183	Change
Lines	`17971` / `24517`	`18033` / `24569`
Lines %	`73%`	`73%`	`0%` ✔️
Branches	`10585` / `15050`	`10612` / `15058`
Branches %	`70%`	`70%`	`0%` ✔️
Complexity	`16261`	`16282`	`21` ⛔

View the full report for further details:

Datadog.Trace Breakdown ✔️

	master	#3183	Change
Lines %	`73%`	`73%`	`0%` ✔️
Branches %	`70%`	`70%`	`0%` ✔️
Complexity	`16261`	`16282`	`21` ⛔

The following classes have significant coverage changes.

File	Line coverage change	Branch coverage change	Complexity change
Datadog.Trace.RemoteConfigurationManagement.RemoteConfigurationCache	`-86%` ⛔	`0%` ✔️	`2` ⛔
Datadog.Trace.RemoteConfigurationManagement.ProductConfigChangedEventArgs	`-68%` ⛔	`-67%` ⛔	`6` ⛔
Datadog.Trace.RemoteConfigurationManagement.Product	`-31%` ⛔	`-29%` ⛔	`9` ⛔
Datadog.Trace.Ci.CIVisibility	`5%` ✔️	`6%` ✔️	`0` ✔️
Datadog.Trace.Ci.GitInfo	`5%` ✔️	`8%` ✔️	`0` ✔️

The following classes were added in #3183:

File	Line coverage	Branch coverage	Complexity
Datadog.Trace.RemoteConfigurationManagement.ApplyDetails	`0%`	`100%`	`2`
Datadog.Trace.RemoteConfigurationManagement.NamedRawFile	`100%`	`100%`	`1`
Datadog.Trace.RemoteConfigurationManagement.NamedTypedFile`1	`100%`	`100%`	`1`

View the full reports for further details:

albertvaka requested review from a team as code owners September 7, 2022 13:27

tonyredondo reviewed Sep 7, 2022

View reviewed changes

Comment thread tracer/src/Datadog.Trace/Ci/CIEnvironmentValues.cs Outdated

andrewlock approved these changes Sep 7, 2022

View reviewed changes

Comment thread tracer/src/Datadog.Trace/Ci/CIEnvironmentValues.cs Outdated

tonyredondo changed the title ~~CI: Correctly extract commit message from AppVeyor~~ [CIVisibility] - Correctly extract commit message from AppVeyor Sep 7, 2022

tonyredondo approved these changes Sep 7, 2022

View reviewed changes

github-actions Bot added the area:ci-visibility label Sep 7, 2022

CI: Correctly extract commit message from AppVeyor

62cc033

albertvaka force-pushed the albertvaka/fix-appveyor-commit-message branch from f7d8c27 to 62cc033 Compare September 7, 2022 16:40

andrewlock reviewed Sep 8, 2022

View reviewed changes

Comment thread tracer/src/Datadog.Trace/Ci/CIEnvironmentValues.cs

albertvaka and others added 2 commits September 14, 2022 17:53

Update tracer/src/Datadog.Trace/Ci/CIEnvironmentValues.cs

b73015c

Co-authored-by: Andrew Lock <[email protected]>

Merge branch 'master' into albertvaka/fix-appveyor-commit-message

60ccfaa

albertvaka merged commit ae4cc0c into master Sep 14, 2022

albertvaka deleted the albertvaka/fix-appveyor-commit-message branch September 14, 2022 17:24

github-actions Bot added this to the vNext milestone Sep 14, 2022

Uh oh!

Conversation

albertvaka commented Sep 7, 2022

Summary of changes

Reason for change

Test coverage

Uh oh!

Uh oh!

andrewlock left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tonyredondo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

andrewlock commented Sep 14, 2022

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

Slower ⚠️ in #3183

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Uh oh!

andrewlock commented Sep 14, 2022

Code Coverage Report 📊

Datadog.Trace Breakdown ✔️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants