[Profiler] Ensure that all API HRESULT are checked#3179
Merged
Conversation
github-actions
Bot
added
the
area:profiler
gleocadie
approved these changes
Sep 7, 2022
gleocadie
left a comment
gleocadie
left a comment
Collaborator
There was a problem hiding this comment.
LGTM: can't we add a test to make sure that it won't crash for this case in the future ? (in Computer01 for example )
Contributor
Author
I tried to reproduce by allocating Generic instead of Generic but without success :^( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Check GetClassIDInfo2 return value in all cases
Reason for change
Crash in the CLR
Implementation details
Check HRESULT and 0 CLASSID
Test coverage
Other details