Skip to content

Ensure any test artifact has the job attempt number as part of the name.#3173

Merged
andrewlock merged 2 commits into
masterfrom
robert/fix-exploration-test-uploaed
Sep 8, 2022
Merged

Ensure any test artifact has the job attempt number as part of the name.#3173
andrewlock merged 2 commits into
masterfrom
robert/fix-exploration-test-uploaed

Conversation

@robertpi

@robertpi robertpi commented Sep 6, 2022

Copy link
Copy Markdown
Member

Upload of a second attempt would fail otherwise.

@robertpi
robertpi requested review from a team as code owners September 6, 2022 11:36
@github-actions github-actions Bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Sep 6, 2022
andrewlock
andrewlock approved these changes Sep 6, 2022
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
OmerRaviv
OmerRaviv approved these changes Sep 6, 2022
View reviewed changes

@OmerRaviv OmerRaviv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, much needed change :)!

@andrewlock

andrewlock commented Sep 7, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #3173 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.115
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 736μs 205ns 767ns 0.368 0 0 3.18 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 462μs 178ns 642ns 0 0 0 2.58 KB
#3173 WriteAndFlushEnrichedTraces net472 718μs 556ns 2.15μs 0.357 0 0 3.18 KB
#3173 WriteAndFlushEnrichedTraces netcoreapp3.1 451μs 266ns 994ns 0 0 0 2.58 KB
Benchmarks.Trace.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #3173

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 1.115 184.10 205.30

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 184ns 0.152ns 0.57ns 0.0676 0 0 425 B
master AllCycleSimpleBody netcoreapp3.1 240ns 0.257ns 0.961ns 0.00574 0 0 424 B
master AllCycleMoreComplexBody net472 184ns 0.175ns 0.655ns 0.0638 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 246ns 0.403ns 1.56ns 0.00539 0 0 400 B
master BodyExtractorSimpleBody net472 257ns 0.369ns 1.33ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 227ns 0.39ns 1.51ns 0.00372 0 0 272 B
master BodyExtractorMoreComplexBody net472 15μs 11.9ns 44.6ns 1.21 0.015 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 11.8μs 15.7ns 61ns 0.088 0 0 6.75 KB
#3173 AllCycleSimpleBody net472 205ns 0.176ns 0.658ns 0.0675 0 0 425 B
#3173 AllCycleSimpleBody netcoreapp3.1 235ns 0.404ns 1.56ns 0.0058 0 0 424 B
#3173 AllCycleMoreComplexBody net472 207ns 1.22ns 12.2ns 0.0637 0 0 401 B
#3173 AllCycleMoreComplexBody netcoreapp3.1 233ns 0.251ns 0.971ns 0.00549 0 0 400 B
#3173 BodyExtractorSimpleBody net472 262ns 0.254ns 0.982ns 0.0573 0 0 361 B
#3173 BodyExtractorSimpleBody netcoreapp3.1 220ns 0.217ns 0.842ns 0.00363 0 0 272 B
#3173 BodyExtractorMoreComplexBody net472 14.5μs 6.89ns 25.8ns 1.21 0.0148 0 7.62 KB
#3173 BodyExtractorMoreComplexBody netcoreapp3.1 11.8μs 13.6ns 52.5ns 0.0939 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 181μs 117ns 451ns 0.27 0 0 20.57 KB
#3173 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3173 SendRequest netcoreapp3.1 184μs 240ns 931ns 0.182 0 0 20.57 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.87μs 0.659ns 2.55ns 0.15 0.000933 0 947 B
master ExecuteNonQuery netcoreapp3.1 1.37μs 0.871ns 3.26ns 0.0123 0 0 936 B
#3173 ExecuteNonQuery net472 1.86μs 0.536ns 1.93ns 0.15 0.000923 0 947 B
#3173 ExecuteNonQuery netcoreapp3.1 1.42μs 0.723ns 2.8ns 0.0122 0 0 936 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.61μs 0.914ns 3.42ns 0.183 0 0 1.16 KB
master CallElasticsearch netcoreapp3.1 1.62μs 0.921ns 3.45ns 0.0146 0 0 1.1 KB
master CallElasticsearchAsync net472 2.65μs 9.11ns 37.5ns 0.204 0 0 1.29 KB
master CallElasticsearchAsync netcoreapp3.1 1.64μs 0.577ns 2.23ns 0.0167 0 0 1.22 KB
#3173 CallElasticsearch net472 2.52μs 0.541ns 1.95ns 0.183 0 0 1.16 KB
#3173 CallElasticsearch netcoreapp3.1 1.55μs 0.833ns 3.23ns 0.0148 0 0 1.1 KB
#3173 CallElasticsearchAsync net472 2.63μs 0.833ns 3ns 0.205 0 0 1.29 KB
#3173 CallElasticsearchAsync netcoreapp3.1 1.64μs 0.529ns 1.91ns 0.0165 0 0 1.22 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.56μs 4.41ns 17.1ns 0.225 0 0 1.42 KB
master ExecuteAsync netcoreapp3.1 1.72μs 4.16ns 16.1ns 0.0187 0 0 1.34 KB
#3173 ExecuteAsync net472 2.56μs 4.34ns 16.8ns 0.225 0 0 1.42 KB
#3173 ExecuteAsync netcoreapp3.1 1.73μs 4.8ns 17.9ns 0.0183 0 0 1.34 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.66μs 11.6ns 45ns 0.437 0 0 2.77 KB
master SendAsync netcoreapp3.1 3.57μs 8.98ns 33.6ns 0.0353 0 0 2.6 KB
#3173 SendAsync net472 5.6μs 10.5ns 40.9ns 0.438 0 0 2.77 KB
#3173 SendAsync netcoreapp3.1 3.58μs 9.05ns 35ns 0.034 0 0 2.6 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.34μs 9.1ns 34ns 0.288 0 0 1.81 KB
master EnrichedLog netcoreapp3.1 2.62μs 1.56ns 5.82ns 0.0248 0 0 1.85 KB
#3173 EnrichedLog net472 3.22μs 2.69ns 10.4ns 0.288 0 0 1.81 KB
#3173 EnrichedLog netcoreapp3.1 2.51μs 0.992ns 3.84ns 0.025 0 0 1.85 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 150μs 88.6ns 332ns 0.67 0.223 0 4.65 KB
master EnrichedLog netcoreapp3.1 117μs 182ns 706ns 0.0581 0 0 4.49 KB
#3173 EnrichedLog net472 151μs 91.5ns 343ns 0.683 0.228 0 4.65 KB
#3173 EnrichedLog netcoreapp3.1 114μs 142ns 549ns 0.0582 0 0 4.49 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.54μs 12.7ns 49.2ns 0.568 0.00273 0 3.59 KB
master EnrichedLog netcoreapp3.1 4.32μs 9.85ns 38.1ns 0.0525 0 0 3.91 KB
#3173 EnrichedLog net472 5.62μs 10.6ns 38.1ns 0.568 0.00284 0 3.59 KB
#3173 EnrichedLog netcoreapp3.1 4.36μs 6.95ns 26.9ns 0.0544 0 0 3.91 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.27μs 0.776ns 2.9ns 0.218 0 0 1.37 KB
master SendReceive netcoreapp3.1 1.79μs 2.92ns 10.9ns 0.0178 0 0 1.32 KB
#3173 SendReceive net472 2.32μs 11.8ns 51.6ns 0.217 0 0 1.37 KB
#3173 SendReceive netcoreapp3.1 1.87μs 0.552ns 2.14ns 0.0178 0 0 1.32 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5μs 1.79ns 6.94ns 0.354 0 0 2.23 KB
master EnrichedLog netcoreapp3.1 4.36μs 1.22ns 4.73ns 0.024 0 0 1.8 KB
#3173 EnrichedLog net472 5.01μs 3.1ns 12ns 0.353 0 0 2.23 KB
#3173 EnrichedLog netcoreapp3.1 4.34μs 1.68ns 6.49ns 0.0238 0 0 1.8 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.09μs 0.485ns 1.88ns 0.129 0 0 810 B
master StartFinishSpan netcoreapp3.1 929ns 0.334ns 1.25ns 0.0102 0 0 760 B
master StartFinishScope net472 1.35μs 0.518ns 1.94ns 0.141 0 0 891 B
master StartFinishScope netcoreapp3.1 1.13μs 0.302ns 1.13ns 0.0119 0 0 880 B
#3173 StartFinishSpan net472 1.12μs 0.305ns 1.14ns 0.128 0 0 810 B
#3173 StartFinishSpan netcoreapp3.1 919ns 0.201ns 0.752ns 0.0101 0 0 760 B
#3173 StartFinishScope net472 1.47μs 0.561ns 2.17ns 0.141 0 0 891 B
#3173 StartFinishScope netcoreapp3.1 1.08μs 0.3ns 1.12ns 0.0122 0 0 880 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.53μs 0.587ns 2.27ns 0.141 0 0 891 B
master RunOnMethodBegin netcoreapp3.1 1.21μs 0.32ns 1.2ns 0.012 0 0 880 B
#3173 RunOnMethodBegin net472 1.5μs 0.424ns 1.64ns 0.141 0 0 891 B
#3173 RunOnMethodBegin netcoreapp3.1 1.14μs 1.33ns 5.17ns 0.012 0 0 880 B

@andrewlock

andrewlock commented Sep 8, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

✔️ Merging #3173 into master will not change line coverage
✔️ Merging #3173 into master will not change branch coverage
✔️ Merging #3173 into master will will decrease complexity by 38

master #3173 Change
Lines 17816 / 24332 17785 / 24287
Lines % 73% 73% 0% ✔️
Branches 10500 / 14962 10479 / 14928
Branches % 70% 70% 0% ✔️
Complexity 16161 16123 -38 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3173 Change
Lines % 73% 73% 0% ✔️
Branches % 70% 70% 0% ✔️
Complexity 16161 16123 -38 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Debugger.ProbeStatuses.ProbeStatusPoller 0% ✔️ -6% ⛔ 0 ✔️
Datadog.Trace.Ci.CIVisibility 5% ✔️ 6% ✔️ 0 ✔️
Datadog.Trace.Ci.GitInfo 5% ✔️ 8% ✔️ 0 ✔️
Datadog.Trace.Agent.NullStatsAggregator 30% ✔️ 0% ✔️ -1 ✔️

5 classes were removed from Datadog.Trace in #3173

View the full reports for further details:

@andrewlock
andrewlock merged commit ab39b5b into master Sep 8, 2022
@andrewlock
andrewlock deleted the robert/fix-exploration-test-uploaed branch September 8, 2022 10:38
@github-actions github-actions Bot added this to the vNext milestone Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OmerRaviv OmerRaviv OmerRaviv approved these changes
@andrewlock andrewlock andrewlock approved these changes
@pierotibou pierotibou pierotibou approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@robertpi @andrewlock @OmerRaviv @pierotibou