Skip to content

Remove obsolete snapshot URI#3165

Merged
shurivich merged 1 commit into
masterfrom
shurivich/remove_snapshot_uri
Sep 4, 2022
Merged

Remove obsolete snapshot URI#3165
shurivich merged 1 commit into
masterfrom
shurivich/remove_snapshot_uri

Conversation

@shurivich

@shurivich shurivich commented Sep 4, 2022

Copy link
Copy Markdown
Contributor

Summary of changes

Remove obsolete snapshot URI

Reason for change

Snapshot URI is not used anymore, it was deprecated.

@shurivich shurivich self-assigned this Sep 4, 2022
@shurivich
shurivich requested a review from a team as a code owner September 4, 2022 11:11
@github-actions github-actions Bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Sep 4, 2022
OmerRaviv
OmerRaviv approved these changes Sep 4, 2022
View reviewed changes

@OmerRaviv OmerRaviv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock

andrewlock commented Sep 4, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #3165 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.166
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 724μs 254ns 881ns 0.359 0 0 3.18 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 449μs 259ns 934ns 0 0 0 2.58 KB
#3165 WriteAndFlushEnrichedTraces net472 716μs 569ns 2.21μs 0.353 0 0 3.18 KB
#3165 WriteAndFlushEnrichedTraces netcoreapp3.1 489μs 288ns 1.11μs 0 0 0 2.58 KB
Benchmarks.Trace.AppSecBodyBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #3165

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.BodyExtractorSimpleBody‑net472 1.198 297.63 248.51
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 1.136 209.58 184.53

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 185ns 0.704ns 2.64ns 0.0676 9.25E-05 0 425 B
master AllCycleSimpleBody netcoreapp3.1 236ns 0.272ns 1.02ns 0.00579 0 0 424 B
master AllCycleMoreComplexBody net472 209ns 0.237ns 0.889ns 0.0637 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 234ns 0.304ns 1.18ns 0.00541 0 0 400 B
master BodyExtractorSimpleBody net472 298ns 0.368ns 1.33ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 227ns 0.224ns 0.867ns 0.00366 0 0 272 B
master BodyExtractorMoreComplexBody net472 14.4μs 12.9ns 49.8ns 1.21 0.0217 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 12.6μs 13.4ns 50.2ns 0.0872 0 0 6.75 KB
#3165 AllCycleSimpleBody net472 182ns 0.161ns 0.604ns 0.0676 9.2E-05 0 425 B
#3165 AllCycleSimpleBody netcoreapp3.1 239ns 0.192ns 0.745ns 0.00585 0 0 424 B
#3165 AllCycleMoreComplexBody net472 185ns 0.189ns 0.733ns 0.0637 0 0 401 B
#3165 AllCycleMoreComplexBody netcoreapp3.1 233ns 0.303ns 1.05ns 0.00551 0 0 400 B
#3165 BodyExtractorSimpleBody net472 248ns 0.2ns 0.774ns 0.0573 0 0 361 B
#3165 BodyExtractorSimpleBody netcoreapp3.1 225ns 0.249ns 0.899ns 0.00372 0 0 272 B
#3165 BodyExtractorMoreComplexBody net472 14.2μs 18.3ns 66ns 1.21 0.0212 0 7.62 KB
#3165 BodyExtractorMoreComplexBody netcoreapp3.1 12μs 14.8ns 57.4ns 0.0907 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 184μs 241ns 933ns 0.276 0 0 20.57 KB
#3165 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3165 SendRequest netcoreapp3.1 186μs 347ns 1.34μs 0.184 0 0 20.57 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.77μs 0.638ns 2.47ns 0.15 0.000897 0 947 B
master ExecuteNonQuery netcoreapp3.1 1.47μs 0.371ns 1.44ns 0.0125 0 0 936 B
#3165 ExecuteNonQuery net472 1.83μs 0.455ns 1.76ns 0.15 0.000911 0 947 B
#3165 ExecuteNonQuery netcoreapp3.1 1.44μs 0.624ns 2.34ns 0.0123 0 0 936 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.47μs 0.836ns 3.13ns 0.183 0 0 1.16 KB
master CallElasticsearch netcoreapp3.1 1.54μs 0.713ns 2.76ns 0.0146 0 0 1.1 KB
master CallElasticsearchAsync net472 2.64μs 0.53ns 1.98ns 0.205 0 0 1.29 KB
master CallElasticsearchAsync netcoreapp3.1 1.62μs 0.514ns 1.99ns 0.0162 0 0 1.22 KB
#3165 CallElasticsearch net472 2.5μs 0.765ns 2.96ns 0.183 0 0 1.16 KB
#3165 CallElasticsearch netcoreapp3.1 1.57μs 0.592ns 2.21ns 0.015 0 0 1.1 KB
#3165 CallElasticsearchAsync net472 2.59μs 1.18ns 4.42ns 0.205 0 0 1.29 KB
#3165 CallElasticsearchAsync netcoreapp3.1 1.67μs 0.664ns 2.4ns 0.0159 0 0 1.22 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.6μs 6.16ns 23.8ns 0.226 0 0 1.42 KB
master ExecuteAsync netcoreapp3.1 1.73μs 3.22ns 12.5ns 0.0182 0 0 1.34 KB
#3165 ExecuteAsync net472 2.65μs 5.96ns 23.1ns 0.225 0 0 1.42 KB
#3165 ExecuteAsync netcoreapp3.1 1.73μs 1.93ns 7.48ns 0.0182 0 0 1.34 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.67μs 11ns 41.2ns 0.44 0 0 2.77 KB
master SendAsync netcoreapp3.1 3.53μs 5.94ns 21.4ns 0.0355 0 0 2.6 KB
#3165 SendAsync net472 5.65μs 9.34ns 36.2ns 0.437 0 0 2.77 KB
#3165 SendAsync netcoreapp3.1 3.65μs 5.26ns 19.7ns 0.0362 0 0 2.6 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.19μs 2.97ns 11.5ns 0.288 0 0 1.81 KB
master EnrichedLog netcoreapp3.1 2.55μs 1.56ns 5.62ns 0.0241 0 0 1.85 KB
#3165 EnrichedLog net472 3.08μs 1.6ns 6.18ns 0.287 0 0 1.81 KB
#3165 EnrichedLog netcoreapp3.1 2.55μs 1.52ns 5.67ns 0.0243 0 0 1.85 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 149μs 95.3ns 357ns 0.678 0.226 0 4.65 KB
master EnrichedLog netcoreapp3.1 114μs 109ns 409ns 0.0576 0 0 4.49 KB
#3165 EnrichedLog net472 150μs 148ns 572ns 0.668 0.223 0 4.65 KB
#3165 EnrichedLog netcoreapp3.1 116μs 223ns 865ns 0.0574 0 0 4.49 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.64μs 14.9ns 55.9ns 0.57 0.00279 0 3.59 KB
master EnrichedLog netcoreapp3.1 4.49μs 11.5ns 44.4ns 0.0517 0 0 3.91 KB
#3165 EnrichedLog net472 5.59μs 6.76ns 24.4ns 0.569 0.0028 0 3.59 KB
#3165 EnrichedLog netcoreapp3.1 4.4μs 7.42ns 27.7ns 0.0524 0 0 3.91 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.3μs 0.831ns 2.99ns 0.218 0 0 1.37 KB
master SendReceive netcoreapp3.1 1.78μs 0.47ns 1.76ns 0.0178 0 0 1.32 KB
#3165 SendReceive net472 2.3μs 1.27ns 4.91ns 0.218 0 0 1.37 KB
#3165 SendReceive netcoreapp3.1 1.86μs 0.78ns 2.92ns 0.0175 0 0 1.32 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.08μs 1.2ns 4.33ns 0.353 0 0 2.23 KB
master EnrichedLog netcoreapp3.1 4.18μs 1.1ns 4.11ns 0.0229 0 0 1.8 KB
#3165 EnrichedLog net472 5.15μs 1.77ns 6.62ns 0.352 0 0 2.23 KB
#3165 EnrichedLog netcoreapp3.1 4.23μs 1.55ns 5.8ns 0.0234 0 0 1.8 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.14μs 0.429ns 1.66ns 0.129 0 0 810 B
master StartFinishSpan netcoreapp3.1 959ns 0.41ns 1.59ns 0.0102 0 0 760 B
master StartFinishScope net472 1.38μs 0.59ns 2.29ns 0.141 0 0 891 B
master StartFinishScope netcoreapp3.1 1.08μs 0.377ns 1.41ns 0.0123 0 0 880 B
#3165 StartFinishSpan net472 1.17μs 0.421ns 1.63ns 0.129 0 0 810 B
#3165 StartFinishSpan netcoreapp3.1 949ns 0.559ns 2.02ns 0.0104 0 0 760 B
#3165 StartFinishScope net472 1.32μs 0.523ns 1.89ns 0.141 0 0 891 B
#3165 StartFinishScope netcoreapp3.1 1.08μs 0.394ns 1.53ns 0.0119 0 0 880 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.47μs 0.412ns 1.6ns 0.141 0 0 891 B
master RunOnMethodBegin netcoreapp3.1 1.23μs 0.415ns 1.5ns 0.0117 0 0 880 B
#3165 RunOnMethodBegin net472 1.48μs 0.406ns 1.52ns 0.141 0 0 891 B
#3165 RunOnMethodBegin netcoreapp3.1 1.2μs 0.583ns 2.26ns 0.012 0 0 880 B

@andrewlock

andrewlock commented Sep 4, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

✔️ Merging #3165 into master will not change line coverage
✔️ Merging #3165 into master will not change branch coverage
✔️ Merging #3165 into master will will decrease complexity by 2

master #3165 Change
Lines 17566 / 24155 17565 / 24151
Lines % 73% 73% 0% ✔️
Branches 10400 / 14873 10401 / 14871
Branches % 70% 70% 0% ✔️
Complexity 16056 16054 -2 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3165 Change
Lines % 73% 73% 0% ✔️
Branches % 70% 70% 0% ✔️
Complexity 16056 16054 -2 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Agent.Transports.SocketHandlerRequestFactory -7% ⛔ 0% ✔️ 0 ✔️
Datadog.Trace.Debugger.Sink.AgentBatchUploadApi -1% ⚠️ -17% ⛔ -2 ✔️
Datadog.Trace.Ci.CIVisibility 5% ✔️ 6% ✔️ 0 ✔️

View the full reports for further details:

@shurivich
shurivich merged commit 41c954c into master Sep 4, 2022
@shurivich
shurivich deleted the shurivich/remove_snapshot_uri branch September 4, 2022 12:51
@github-actions github-actions Bot added this to the vNext milestone Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OmerRaviv OmerRaviv OmerRaviv approved these changes

Assignees

@shurivich shurivich

Labels

area:debugger area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

3 participants

@shurivich @andrewlock @OmerRaviv