Skip to content

Fix warnings#3155

Merged
chrisnas merged 12 commits into
masterfrom
chrisnas/fix_warnings
Sep 7, 2022
Merged

Fix warnings#3155
chrisnas merged 12 commits into
masterfrom
chrisnas/fix_warnings

Conversation

@chrisnas

@chrisnas chrisnas commented Sep 2, 2022

Copy link
Copy Markdown
Contributor

Summary of changes

Fix warnings

Reason for change

Pollute CI output

Implementation details

Test coverage

Other details

@chrisnas
chrisnas requested review from a team as code owners September 2, 2022 12:58
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock

This comment has been minimized.

Sign in to view
gleocadie
gleocadie approved these changes Sep 6, 2022
View reviewed changes

@gleocadie gleocadie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewlock

andrewlock commented Sep 6, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #3155 compared to master:

  • All benchmarks have the same speed
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 722μs 545ns 2.11μs 0.363 0 0 3.18 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 470μs 311ns 1.2μs 0 0 0 2.58 KB
#3155 WriteAndFlushEnrichedTraces net472 739μs 347ns 1.3μs 0.365 0 0 3.18 KB
#3155 WriteAndFlushEnrichedTraces netcoreapp3.1 453μs 281ns 1.09μs 0 0 0 2.58 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 188ns 0.209ns 0.808ns 0.0676 0 0 425 B
master AllCycleSimpleBody netcoreapp3.1 237ns 0.303ns 1.17ns 0.00575 0 0 424 B
master AllCycleMoreComplexBody net472 190ns 0.62ns 2.4ns 0.0637 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 233ns 0.25ns 0.967ns 0.00542 0 0 400 B
master BodyExtractorSimpleBody net472 280ns 0.305ns 1.1ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 223ns 0.31ns 1.16ns 0.0037 0 0 272 B
master BodyExtractorMoreComplexBody net472 14.4μs 15ns 58ns 1.21 0.0217 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 11.8μs 23.1ns 86.6ns 0.0882 0 0 6.75 KB
#3155 AllCycleSimpleBody net472 185ns 0.165ns 0.64ns 0.0675 0 0 425 B
#3155 AllCycleSimpleBody netcoreapp3.1 234ns 0.337ns 1.26ns 0.0058 0 0 424 B
#3155 AllCycleMoreComplexBody net472 190ns 0.119ns 0.459ns 0.0637 0 0 401 B
#3155 AllCycleMoreComplexBody netcoreapp3.1 232ns 0.361ns 1.35ns 0.00557 0 0 400 B
#3155 BodyExtractorSimpleBody net472 261ns 0.253ns 0.979ns 0.0574 0 0 361 B
#3155 BodyExtractorSimpleBody netcoreapp3.1 215ns 0.206ns 0.8ns 0.00365 0 0 272 B
#3155 BodyExtractorMoreComplexBody net472 14.6μs 11.6ns 43.2ns 1.2 0.0219 0 7.62 KB
#3155 BodyExtractorMoreComplexBody netcoreapp3.1 11.9μs 12.1ns 45.1ns 0.0896 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 183μs 245ns 948ns 0.275 0 0 20.57 KB
#3155 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3155 SendRequest netcoreapp3.1 180μs 155ns 602ns 0.269 0 0 20.57 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.84μs 0.874ns 3.38ns 0.15 0.000925 0 947 B
master ExecuteNonQuery netcoreapp3.1 1.4μs 0.477ns 1.79ns 0.0127 0 0 936 B
#3155 ExecuteNonQuery net472 1.85μs 0.59ns 2.29ns 0.15 0.000921 0 947 B
#3155 ExecuteNonQuery netcoreapp3.1 1.49μs 0.537ns 2.08ns 0.0126 0 0 936 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.44μs 1.22ns 4.56ns 0.183 0 0 1.16 KB
master CallElasticsearch netcoreapp3.1 1.49μs 0.688ns 2.67ns 0.0149 0 0 1.1 KB
master CallElasticsearchAsync net472 2.77μs 1.51ns 5.85ns 0.205 0 0 1.29 KB
master CallElasticsearchAsync netcoreapp3.1 1.62μs 0.555ns 2ns 0.0163 0 0 1.22 KB
#3155 CallElasticsearch net472 2.41μs 0.87ns 3.14ns 0.183 0 0 1.16 KB
#3155 CallElasticsearch netcoreapp3.1 1.59μs 1.2ns 4.47ns 0.015 0 0 1.1 KB
#3155 CallElasticsearchAsync net472 2.62μs 2.79ns 10.8ns 0.205 0 0 1.29 KB
#3155 CallElasticsearchAsync netcoreapp3.1 1.65μs 0.895ns 3.47ns 0.0164 0 0 1.22 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.71μs 5.23ns 20.3ns 0.226 0 0 1.42 KB
master ExecuteAsync netcoreapp3.1 1.73μs 3.81ns 14.3ns 0.0183 0 0 1.34 KB
#3155 ExecuteAsync net472 2.61μs 4.65ns 18ns 0.225 0 0 1.42 KB
#3155 ExecuteAsync netcoreapp3.1 1.69μs 3.47ns 13.4ns 0.0186 0 0 1.34 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.84μs 8.18ns 31.7ns 0.439 0 0 2.77 KB
master SendAsync netcoreapp3.1 3.69μs 7.05ns 27.3ns 0.0352 0 0 2.6 KB
#3155 SendAsync net472 5.69μs 22.7ns 88ns 0.439 0 0 2.77 KB
#3155 SendAsync netcoreapp3.1 3.65μs 6ns 22.4ns 0.0359 0 0 2.6 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.1μs 2.88ns 11.1ns 0.287 0 0 1.81 KB
master EnrichedLog netcoreapp3.1 2.51μs 2.05ns 7.96ns 0.0251 0 0 1.85 KB
#3155 EnrichedLog net472 3.12μs 2.73ns 10.6ns 0.287 0 0 1.81 KB
#3155 EnrichedLog netcoreapp3.1 2.56μs 1.44ns 5.4ns 0.0255 0 0 1.85 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 152μs 50.6ns 182ns 0.687 0.229 0 4.65 KB
master EnrichedLog netcoreapp3.1 119μs 183ns 708ns 0.0591 0 0 4.49 KB
#3155 EnrichedLog net472 153μs 153ns 593ns 0.691 0.23 0 4.65 KB
#3155 EnrichedLog netcoreapp3.1 117μs 187ns 723ns 0.0574 0 0 4.49 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.71μs 8.28ns 31ns 0.568 0.00283 0 3.59 KB
master EnrichedLog netcoreapp3.1 4.55μs 5.78ns 22.4ns 0.0516 0 0 3.91 KB
#3155 EnrichedLog net472 5.46μs 12.2ns 47.1ns 0.568 0.0027 0 3.59 KB
#3155 EnrichedLog netcoreapp3.1 4.36μs 9.07ns 35.1ns 0.0539 0 0 3.91 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.31μs 2.39ns 9.27ns 0.217 0 0 1.37 KB
master SendReceive netcoreapp3.1 1.84μs 1.45ns 5.6ns 0.0183 0 0 1.32 KB
#3155 SendReceive net472 2.43μs 7.32ns 27.4ns 0.218 0 0 1.37 KB
#3155 SendReceive netcoreapp3.1 1.85μs 0.804ns 3.11ns 0.0175 0 0 1.32 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 4.99μs 1.49ns 5.58ns 0.353 0 0 2.23 KB
master EnrichedLog netcoreapp3.1 4.39μs 0.742ns 2.68ns 0.0241 0 0 1.8 KB
#3155 EnrichedLog net472 5.02μs 1.99ns 7.43ns 0.353 0 0 2.23 KB
#3155 EnrichedLog netcoreapp3.1 4.37μs 2.99ns 11.2ns 0.024 0 0 1.8 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.12μs 0.635ns 2.29ns 0.129 0 0 810 B
master StartFinishSpan netcoreapp3.1 963ns 0.489ns 1.83ns 0.0101 0 0 760 B
master StartFinishScope net472 1.35μs 0.538ns 2.08ns 0.141 0 0 891 B
master StartFinishScope netcoreapp3.1 1.17μs 4.86ns 18.8ns 0.0115 0 0 880 B
#3155 StartFinishSpan net472 1.23μs 0.278ns 1.08ns 0.128 0 0 810 B
#3155 StartFinishSpan netcoreapp3.1 970ns 0.416ns 1.56ns 0.0102 0 0 760 B
#3155 StartFinishScope net472 1.44μs 0.569ns 2.2ns 0.141 0 0 891 B
#3155 StartFinishScope netcoreapp3.1 1.07μs 0.292ns 1.13ns 0.0121 0 0 880 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.54μs 0.407ns 1.58ns 0.141 0 0 891 B
master RunOnMethodBegin netcoreapp3.1 1.16μs 0.657ns 2.54ns 0.0123 0 0 880 B
#3155 RunOnMethodBegin net472 1.5μs 0.691ns 2.59ns 0.142 0 0 891 B
#3155 RunOnMethodBegin netcoreapp3.1 1.17μs 0.303ns 1.13ns 0.0118 0 0 880 B

@andrewlock

andrewlock commented Sep 6, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

✔️ Merging #3155 into master will not change line coverage
✔️ Merging #3155 into master will not change branch coverage
✔️ Merging #3155 into master will not change complexity

master #3155 Change
Lines 17629 / 24209 17700 / 24209
Lines % 73% 73% 0% ✔️
Branches 10432 / 14900 10471 / 14900
Branches % 70% 70% 0% ✔️
Complexity 16087 16087 0 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3155 Change
Lines % 73% 73% 0% ✔️
Branches % 70% 70% 0% ✔️
Complexity 16087 16087 0 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Debugger.ProbeStatuses.ProbeStatusPoller 0% ✔️ -6% ⛔ 0 ✔️
Datadog.Trace.Ci.CIVisibility 5% ✔️ 6% ✔️ 0 ✔️
Datadog.Trace.Ci.GitInfo 5% ✔️ 8% ✔️ 0 ✔️

View the full reports for further details:

@chrisnas
chrisnas merged commit 454669a into master Sep 7, 2022
@chrisnas
chrisnas deleted the chrisnas/fix_warnings branch September 7, 2022 06:47
@github-actions github-actions Bot added this to the vNext milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes
@gleocadie gleocadie gleocadie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

4 participants

@chrisnas @andrewlock @zacharycmontoya @gleocadie