Skip to content

[Profiler] Performance improvements for samples management#3153

Merged
chrisnas merged 1 commit into
masterfrom
chrisnas/improve_perf_vector_pushback
Sep 2, 2022
Merged

[Profiler] Performance improvements for samples management#3153
chrisnas merged 1 commit into
masterfrom
chrisnas/improve_perf_vector_pushback

Conversation

@chrisnas

@chrisnas chrisnas commented Sep 2, 2022

Copy link
Copy Markdown
Contributor

Summary of changes

Reduce allocations in samples management

Reason for change

Focus on hot spots in high allocations scenario

Implementation details

  • precompute thread id and name
  • reserve vector for frames

Test coverage

using superluminal native profiler to check the change impacts

Other details

@chrisnas
chrisnas requested a review from a team as a code owner September 2, 2022 07:09
@github-actions github-actions Bot added the area:profiler Issues related to the continous-profiler label Sep 2, 2022

@gleocadie gleocadie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisnas
chrisnas merged commit 7d3eacc into master Sep 2, 2022
@chrisnas
chrisnas deleted the chrisnas/improve_perf_vector_pushback branch September 2, 2022 09:52
@github-actions github-actions Bot added this to the vNext milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:profiler Issues related to the continous-profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants