Skip to content

Set the version of the native loader#3147

Merged
kevingosse merged 2 commits into
masterfrom
kevin/native_loader_version
Sep 2, 2022
Merged

Set the version of the native loader#3147
kevingosse merged 2 commits into
masterfrom
kevin/native_loader_version

Conversation

@kevingosse

@kevingosse kevingosse commented Sep 1, 2022

Copy link
Copy Markdown
Contributor

Summary of changes

Currently the native loader is shipped without setting the version number. This PR aligns it with the native tracer and the continuous profiler.

Reason for change

The version number is one of the information checked by the dd-trace diagnostic tool.

Test coverage

The tool integration tests on Windows would detect that, if they were running.

@kevingosse
kevingosse requested review from a team as code owners September 1, 2022 09:23
@andrewlock

andrewlock commented Sep 1, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #3147 compared to master:

  • 1 benchmarks are slower, with geometric mean 1.122
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 711μs 423ns 1.64μs 0.355 0 0 3.18 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 463μs 124ns 463ns 0 0 0 2.58 KB
#3147 WriteAndFlushEnrichedTraces net472 713μs 533ns 2.06μs 0.357 0 0 3.18 KB
#3147 WriteAndFlushEnrichedTraces netcoreapp3.1 478μs 498ns 1.86μs 0 0 0 2.58 KB
Benchmarks.Trace.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #3147

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 1.122 183.08 205.36

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 183ns 0.137ns 0.514ns 0.0675 0 0 425 B
master AllCycleSimpleBody netcoreapp3.1 238ns 0.22ns 0.854ns 0.00577 0 0 424 B
master AllCycleMoreComplexBody net472 184ns 0.164ns 0.615ns 0.0637 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 233ns 0.243ns 0.939ns 0.0055 0 0 400 B
master BodyExtractorSimpleBody net472 265ns 0.43ns 1.66ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 226ns 0.193ns 0.747ns 0.00375 0 0 272 B
master BodyExtractorMoreComplexBody net472 14.3μs 9.58ns 35.8ns 1.21 0.0213 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 12.2μs 11.2ns 43.3ns 0.0912 0 0 6.75 KB
#3147 AllCycleSimpleBody net472 205ns 0.125ns 0.45ns 0.0676 0 0 425 B
#3147 AllCycleSimpleBody netcoreapp3.1 237ns 0.34ns 1.32ns 0.00595 0 0 424 B
#3147 AllCycleMoreComplexBody net472 184ns 0.221ns 0.856ns 0.0637 0 0 401 B
#3147 AllCycleMoreComplexBody netcoreapp3.1 234ns 0.286ns 1.07ns 0.00543 0 0 400 B
#3147 BodyExtractorSimpleBody net472 253ns 0.271ns 1.05ns 0.0573 0 0 361 B
#3147 BodyExtractorSimpleBody netcoreapp3.1 227ns 0.227ns 0.85ns 0.00375 0 0 272 B
#3147 BodyExtractorMoreComplexBody net472 14.2μs 10.7ns 41.3ns 1.21 0.0212 0 7.62 KB
#3147 BodyExtractorMoreComplexBody netcoreapp3.1 12.5μs 17.2ns 64.3ns 0.0872 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 180μs 105ns 407ns 0.268 0 0 20.57 KB
#3147 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3147 SendRequest netcoreapp3.1 183μs 198ns 768ns 0.274 0 0 20.57 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.85μs 0.969ns 3.63ns 0.15 0.000929 0 947 B
master ExecuteNonQuery netcoreapp3.1 1.49μs 0.436ns 1.63ns 0.0126 0 0 936 B
#3147 ExecuteNonQuery net472 1.86μs 0.579ns 2.17ns 0.15 0.000931 0 947 B
#3147 ExecuteNonQuery netcoreapp3.1 1.41μs 0.834ns 3.23ns 0.0126 0 0 936 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.53μs 0.96ns 3.59ns 0.183 0 0 1.16 KB
master CallElasticsearch netcoreapp3.1 1.6μs 0.627ns 2.35ns 0.015 0 0 1.1 KB
master CallElasticsearchAsync net472 2.68μs 0.987ns 3.82ns 0.205 0 0 1.29 KB
master CallElasticsearchAsync netcoreapp3.1 1.66μs 0.654ns 2.53ns 0.0165 0 0 1.22 KB
#3147 CallElasticsearch net472 2.55μs 0.995ns 3.85ns 0.183 0 0 1.16 KB
#3147 CallElasticsearch netcoreapp3.1 1.61μs 0.592ns 2.14ns 0.0144 0 0 1.1 KB
#3147 CallElasticsearchAsync net472 2.68μs 0.583ns 2.18ns 0.205 0 0 1.29 KB
#3147 CallElasticsearchAsync netcoreapp3.1 1.64μs 1.28ns 4.8ns 0.0166 0 0 1.22 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.57μs 4.99ns 19.3ns 0.224 0 0 1.41 KB
master ExecuteAsync netcoreapp3.1 1.7μs 4.53ns 16.3ns 0.0176 0 0 1.34 KB
#3147 ExecuteAsync net472 2.74μs 3.91ns 14.6ns 0.223 0 0 1.41 KB
#3147 ExecuteAsync netcoreapp3.1 1.68μs 3.65ns 13.6ns 0.0185 0 0 1.34 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.7μs 13ns 50.4ns 0.439 0 0 2.77 KB
master SendAsync netcoreapp3.1 3.63μs 9.08ns 35.2ns 0.0359 0 0 2.6 KB
#3147 SendAsync net472 5.78μs 15.7ns 60.8ns 0.438 0 0 2.77 KB
#3147 SendAsync netcoreapp3.1 3.58μs 9.15ns 35.4ns 0.0357 0 0 2.6 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.12μs 1.72ns 6.2ns 0.288 0 0 1.81 KB
master EnrichedLog netcoreapp3.1 2.43μs 0.409ns 1.42ns 0.0244 0 0 1.85 KB
#3147 EnrichedLog net472 3.21μs 1.13ns 3.91ns 0.287 0 0 1.81 KB
#3147 EnrichedLog netcoreapp3.1 2.47μs 1.24ns 4.64ns 0.0244 0 0 1.85 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 150μs 219ns 847ns 0.678 0.226 0 4.65 KB
master EnrichedLog netcoreapp3.1 117μs 178ns 691ns 0.0575 0 0 4.49 KB
#3147 EnrichedLog net472 149μs 57.2ns 221ns 0.676 0.225 0 4.65 KB
#3147 EnrichedLog netcoreapp3.1 118μs 164ns 613ns 0.059 0 0 4.49 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.5μs 12.5ns 48.5ns 0.568 0.00275 0 3.59 KB
master EnrichedLog netcoreapp3.1 4.48μs 8.43ns 32.6ns 0.0533 0 0 3.91 KB
#3147 EnrichedLog net472 5.48μs 13.4ns 51.8ns 0.57 0.00273 0 3.59 KB
#3147 EnrichedLog netcoreapp3.1 4.39μs 11.1ns 40.1ns 0.054 0 0 3.91 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.23μs 1.21ns 4.51ns 0.217 0 0 1.37 KB
master SendReceive netcoreapp3.1 1.8μs 0.593ns 2.22ns 0.0179 0 0 1.32 KB
#3147 SendReceive net472 2.42μs 3.26ns 12.6ns 0.217 0 0 1.37 KB
#3147 SendReceive netcoreapp3.1 1.82μs 0.586ns 2.19ns 0.0181 0 0 1.32 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.14μs 1.12ns 4.03ns 0.353 0 0 2.23 KB
master EnrichedLog netcoreapp3.1 4.29μs 2.18ns 8.14ns 0.0237 0 0 1.8 KB
#3147 EnrichedLog net472 5.2μs 1.57ns 6.08ns 0.354 0 0 2.23 KB
#3147 EnrichedLog netcoreapp3.1 4.18μs 2.12ns 7.93ns 0.023 0 0 1.8 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.1μs 0.39ns 1.46ns 0.128 0 0 810 B
master StartFinishSpan netcoreapp3.1 942ns 0.385ns 1.44ns 0.0103 0 0 760 B
master StartFinishScope net472 1.39μs 0.328ns 1.23ns 0.141 0 0 891 B
master StartFinishScope netcoreapp3.1 1.06μs 0.372ns 1.34ns 0.0119 0 0 880 B
#3147 StartFinishSpan net472 1.13μs 0.295ns 1.1ns 0.128 0 0 810 B
#3147 StartFinishSpan netcoreapp3.1 917ns 0.181ns 0.651ns 0.0101 0 0 760 B
#3147 StartFinishScope net472 1.48μs 0.973ns 3.77ns 0.141 0 0 891 B
#3147 StartFinishScope netcoreapp3.1 1.08μs 0.656ns 2.46ns 0.0118 0 0 880 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.46μs 0.671ns 2.6ns 0.141 0 0 891 B
master RunOnMethodBegin netcoreapp3.1 1.18μs 1.28ns 4.94ns 0.0117 0 0 880 B
#3147 RunOnMethodBegin net472 1.51μs 0.47ns 1.7ns 0.141 0 0 891 B
#3147 RunOnMethodBegin netcoreapp3.1 1.15μs 0.649ns 2.43ns 0.0115 0 0 880 B

@andrewlock

andrewlock commented Sep 1, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

✔️ Merging #3147 into master will not change line coverage
✔️ Merging #3147 into master will not change branch coverage
✔️ Merging #3147 into master will not change complexity

master #3147 Change
Lines 17420 / 23769 17460 / 23771
Lines % 73% 73% 0% ✔️
Branches 10309 / 14621 10328 / 14621
Branches % 71% 71% 0% ✔️
Complexity 15784 15784 0 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3147 Change
Lines % 73% 73% 0% ✔️
Branches % 71% 71% 0% ✔️
Complexity 15784 15784 0 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Telemetry.Transports.JsonTelemetryTransport -9% ⛔ -17% ⛔ 0 ✔️
Datadog.Trace.Ci.CIVisibility 5% ✔️ 6% ✔️ 0 ✔️
Datadog.Trace.Ci.GitInfo 5% ✔️ 7% ✔️ 0 ✔️

View the full reports for further details:

OmerRaviv
OmerRaviv approved these changes Sep 1, 2022
View reviewed changes

@OmerRaviv OmerRaviv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gleocadie
gleocadie approved these changes Sep 2, 2022
View reviewed changes

@gleocadie gleocadie left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevingosse
kevingosse merged commit e113e43 into master Sep 2, 2022
@kevingosse
kevingosse deleted the kevin/native_loader_version branch September 2, 2022 08:07
@github-actions github-actions Bot added this to the vNext milestone Sep 2, 2022
andrewlock added a commit that referenced this pull request Sep 26, 2022
@andrewlock
Update the list of expected file changes in version bump
6df0d49 
#3147 updated the native loader to set the version correctly. That means we expect these two files to change when we do a version bump
@andrewlock andrewlock mentioned this pull request Sep 26, 2022
Merged
andrewlock added a commit that referenced this pull request Sep 26, 2022
@andrewlock
Update the list of expected file changes in version bump (#3259)
255c62c 
#3147 updated the native loader to set the version correctly. That means we expect these two files to change when we do a version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OmerRaviv OmerRaviv OmerRaviv approved these changes
@zacharycmontoya zacharycmontoya zacharycmontoya approved these changes
@gleocadie gleocadie gleocadie approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

5 participants

@kevingosse @andrewlock @OmerRaviv @zacharycmontoya @gleocadie