Skip to content

[Profiler] Update SamplesCollectorTest#3145

Merged
kevingosse merged 2 commits into
masterfrom
kevin/kevingosse-patch-1
Sep 2, 2022
Merged

[Profiler] Update SamplesCollectorTest#3145
kevingosse merged 2 commits into
masterfrom
kevin/kevingosse-patch-1

Conversation

@kevingosse

@kevingosse kevingosse commented Aug 31, 2022

Copy link
Copy Markdown
Contributor

Summary of changes

  • Increase the delay to reduce flackiness
  • Change the MockExporter to AtLeast(3) to account for the increased delay
  • Change the expected number of calls to sampleProvider to "more than 1" (since the first call to Add will not throw an exception, it's guaranteed that the sampleProvider would be called once, even if the error handling code didn't work)

Reason for change

Karma and peace of mind

@kevingosse kevingosse added the area:profiler Issues related to the continous-profiler label Aug 31, 2022
@kevingosse
kevingosse requested a review from a team as a code owner August 31, 2022 13:37
@kevingosse
kevingosse merged commit 00e73a2 into master Sep 2, 2022
@kevingosse
kevingosse deleted the kevin/kevingosse-patch-1 branch September 2, 2022 09:03
@github-actions github-actions Bot added this to the vNext milestone Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gleocadie gleocadie gleocadie approved these changes

Assignees

No one assigned

Labels

area:profiler Issues related to the continous-profiler

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

2 participants

@kevingosse @gleocadie