Make sure we throw if uploading artifacts to S3 fails in gitlab#3116
Merged
Conversation
andrewlock
added
the
area:builds
lucaspimentel
approved these changes
Aug 23, 2022
zacharycmontoya
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Make sure we detect upload failures
Reason for change
The s3 upload is flaky, but we weren't detecting it in the previous code.
Implementation details
Check the exit code from
aws s3 cpTest coverage
Manual checking
Other details
We can retry the publish stage only when it fails, worst case, but it's annoying