Skip to content

[Test Package Versions Bump] Updating package versions#3008

Merged
andrewlock merged 1 commit into
masterfrom
bot/test-package-versions-bump
Sep 7, 2022
Merged

[Test Package Versions Bump] Updating package versions#3008
andrewlock merged 1 commit into
masterfrom
bot/test-package-versions-bump

Conversation

@github-actions

@github-actions github-actions Bot commented Jul 25, 2022

Copy link
Copy Markdown
Contributor

Updates the package versions for integration tests.

@github-actions
github-actions Bot requested review from a team as code owners July 25, 2022 16:34
@andrewlock

This comment has been minimized.

Sign in to view
andrewlock
andrewlock reviewed Jul 26, 2022
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😡 Stop lying about .NET Standard! :shakes-fist:

@andrewlock

This comment has been minimized.

Sign in to view
andrewlock
andrewlock reviewed Jul 26, 2022
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like our ServiceStack.Redis integration broke in 6.2.0 (it works in 6.1.0) :eyetwitch:

@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from a0d11aa to 7503a58 Compare August 5, 2022 16:36
@andrewlock

This comment has been minimized.

Sign in to view
@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from 7503a58 to c385103 Compare August 8, 2022 16:44
@andrewlock

This comment has been minimized.

Sign in to view
@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from c385103 to ee589d2 Compare August 16, 2022 16:31
@andrewlock

This comment has been minimized.

Sign in to view
@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from ee589d2 to 99b2e27 Compare August 19, 2022 16:28
@andrewlock

This comment has been minimized.

Sign in to view
@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from 99b2e27 to 665db58 Compare August 22, 2022 16:32
@andrewlock

This comment has been minimized.

Sign in to view
@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from 665db58 to dcf1375 Compare August 23, 2022 16:31
@andrewlock

This comment has been minimized.

Sign in to view
@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from dcf1375 to d11e61d Compare August 30, 2022 16:36
@andrewlock

This comment has been minimized.

Sign in to view
@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from d11e61d to c20bd67 Compare September 2, 2022 14:55
@andrewlock

This comment has been minimized.

Sign in to view
@github-actions
github-actions Bot force-pushed the bot/test-package-versions-bump branch from c20bd67 to 0cc6fd8 Compare September 6, 2022 19:21
@andrewlock

This comment has been minimized.

Sign in to view
@andrewlock
andrewlock force-pushed the bot/test-package-versions-bump branch from 0cc6fd8 to de42732 Compare September 7, 2022 09:01
@andrewlock

andrewlock commented Sep 7, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #3008 compared to master:

  • 2 benchmarks are slower, with geometric mean 1.184
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 736μs 205ns 767ns 0.368 0 0 3.18 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 462μs 178ns 642ns 0 0 0 2.58 KB
#3008 WriteAndFlushEnrichedTraces net472 716μs 632ns 2.45μs 0.357 0 0 3.18 KB
#3008 WriteAndFlushEnrichedTraces netcoreapp3.1 469μs 96ns 359ns 0 0 0 2.58 KB
Benchmarks.Trace.AppSecBodyBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #3008

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleSimpleBody‑net472 1.249 184.10 229.95
Benchmarks.Trace.AppSecBodyBenchmark.AllCycleMoreComplexBody‑net472 1.123 183.65 206.24

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 184ns 0.152ns 0.57ns 0.0676 0 0 425 B
master AllCycleSimpleBody netcoreapp3.1 240ns 0.257ns 0.961ns 0.00574 0 0 424 B
master AllCycleMoreComplexBody net472 184ns 0.175ns 0.655ns 0.0638 0 0 401 B
master AllCycleMoreComplexBody netcoreapp3.1 246ns 0.403ns 1.56ns 0.00539 0 0 400 B
master BodyExtractorSimpleBody net472 257ns 0.369ns 1.33ns 0.0573 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 227ns 0.39ns 1.51ns 0.00372 0 0 272 B
master BodyExtractorMoreComplexBody net472 15μs 11.9ns 44.6ns 1.21 0.015 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 11.8μs 15.7ns 61ns 0.088 0 0 6.75 KB
#3008 AllCycleSimpleBody net472 230ns 0.2ns 0.773ns 0.0675 0 0 425 B
#3008 AllCycleSimpleBody netcoreapp3.1 236ns 0.428ns 1.66ns 0.00566 0 0 424 B
#3008 AllCycleMoreComplexBody net472 206ns 0.16ns 0.554ns 0.0637 0 0 401 B
#3008 AllCycleMoreComplexBody netcoreapp3.1 234ns 0.307ns 1.19ns 0.0055 0 0 400 B
#3008 BodyExtractorSimpleBody net472 275ns 0.301ns 1.09ns 0.0573 0 0 361 B
#3008 BodyExtractorSimpleBody netcoreapp3.1 233ns 0.291ns 1.09ns 0.00366 0 0 272 B
#3008 BodyExtractorMoreComplexBody net472 14.5μs 13.3ns 51.7ns 1.2 0.0147 0 7.62 KB
#3008 BodyExtractorMoreComplexBody netcoreapp3.1 11.9μs 14.8ns 57.5ns 0.089 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 181μs 117ns 451ns 0.27 0 0 20.57 KB
#3008 SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
#3008 SendRequest netcoreapp3.1 180μs 144ns 559ns 0.179 0 0 20.57 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 1.87μs 0.659ns 2.55ns 0.15 0.000933 0 947 B
master ExecuteNonQuery netcoreapp3.1 1.37μs 0.871ns 3.26ns 0.0123 0 0 936 B
#3008 ExecuteNonQuery net472 1.8μs 0.408ns 1.47ns 0.15 0.000903 0 947 B
#3008 ExecuteNonQuery netcoreapp3.1 1.5μs 0.695ns 2.69ns 0.012 0 0 936 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.61μs 0.914ns 3.42ns 0.183 0 0 1.16 KB
master CallElasticsearch netcoreapp3.1 1.62μs 0.921ns 3.45ns 0.0146 0 0 1.1 KB
master CallElasticsearchAsync net472 2.65μs 9.11ns 37.5ns 0.204 0 0 1.29 KB
master CallElasticsearchAsync netcoreapp3.1 1.64μs 0.577ns 2.23ns 0.0167 0 0 1.22 KB
#3008 CallElasticsearch net472 2.53μs 0.349ns 1.35ns 0.184 0 0 1.16 KB
#3008 CallElasticsearch netcoreapp3.1 1.63μs 0.494ns 1.78ns 0.0146 0 0 1.1 KB
#3008 CallElasticsearchAsync net472 2.62μs 0.535ns 2ns 0.204 0 0 1.29 KB
#3008 CallElasticsearchAsync netcoreapp3.1 1.67μs 0.659ns 2.55ns 0.016 0 0 1.22 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 2.56μs 4.41ns 17.1ns 0.225 0 0 1.42 KB
master ExecuteAsync netcoreapp3.1 1.72μs 4.16ns 16.1ns 0.0187 0 0 1.34 KB
#3008 ExecuteAsync net472 2.6μs 4.17ns 15.6ns 0.226 0 0 1.42 KB
#3008 ExecuteAsync netcoreapp3.1 1.78μs 3.59ns 13.9ns 0.0186 0 0 1.34 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 5.66μs 11.6ns 45ns 0.437 0 0 2.77 KB
master SendAsync netcoreapp3.1 3.57μs 8.98ns 33.6ns 0.0353 0 0 2.6 KB
#3008 SendAsync net472 5.68μs 12.9ns 46.7ns 0.44 0 0 2.77 KB
#3008 SendAsync netcoreapp3.1 3.54μs 5.88ns 21.2ns 0.0357 0 0 2.6 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.34μs 9.1ns 34ns 0.288 0 0 1.81 KB
master EnrichedLog netcoreapp3.1 2.62μs 1.56ns 5.82ns 0.0248 0 0 1.85 KB
#3008 EnrichedLog net472 3.19μs 3.08ns 11.9ns 0.287 0 0 1.81 KB
#3008 EnrichedLog netcoreapp3.1 2.51μs 0.821ns 3.18ns 0.025 0 0 1.85 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 150μs 88.6ns 332ns 0.67 0.223 0 4.65 KB
master EnrichedLog netcoreapp3.1 117μs 182ns 706ns 0.0581 0 0 4.49 KB
#3008 EnrichedLog net472 151μs 46.7ns 175ns 0.673 0.224 0 4.65 KB
#3008 EnrichedLog netcoreapp3.1 115μs 158ns 612ns 0.0572 0 0 4.49 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5.54μs 12.7ns 49.2ns 0.568 0.00273 0 3.59 KB
master EnrichedLog netcoreapp3.1 4.32μs 9.85ns 38.1ns 0.0525 0 0 3.91 KB
#3008 EnrichedLog net472 5.57μs 11.7ns 45.4ns 0.568 0.00281 0 3.59 KB
#3008 EnrichedLog netcoreapp3.1 4.34μs 8.78ns 34ns 0.0525 0 0 3.91 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.27μs 0.776ns 2.9ns 0.218 0 0 1.37 KB
master SendReceive netcoreapp3.1 1.79μs 2.92ns 10.9ns 0.0178 0 0 1.32 KB
#3008 SendReceive net472 2.21μs 2ns 7.75ns 0.218 0 0 1.37 KB
#3008 SendReceive netcoreapp3.1 1.91μs 0.456ns 1.77ns 0.0181 0 0 1.32 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 5μs 1.79ns 6.94ns 0.354 0 0 2.23 KB
master EnrichedLog netcoreapp3.1 4.36μs 1.22ns 4.73ns 0.024 0 0 1.8 KB
#3008 EnrichedLog net472 5.08μs 1.72ns 6.67ns 0.352 0 0 2.23 KB
#3008 EnrichedLog netcoreapp3.1 4.32μs 1.23ns 4.61ns 0.0237 0 0 1.8 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 1.09μs 0.485ns 1.88ns 0.129 0 0 810 B
master StartFinishSpan netcoreapp3.1 929ns 0.334ns 1.25ns 0.0102 0 0 760 B
master StartFinishScope net472 1.35μs 0.518ns 1.94ns 0.141 0 0 891 B
master StartFinishScope netcoreapp3.1 1.13μs 0.302ns 1.13ns 0.0119 0 0 880 B
#3008 StartFinishSpan net472 1.2μs 0.389ns 1.51ns 0.128 0 0 810 B
#3008 StartFinishSpan netcoreapp3.1 919ns 0.397ns 1.54ns 0.0101 0 0 760 B
#3008 StartFinishScope net472 1.42μs 0.279ns 1.01ns 0.141 0 0 891 B
#3008 StartFinishScope netcoreapp3.1 1.06μs 0.348ns 1.35ns 0.0122 0 0 880 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.53μs 0.587ns 2.27ns 0.141 0 0 891 B
master RunOnMethodBegin netcoreapp3.1 1.21μs 0.32ns 1.2ns 0.012 0 0 880 B
#3008 RunOnMethodBegin net472 1.54μs 0.426ns 1.54ns 0.141 0 0 891 B
#3008 RunOnMethodBegin netcoreapp3.1 1.18μs 0.436ns 1.63ns 0.0117 0 0 880 B

@andrewlock

andrewlock commented Sep 7, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

✔️ Merging #3008 into master will not change line coverage
✔️ Merging #3008 into master will not change branch coverage
✔️ Merging #3008 into master will not change complexity

master #3008 Change
Lines 17684 / 24285 17710 / 24285
Lines % 73% 73% 0% ✔️
Branches 10429 / 14926 10445 / 14926
Branches % 70% 70% 0% ✔️
Complexity 16121 16121 0 ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

master #3008 Change
Lines % 73% 73% 0% ✔️
Branches % 70% 70% 0% ✔️
Complexity 16121 16121 0 ✔️

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.Ci.CIVisibility 5% ✔️ 6% ✔️ 0 ✔️

View the full reports for further details:

andrewlock
andrewlock approved these changes Sep 7, 2022
View reviewed changes

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to add support for GraphQL 7 and Microsoft.Data.SqlClient 5.x, but everything else looks good

Comment thread tracer/dependabot/Datadog.Dependabot.Integrations.csproj
Comment on lines +56 to 57
<!-- Latest package https://www.nuget.org/packages/GraphQL/7.0.2 -->
<PackageReference Include="GraphQL" Version="5.3.3" />

@andrewlock andrewlock Sep 7, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires new package support

@andrewlock
andrewlock merged commit a0c6b21 into master Sep 7, 2022
@andrewlock
andrewlock deleted the bot/test-package-versions-bump branch September 7, 2022 10:59
@github-actions github-actions Bot added this to the vNext milestone Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.15.0

Development

Successfully merging this pull request may close these issues.

1 participant

@andrewlock