[Profiler] Use libdatadog as buffer#2990
Merged
Merged
Conversation
kevingosse
force-pushed
the
kevin/no_buffer
branch
2 times, most recently
from
July 25, 2022 14:06
881ae9c to
db9ed5c
Compare
gleocadie
approved these changes
Jul 27, 2022
kevingosse
force-pushed
the
kevin/no_buffer
branch
from
July 27, 2022 13:49
db9ed5c to
fcfe098
Compare
gleocadie
force-pushed
the
kevin/no_buffer
branch
from
July 29, 2022 12:59
7a61998 to
dd8f1a7
Compare
kevingosse
force-pushed
the
kevin/no_buffer
branch
from
August 3, 2022 09:37
dd8f1a7 to
ccc0d10
Compare
kevingosse
force-pushed
the
kevin/no_buffer
branch
from
August 23, 2022 15:02
ccc0d10 to
15f8017
Compare
kevingosse
force-pushed
the
kevin/no_buffer
branch
from
August 24, 2022 10:04
15f8017 to
c2351b5
Compare
chrisnas
reviewed
Aug 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Instead of having an intermediary buffer in the
SamplesAggregator, have theSamplesCollectordirectly push the samples to libdatadog.Reason for change
Slight optimization (since libdatadog directly aggregates the samples), plus laying the groundwork for supporting endpoint aggregation.