Skip to content

[Profiler] Add the profiler deployment script to the bumping process#2705

Merged
gleocadie merged 1 commit into
masterfrom
gleocadie/change-version-handling-for-script
Apr 21, 2022
Merged

[Profiler] Add the profiler deployment script to the bumping process#2705
gleocadie merged 1 commit into
masterfrom
gleocadie/change-version-handling-for-script

Conversation

@gleocadie

@gleocadie gleocadie commented Apr 20, 2022

Copy link
Copy Markdown
Collaborator

The previous script was not working correctly. So move to a well-known/working one.

@gleocadie
gleocadie requested a review from a team as a code owner April 20, 2022 12:40
@github-actions github-actions Bot added area:builds project files, build scripts, pipelines, versioning, releases, packages area:profiler Issues related to the continous-profiler labels Apr 20, 2022
@andrewlock

andrewlock commented Apr 20, 2022

Copy link
Copy Markdown
Member

Code Coverage Report 📊

⚠️ Merging #2705 into master will will decrease line coverage by 1%
⚠️ Merging #2705 into master will will decrease branch coverage by 1%
⛔ Merging #2705 into master will will increase complexity by 208

master #2705 Change
Lines 13549 / 18651 13630 / 18911
Lines % 73% 72% -1% ⚠️
Branches 7821 / 11131 7946 / 11393
Branches % 70% 70% -1% ⚠️
Complexity 12416 12624 208 ⛔

View the full report for further details:

Datadog.Trace Breakdown ⚠️

master #2705 Change
Lines % 73% 72% -1% ⚠️
Branches % 70% 70% -1% ⚠️
Complexity 12416 12624 208 ⛔

The following classes have significant coverage changes.

File Line coverage change Branch coverage change Complexity change
Datadog.Trace.TracerManager -30% ⛔ -34% ⛔ 88 ⛔
Datadog.Trace.TracerManagerFactory -28% ⛔ -37% ⛔ 60 ⛔
Datadog.Trace.Ci.GitInfo -17% ⛔ -11% ⛔ 0 ✔️
Datadog.Trace.Configuration.ImmutableTracerSettings -7% ⛔ -5% ⛔ 21 ⛔
Datadog.Trace.Configuration.TracerSettings -6% ⛔ -8% ⛔ 37 ⛔
Datadog.Trace.Ci.CIVisibility 7% ✔️ 7% ✔️ 0 ✔️
Datadog.Trace.Telemetry.JsonWebRequestTelemetryTransport 27% ✔️ 57% ✔️ 0 ✔️

View the full reports for further details:

@andrewlock

andrewlock commented Apr 20, 2022

Copy link
Copy Markdown
Member

Benchmarks Report 🐌

Benchmarks for #2705 compared to master:

  • 2 benchmarks are faster, with geometric mean 1.238
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net472 948μs 4.28μs 18.2μs 0 0 0 3.16 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 712μs 3.47μs 13.9μs 0 0 0 2.57 KB
#2705 WriteAndFlushEnrichedTraces net472 1.02ms 2.97μs 11.1μs 0 0 0 3.16 KB
#2705 WriteAndFlushEnrichedTraces netcoreapp3.1 725μs 3.48μs 13.9μs 0 0 0 2.57 KB
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master AllCycleSimpleBody net472 316ns 1.21ns 4.35ns 0.066 0 0 417 B
master AllCycleSimpleBody netcoreapp3.1 423ns 1.27ns 4.92ns 0.00581 0 0 416 B
master AllCycleMoreComplexBody net472 318ns 1.35ns 5.24ns 0.0622 0 0 393 B
master AllCycleMoreComplexBody netcoreapp3.1 414ns 1.51ns 5.64ns 0.00541 0 0 392 B
master BodyExtractorSimpleBody net472 480ns 2.22ns 8.31ns 0.057 0 0 361 B
master BodyExtractorSimpleBody netcoreapp3.1 443ns 2.36ns 12ns 0.00387 0 0 272 B
master BodyExtractorMoreComplexBody net472 24.6μs 119ns 492ns 1.19 0.0119 0 7.62 KB
master BodyExtractorMoreComplexBody netcoreapp3.1 22.2μs 129ns 1.07μs 0.094 0 0 6.75 KB
#2705 AllCycleSimpleBody net472 336ns 1.91ns 13.6ns 0.066 0 0 417 B
#2705 AllCycleSimpleBody netcoreapp3.1 425ns 2.24ns 13.2ns 0.00583 0 0 416 B
#2705 AllCycleMoreComplexBody net472 324ns 1.78ns 11.2ns 0.0622 0 0 393 B
#2705 AllCycleMoreComplexBody netcoreapp3.1 420ns 2.37ns 15.5ns 0.00542 0 0 392 B
#2705 BodyExtractorSimpleBody net472 441ns 2.28ns 10.9ns 0.057 0 0 361 B
#2705 BodyExtractorSimpleBody netcoreapp3.1 456ns 2.65ns 23.3ns 0.00363 0 0 272 B
#2705 BodyExtractorMoreComplexBody net472 24.5μs 118ns 487ns 1.18 0.0126 0 7.62 KB
#2705 BodyExtractorMoreComplexBody netcoreapp3.1 21.1μs 112ns 604ns 0.0963 0 0 6.75 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net472 0ns 0ns 0ns 0 0 0 0 b
master SendRequest netcoreapp3.1 296μs 1.26μs 4.71μs 0.143 0 0 19.74 KB
#2705 SendRequest net472 0.00136ns 0.00136ns 0.00881ns 0 0 0 0 b
#2705 SendRequest netcoreapp3.1 291μs 1.33μs 5.34μs 0.146 0 0 19.74 KB
Benchmarks.Trace.DbCommandBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #2705

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.DbCommandBenchmark.ExecuteNonQuery‑net472 1.301 2,239.68 1,720.97

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net472 2.24μs 11.3ns 49.4ns 0.0938 0 0 594 B
master ExecuteNonQuery netcoreapp3.1 1.5μs 7.03ns 27.2ns 0.00888 0 0 632 B
#2705 ExecuteNonQuery net472 1.73μs 9.65ns 62.5ns 0.0936 0.000821 0 594 B
#2705 ExecuteNonQuery netcoreapp3.1 1.54μs 6.97ns 27ns 0.00844 0 0 632 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net472 2.77μs 15.9ns 120ns 0.125 0 0 802 B
master CallElasticsearch netcoreapp3.1 1.81μs 9.39ns 46ns 0.0107 0 0 792 B
master CallElasticsearchAsync net472 2.98μs 12ns 45ns 0.149 0.00148 0 939 B
master CallElasticsearchAsync netcoreapp3.1 1.84μs 8.07ns 31.3ns 0.0127 0 0 912 B
#2705 CallElasticsearch net472 2.91μs 15.2ns 76ns 0.126 0 0 803 B
#2705 CallElasticsearch netcoreapp3.1 1.72μs 6.53ns 25.3ns 0.0107 0 0 792 B
#2705 CallElasticsearchAsync net472 3.06μs 16.8ns 138ns 0.147 0 0 939 B
#2705 CallElasticsearchAsync netcoreapp3.1 1.93μs 8.97ns 33.6ns 0.0126 0 0 912 B
Benchmarks.Trace.GraphQLBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #2705

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.GraphQLBenchmark.ExecuteAsync‑net472 1.178 3,818.05 3,240.97

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net472 3.81μs 19.9ns 93.4ns 0.167 0.00177 0 1.06 KB
master ExecuteAsync netcoreapp3.1 2.12μs 11.6ns 90.7ns 0.0138 0 0 1.03 KB
#2705 ExecuteAsync net472 3.23μs 16.5ns 75.5ns 0.167 0.00165 0 1.06 KB
#2705 ExecuteAsync netcoreapp3.1 2.15μs 7.3ns 28.3ns 0.0139 0 0 1.03 KB
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net472 7.23μs 33.9ns 140ns 0.361 0 0 2.28 KB
master SendAsync netcoreapp3.1 4.96μs 19.8ns 74.2ns 0.0293 0 0 2.21 KB
#2705 SendAsync net472 7.19μs 36.2ns 201ns 0.359 0 0 2.28 KB
#2705 SendAsync netcoreapp3.1 5.54μs 26.3ns 153ns 0.0304 0 0 2.21 KB
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 3.43μs 18.7ns 106ns 0.227 0 0 1.45 KB
master EnrichedLog netcoreapp3.1 3.22μs 18.2ns 124ns 0.0211 0 0 1.53 KB
#2705 EnrichedLog net472 3.42μs 17ns 74.1ns 0.227 0 0 1.45 KB
#2705 EnrichedLog netcoreapp3.1 3.25μs 18ns 103ns 0.0208 0 0 1.53 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 290μs 1.56μs 8.54μs 0.424 0.141 0 4.33 KB
master EnrichedLog netcoreapp3.1 232μs 1.04μs 4.04μs 0 0 0 4.21 KB
#2705 EnrichedLog net472 295μs 1.63μs 10.4μs 0.442 0.147 0 4.33 KB
#2705 EnrichedLog netcoreapp3.1 242μs 1.36μs 8.81μs 0 0 0 4.21 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 7.64μs 36.1ns 140ns 0.507 0 0 3.23 KB
master EnrichedLog netcoreapp3.1 6.92μs 37ns 248ns 0.0492 0 0 3.6 KB
#2705 EnrichedLog net472 7.99μs 45.8ns 358ns 0.504 0 0 3.23 KB
#2705 EnrichedLog netcoreapp3.1 6.45μs 33.6ns 158ns 0.0509 0 0 3.6 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net472 2.39μs 13.4ns 84.6ns 0.158 0 0 1.01 KB
master SendReceive netcoreapp3.1 2.08μs 7.63ns 33.3ns 0.0142 0 0 1.01 KB
#2705 SendReceive net472 2.54μs 10.7ns 41.6ns 0.16 0.00125 0 1.01 KB
#2705 SendReceive netcoreapp3.1 2.2μs 10.2ns 39.3ns 0.0138 0 0 1.01 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net472 6.22μs 25.7ns 96.3ns 0.293 0 0 1.87 KB
master EnrichedLog netcoreapp3.1 5.36μs 20.5ns 79.5ns 0.0184 0 0 1.49 KB
#2705 EnrichedLog net472 6.17μs 33.4ns 177ns 0.29 0 0 1.87 KB
#2705 EnrichedLog netcoreapp3.1 5.45μs 28.2ns 129ns 0.0188 0 0 1.49 KB
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net472 908ns 4.27ns 16.5ns 0.0716 0 0 457 B
master StartFinishSpan netcoreapp3.1 879ns 3.82ns 14.8ns 0.00615 0 0 456 B
master StartFinishScope net472 1.1μs 5.92ns 31.9ns 0.0846 0 0 538 B
master StartFinishScope netcoreapp3.1 1.06μs 5.27ns 23.6ns 0.00784 0 0 576 B
#2705 StartFinishSpan net472 1.01μs 5.03ns 22.5ns 0.0719 0 0 457 B
#2705 StartFinishSpan netcoreapp3.1 901ns 4.53ns 19.2ns 0.006 0 0 456 B
#2705 StartFinishScope net472 1.11μs 6.12ns 39.2ns 0.0844 0 0 538 B
#2705 StartFinishScope netcoreapp3.1 1.1μs 6.34ns 50.3ns 0.00775 0 0 576 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net472 1.39μs 7.63ns 47.7ns 0.0838 0 0 538 B
master RunOnMethodBegin netcoreapp3.1 1.2μs 6.26ns 31.3ns 0.00764 0 0 576 B
#2705 RunOnMethodBegin net472 1.25μs 3.18ns 11ns 0.0844 0 0 538 B
#2705 RunOnMethodBegin netcoreapp3.1 1.29μs 7.23ns 49.6ns 0.00801 0 0 576 B

@gleocadie
gleocadie merged commit 540b5b9 into master Apr 21, 2022
@gleocadie
gleocadie deleted the gleocadie/change-version-handling-for-script branch April 21, 2022 09:02
@github-actions github-actions Bot added this to the vNext milestone Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewlock andrewlock andrewlock approved these changes
@pierotibou pierotibou pierotibou approved these changes

Assignees

No one assigned

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages area:profiler Issues related to the continous-profiler

Projects

None yet

Milestone

2.7.0

Development

Successfully merging this pull request may close these issues.

3 participants

@gleocadie @andrewlock @pierotibou