[Profiler] Do not export empty profiles#2701
Merged
Merged
Conversation
github-actions
Bot
added
the
area:profiler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
When running on IIS, we can end up in a situation where no thread is running in an AppDomain, so no callstack will be collected for this AppDomain/Application.
But still, every minute we send one profile per application to the back-end and we have empty profiles in the dashboard.
Implementation details
Keep the count of samples added to each profile. Check that count to decide if the profile has to be sent or not.
Test coverage
Adding unit test.
Other details
This is a simple implementation. A refactoring is needed and will be done after the 2nd beta release.