Labeler shouldn't check test folders for tracer and integrations areas#2683
Merged
Conversation
github-actions
Bot
added
the
area:builds
pierotibou
force-pushed
the
pierre/ooohh-labels
branch
from
April 13, 2022 13:51
dae0a6b to
44e58f1
Compare
andrewlock
approved these changes
Apr 13, 2022
andrewlock
left a comment
andrewlock
left a comment
Member
There was a problem hiding this comment.
I have no idea what these Regexes are doing so LGTM 😉
zacharycmontoya
approved these changes
Apr 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Not checking if all files are within test folders when checking tracer and integrations areas.
Reason for change
It was over labelling obviously. The labeler should actually handle tests differently, but this can be improved later as those areas were already best effort.