Skip to content

Pass the environment variable to the docker container#2678

Merged
gleocadie merged 1 commit into
masterfrom
gleocadie/fix-build-in-gitlab2
Apr 13, 2022
Merged

Pass the environment variable to the docker container#2678
gleocadie merged 1 commit into
masterfrom
gleocadie/fix-build-in-gitlab2

Conversation

@gleocadie

Copy link
Copy Markdown
Collaborator

Summary of changes

Reason for change

The environment variable was set in the build process and not in the docker container.

Implementation details

Just pass the environment variable on the command-line that runs the Docker container.

Test coverage

Other details

@gleocadie
gleocadie requested a review from a team as a code owner April 12, 2022 21:45
@github-actions github-actions Bot added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Apr 12, 2022

@andrewlock andrewlock left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh, good spot 👍

@gleocadie
gleocadie merged commit 028e1d2 into master Apr 13, 2022
@gleocadie
gleocadie deleted the gleocadie/fix-build-in-gitlab2 branch April 13, 2022 08:10
@github-actions github-actions Bot added this to the vNext milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:builds project files, build scripts, pipelines, versioning, releases, packages

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants