[Profiler] Do not compute a default output path for pprof files#2671
Merged
Conversation
If the environment variable is not set, do not compute an output path for pprof files. + since it's an internal env var, just rename it into DD_INTERNAL_XXXX
gleocadie
force-pushed
the
gleocadie/fix-pprof-file-saving-on-disk
branch
from
April 12, 2022 09:00
03106c8 to
0fd542f
Compare
chrisnas
reviewed
Apr 12, 2022
gleocadie
force-pushed
the
gleocadie/fix-pprof-file-saving-on-disk
branch
from
April 12, 2022 12:49
0fd542f to
306240a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
If the environment variable is not set, do not create a default output path for pprof files.
Reason for change
Writting pprof files on disk is only for debugging/development purpose. So by default, there is no need to write them on disk (so no need to compute a default output path).
Implementation details
Remove the computation of the default output path if the env var is not set.
DD_INTERNAL_PROFILING_OUTPUT_DIRsince it's an internal flag.Test coverage
Other details