Skip to content

[Profiler] Fix Code Hotspots tests#2669

Merged
gleocadie merged 1 commit into
masterfrom
gleocadie/fix-codehotspot-tests
Apr 12, 2022
Merged

[Profiler] Fix Code Hotspots tests#2669
gleocadie merged 1 commit into
masterfrom
gleocadie/fix-codehotspot-tests

Conversation

@gleocadie

Copy link
Copy Markdown
Collaborator

Summary of changes

Reason for change

Lately we changed the Code Hotspots default activation (Activated by default). One Code Hotspots test is failing (no trace context if deactivated).

Implementation details

Set the environment variable to deactivate Code Hotspot

Test coverage

Other details

By default, Code Hotspots feature is activated. So we need to set it to 0
to deactivate it
@gleocadie
gleocadie requested a review from a team as a code owner April 11, 2022 21:26
@gleocadie gleocadie added the area:profiler Issues related to the continous-profiler label Apr 11, 2022
@gleocadie
gleocadie merged commit 5372e75 into master Apr 12, 2022
@gleocadie
gleocadie deleted the gleocadie/fix-codehotspot-tests branch April 12, 2022 08:59
@github-actions github-actions Bot added this to the vNext milestone Apr 12, 2022

@chrisnas chrisnas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:profiler Issues related to the continous-profiler

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants