[Profiler] Add beta revision in the profiler version#2664
Merged
gleocadie merged 2 commits intoApr 12, 2022
Conversation
luhenry
approved these changes
Apr 11, 2022
pierotibou
reviewed
Apr 11, 2022
pierotibou
approved these changes
Apr 12, 2022
gleocadie
deleted the
gleocadie/fix-version-in-profiler-deployed-artifact
branch
April 12, 2022 08:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Today, the beta revision is not part of the version of the profiler (when sending the pprof). We would like it to be part of the version so we can track issues/features.
Implementation details
Add a
PROFILER_BETA_REVISIONvariable indd_profiler_version.hTest coverage
Other details