[Profiler] Use libddprof-based pipeline by default + cache value#2659
Merged
gleocadie merged 3 commits intoApr 11, 2022
Merged
Conversation
gleocadie
force-pushed
the
gleocadie/turn-on-by-default-new-profiler-pipeline
branch
from
April 11, 2022 06:29
f5e139b to
c093bf1
Compare
gleocadie
marked this pull request as ready for review
April 11, 2022 06:35
luhenry
approved these changes
Apr 11, 2022
gleocadie
deleted the
gleocadie/turn-on-by-default-new-profiler-pipeline
branch
April 11, 2022 10:55
chrisnas
reviewed
Apr 11, 2022
| public void CheckSmoke(string appName, string framework, string appAssembly) | ||
| { | ||
| using var runner = new SmokeTestRunner(appName, framework, appAssembly, _output); | ||
| using var runner = new SmokeTestRunner(appName, framework, appAssembly, _output, enableNewPipeline: false); |
Contributor
There was a problem hiding this comment.
Shouldn't we test with the new pipeline?
| } | ||
|
|
||
| public SmokeTestRunner(string appName, string framework, string appAssembly, string commandLine, ITestOutputHelper output, bool enabledNewPipeline = false) | ||
| public SmokeTestRunner(string appName, string framework, string appAssembly, string commandLine, ITestOutputHelper output, bool enableNewPipeline = false) |
Contributor
There was a problem hiding this comment.
Shouldn't we test with the new pipeline by default?
Collaborator
Author
There was a problem hiding this comment.
not needed since we will soon remove the code
| public void CheckSmoke(string appName, string framework, string appAssembly) | ||
| { | ||
| using var runner = new SmokeTestRunner(appName, framework, appAssembly, _output); | ||
| using var runner = new SmokeTestRunner(appName, framework, appAssembly, _output, enableNewPipeline: false); |
Contributor
There was a problem hiding this comment.
Shouldn't we test with the new pipeline?
Collaborator
Author
There was a problem hiding this comment.
already done ... look farther in the file :P
| public void CheckSmoke(string appName, string framework, string appAssembly) | ||
| { | ||
| using var runner = new SmokeTestRunner(appName, framework, appAssembly, _output, enableNewPipeline: true); | ||
| using var runner = new SmokeTestRunner(appName, framework, appAssembly, _output, enableNewPipeline: false); |
Contributor
There was a problem hiding this comment.
EnableNewPipeline parameter could be removed if, in SmokeTestRunner.cs, it takes true as default value. That way, this parameter should only appear if its value is set to false. And in the future, it should even disappear.
This applies to all xxxTest.cs files of that review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Reason for change
Libddprof-based pipeline is the new pipeline. It has been tested and validated for a long time.
Implementation details
Change the default configuration value.
Test coverage
Other details