[Serverless] Send the lambda invocation context to our extension#2656
Merged
thedavlee merged 15 commits intoApr 18, 2022
Merged
Conversation
…nsion on StartInvocation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
thedavlee
marked this pull request as ready for review
April 12, 2022 15:14
thedavlee
changed the title
thedavlee
changed the title
thedavlee
marked this pull request as draft
April 12, 2022 15:39
This comment has been minimized.
This comment has been minimized.
…eaders-to-lambda-extension
thedavlee
marked this pull request as ready for review
April 13, 2022 22:12
thedavlee
changed the title
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Lucas Pimentel-Ordyna <[email protected]>
zacharycmontoya
approved these changes
Apr 14, 2022
zacharycmontoya
left a comment
zacharycmontoya
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I can think of a couple small improvements that could be added later because I don't want to block this work:
- Enabling C# nullable reference types in this file
- Caching a default JSON object so we don't make unnecessary calls to serialize "{}" which will create a new object each time
This comment has been minimized.
This comment has been minimized.
Contributor
|
Since Lucas commented on the PR some requesting changes, please wait until he approves before merging. Thanks! |
lucaspimentel
approved these changes
Apr 15, 2022
…eaders-to-lambda-extension
Member
Code Coverage Report 📊✔️ Merging #2656 into master will not change line coverage
View the full report for further details: Datadog.Trace Breakdown ✔️
The following classes have significant coverage changes.
View the full reports for further details: |
Member
Benchmarks Report 🐌Benchmarks for #2656 compared to master:
The following thresholds were used for comparing the benchmark speeds:
Allocation changes below 0.5% are ignored. Benchmark detailsBenchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AppSecBodyBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.SpanBenchmark - Same speed ✔️ Same allocations ✔️Raw results
Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️Raw results
|
9 tasks
thedavlee
deleted the
david.lee/serverless-send-lambda-context-headers-to-lambda-extension
branch
April 18, 2022 14:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
Send the lambda invocation context to the datadog extension on StartInvocation
Reason for change
The lambda invocation context contains trace metadata (trace-id, parent-id) that needs to be passed to the lambda extension for successful trace propagation
Implementation details
Test coverage
Manually tested in conjunction with lambda extension changes on a variety of dotnet lambda functions (no parameters, one parameter (context and custom input), two parameters)
Other details