add GitHub action to automatically label PRs based on file paths by lucaspimentel · Pull Request #2212 · DataDog/dd-trace-dotnet

lucaspimentel · 2021-12-21T18:50:01Z

Automatically label new pull requests based on the paths of files being changed.

https://github.com/actions/labeler#pull-request-labeler

andrewlock · 2021-12-23T15:12:20Z

+    - uses: actions/labeler@v2
+      with:
+        repo-token: "${{ secrets.GITHUB_TOKEN }}"
+        sync-labels: true


Will this mean labels we add manually would be removed, e.g. if it's not quite right? (I'm guessing it won't always be)

The docs say "Whether or not to remove labels when matching files are reverted or no longer changed by the PR."

Not clear if it removes tags added manually, or only removes tags that were added previously by the action. i.e. does it look at new commits looking for reverted changes? 🤷🏽

Co-authored-by: Andrew Lock <[email protected]>

This reverts commit 215c000.

lucaspimentel · 2022-01-04T22:53:02Z

Note: the checks are all failed or pending because I canceled the build. The changes in this PR do no affect the code of the build pipelines at all so no point in running them.

Co-authored-by: Zach Montoya <[email protected]>

andrewlock · 2022-01-11T02:37:56Z

Code Coverage Report 📊

✔️ Merging #2212 into master will not change line coverage
✔️ Merging #2212 into master will not change branch coverage
✔️ Merging #2212 into master will not change complexity

	master	#2212	Change
Lines	`9654` / `13538`	`9611` / `13538`
Lines %	`71%`	`71%`	`0%` ✔️
Branches	`4883` / `7011`	`4856` / `7011`
Branches %	`70%`	`69%`	`0%` ✔️
Complexity	`8175`	`8175`	`0` ✔️

View the full report for further details:

Datadog.Trace Breakdown ✔️

	master	#2212	Change
Lines %	`71%`	`71%`	`0%` ✔️
Branches %	`70%`	`69%`	`0%` ✔️
Complexity	`8175`	`8175`	`0` ✔️

The following classes have significant coverage changes.

File	Line coverage change	Branch coverage change	Complexity change
Datadog.Trace.ClrProfiler.AutoInstrumentation.Couchbase.IIOServiceExecuteIntegrationBis	`-100%` ⛔	`0%` ✔️	`0` ✔️
Datadog.Trace.ClrProfiler.AutoInstrumentation.Testing.MsTestV2.TestMethodRunnerExecuteIntegration	`-33%` ⛔	`-19%` ⛔	`0` ✔️
Datadog.Trace.Ci.Agent.CIAgentWriter	`-10%` ⛔	`-21%` ⛔	`0` ✔️
Datadog.Trace.ClrProfiler.AutoInstrumentation.Testing.NUnit.NUnitCompositeWorkItemSkipChildrenIntegration	`-8%` ⛔	`-8%` ⛔	`0` ✔️

View the full reports for further details:

andrewlock · 2022-01-11T03:25:06Z

Benchmarks Report 🐌

Benchmarks for #2212 compared to master:

1 benchmarks are faster, with geometric mean 1.191
1 benchmarks are slower, with geometric mean 1.163
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Allocated
master	`WriteAndFlushEnrichedTraces`	net472	895μs	4.48μs	19μs	3.16 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	704μs	2.84μs	11.7μs	2.57 KB
#2212	`WriteAndFlushEnrichedTraces`	net472	853μs	4.28μs	20.1μs	3.16 KB
#2212	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	684μs	3.83μs	24.5μs	2.57 KB

Benchmarks.Trace.AspNetCoreBenchmark - Unknown 🤷 Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
master	`SendRequest`	netcoreapp3.1	302μs	1.39μs	5.4μs	0.153	19.59 KB
#2212	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#2212	`SendRequest`	netcoreapp3.1	305μs	1.41μs	5.44μs	0.148	19.59 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net472	1.63μs	4.9ns	18.3ns	0.0899	0.000782	570 B
master	`ExecuteNonQuery`	netcoreapp3.1	1.41μs	4.29ns	16.1ns	0.00836	0	608 B
#2212	`ExecuteNonQuery`	net472	1.64μs	8.84ns	57.3ns	0.0902	0.000791	570 B
#2212	`ExecuteNonQuery`	netcoreapp3.1	1.43μs	5.38ns	20.8ns	0.00857	0	608 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net472	2.4μs	8.1ns	30.3ns	0.122	778 B
master	`CallElasticsearch`	netcoreapp3.1	1.63μs	7.07ns	27.4ns	0.0104	768 B
master	`CallElasticsearchAsync`	net472	2.73μs	8.09ns	30.3ns	0.143	915 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.8μs	7.03ns	26.3ns	0.0124	888 B
#2212	`CallElasticsearch`	net472	2.44μs	9.06ns	35.1ns	0.122	778 B
#2212	`CallElasticsearch`	netcoreapp3.1	1.6μs	8.71ns	46.9ns	0.0105	768 B
#2212	`CallElasticsearchAsync`	net472	3.02μs	14.3ns	57.2ns	0.143	915 B
#2212	`CallElasticsearchAsync`	netcoreapp3.1	1.78μs	6.2ns	22.3ns	0.0125	888 B

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net472	2.85μs	10.8ns	41.7ns	0.161	1.04 KB
master	`ExecuteAsync`	netcoreapp3.1	1.91μs	10.6ns	66.9ns	0.014	1.01 KB
#2212	`ExecuteAsync`	net472	2.9μs	12ns	46.4ns	0.161	1.04 KB
#2212	`ExecuteAsync`	netcoreapp3.1	1.9μs	6.38ns	23ns	0.014	1.01 KB

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net472	6.38μs	26.9ns	101ns	0.348	2.24 KB
master	`SendAsync`	netcoreapp3.1	4.5μs	14.5ns	54.3ns	0.0287	2.14 KB
#2212	`SendAsync`	net472	6.36μs	34.5ns	207ns	0.351	2.24 KB
#2212	`SendAsync`	netcoreapp3.1	4.52μs	16.7ns	62.4ns	0.0286	2.14 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net472	4.08μs	22.6ns	134ns	0.221	1.41 KB
master	`EnrichedLog`	netcoreapp3.1	3.25μs	17.2ns	94.3ns	0.0209	1.49 KB
#2212	`EnrichedLog`	net472	3.79μs	15.4ns	59.6ns	0.22	1.41 KB
#2212	`EnrichedLog`	netcoreapp3.1	3.33μs	19.4ns	169ns	0.02	1.49 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net472	209μs	939ns	3.64μs	0.519	0.208	4.29 KB
master	`EnrichedLog`	netcoreapp3.1	182μs	846ns	3.28μs	0	0	4.17 KB
#2212	`EnrichedLog`	net472	194μs	974ns	5.33μs	0.488	0.195	4.29 KB
#2212	`EnrichedLog`	netcoreapp3.1	165μs	782ns	3.32μs	0	0	4.17 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net472	7.47μs	29.2ns	113ns	0.5	3.19 KB
master	`EnrichedLog`	netcoreapp3.1	6.61μs	25.5ns	98.6ns	0.0484	3.56 KB
#2212	`EnrichedLog`	net472	7.43μs	35.7ns	138ns	0.499	3.19 KB
#2212	`EnrichedLog`	netcoreapp3.1	6.71μs	30.3ns	117ns	0.0495	3.56 KB

Benchmarks.Trace.RedisBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #2212

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.RedisBenchmark.SendReceive‑net472	1.163	2,159.99	2,513.03

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net472	2.15μs	10.4ns	44.1ns	0.154	987 B
master	`SendReceive`	netcoreapp3.1	1.98μs	9.83ns	41.7ns	0.0137	984 B
#2212	`SendReceive`	net472	2.6μs	18.6ns	180ns	0.154	987 B
#2212	`SendReceive`	netcoreapp3.1	2.08μs	10.6ns	51.9ns	0.0141	984 B

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net472	6.88μs	34.9ns	160ns	0.284	1.83 KB
master	`EnrichedLog`	netcoreapp3.1	5.31μs	23.2ns	127ns	0.0185	1.45 KB
#2212	`EnrichedLog`	net472	6.91μs	32.9ns	136ns	0.285	1.83 KB
#2212	`EnrichedLog`	netcoreapp3.1	5.45μs	31.2ns	227ns	0.0205	1.45 KB

Benchmarks.Trace.SpanBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #2212

Benchmark	base/diff	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net472	1.191	1,115.63	936.93

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net472	1.11μs	4.38ns	16.9ns	0.0677	433 B
master	`StartFinishSpan`	netcoreapp3.1	913ns	4.62ns	26.5ns	0.00576	432 B
master	`StartFinishScope`	net472	1.12μs	4.55ns	17.6ns	0.0804	514 B
master	`StartFinishScope`	netcoreapp3.1	1.03μs	4.13ns	16.5ns	0.00767	552 B
#2212	`StartFinishSpan`	net472	945ns	5.2ns	33.3ns	0.0681	433 B
#2212	`StartFinishSpan`	netcoreapp3.1	898ns	2.84ns	11ns	0.00614	432 B
#2212	`StartFinishScope`	net472	1.13μs	5.32ns	20.6ns	0.0807	514 B
#2212	`StartFinishScope`	netcoreapp3.1	1.03μs	4.99ns	20.6ns	0.00758	552 B

…ths (#2212)" This reverts commit 7234e71.

…ths (#2212)" (#2297) This reverts commit 7234e71.

lucaspimentel added the status:work-in-progress Actively worked on. If this is a PR, no review needed yet. WIP. label Dec 21, 2021

lucaspimentel force-pushed the lpimentel/action-labeler branch from 0a3c10f to e6e3d5f Compare December 21, 2021 19:17

github-actions Bot added the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Dec 21, 2021

lucaspimentel removed the area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) label Dec 21, 2021

lucaspimentel force-pushed the lpimentel/action-labeler branch from e863f56 to 5f78cd0 Compare December 21, 2021 19:36

lucaspimentel changed the title ~~[WIP] add a "labeler" GitHub action~~ add a "labeler" GitHub action Dec 21, 2021

lucaspimentel removed the status:work-in-progress Actively worked on. If this is a PR, no review needed yet. WIP. label Dec 21, 2021

lucaspimentel changed the title ~~add a "labeler" GitHub action~~ add GitHub action to automatic label PRs based on file paths Dec 21, 2021

lucaspimentel changed the title ~~add GitHub action to automatic label PRs based on file paths~~ add GitHub action to automatically label PRs based on file paths Dec 21, 2021

This comment has been minimized.

Sign in to view

lucaspimentel added 2 commits December 22, 2021 15:43

Create label.yml

de07d5a

add labeler.yml

ff22221

lucaspimentel force-pushed the lpimentel/action-labeler branch from 08e569a to ff22221 Compare December 22, 2021 20:44

This comment has been minimized.

Sign in to view

Update labeler.yml

34874e3

lucaspimentel marked this pull request as ready for review December 22, 2021 23:26

lucaspimentel requested a review from a team as a code owner December 22, 2021 23:26

This comment has been minimized.

Sign in to view

andrewlock approved these changes Dec 23, 2021

View reviewed changes

Update .github/labeler.yml

215c000

Co-authored-by: Andrew Lock <[email protected]>

This comment has been minimized.

Sign in to view

lucaspimentel added 5 commits January 3, 2022 12:49

use pull_request_target

a5b627c

Revert "Update .github/labeler.yml"

9ce67c3

This reverts commit 215c000.

update to actions/[email protected]

4fb85c5

revert back to "on: [pull_request]"

e82bcb0

v3 tag points to 3.0.2

0197367

zacharycmontoya reviewed Jan 6, 2022

View reviewed changes

Comment thread .github/labeler.yml

zacharycmontoya approved these changes Jan 6, 2022

View reviewed changes

include shared installer in area:installers

2926845

Co-authored-by: Zach Montoya <[email protected]>

lucaspimentel merged commit 7234e71 into master Jan 11, 2022

lucaspimentel deleted the lpimentel/action-labeler branch January 11, 2022 15:43

github-actions Bot added this to the vNext milestone Jan 11, 2022

lucaspimentel added a commit that referenced this pull request Jan 12, 2022

Revert "add GitHub action to automatically label PRs based on file pa…

9dcbf1e

…ths (#2212)" This reverts commit 7234e71.

lucaspimentel mentioned this pull request Jan 12, 2022

Revert "add GitHub action to automatically label PRs based on file paths" #2297

Merged

lucaspimentel added a commit that referenced this pull request Jan 12, 2022

Revert "add GitHub action to automatically label PRs based on file pa…

86a4e5f

…ths (#2212)" (#2297) This reverts commit 7234e71.

lucaspimentel added the area:builds project files, build scripts, pipelines, versioning, releases, packages label Jan 12, 2022

pierotibou mentioned this pull request Apr 9, 2022

Add simplistic labeller #2662

Merged

Uh oh!

Conversation

lucaspimentel commented Dec 21, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Uh oh!

Uh oh!

andrewlock Dec 23, 2021

Choose a reason for hiding this comment

Uh oh!

lucaspimentel Jan 3, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

lucaspimentel commented Jan 4, 2022

Uh oh!

Uh oh!

andrewlock commented Jan 11, 2022

Code Coverage Report 📊

Datadog.Trace Breakdown ✔️

Uh oh!

andrewlock commented Jan 11, 2022

Benchmarks Report 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #2212

Raw results

Raw results

Faster 🎉 in #2212

Raw results

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

lucaspimentel commented Dec 21, 2021 •

edited

Loading

lucaspimentel Jan 3, 2022 •

edited

Loading